From: Timur Tabi <timur@kernel.org>
To: Jeffrey Hugo <jhugo@codeaurora.org>
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Linus <linus.walleij@linaro.org>, Timur Tabi <timur@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
linux-gpio <linux-gpio@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 3/3] gpiolib: Show correct direction from the beginning
Date: Fri, 5 Oct 2018 11:54:03 -0500 [thread overview]
Message-ID: <CAOZdJXU=p0kz0PNhP8KwCQ0o7TuM=z2SvEz4b60_KveCrT7zPA@mail.gmail.com> (raw)
In-Reply-To: <8d10f9b4-7ea9-7d27-478a-39982ba49587@codeaurora.org>
On 10/05/2018 11:17 AM, Jeffrey Hugo wrote:>
> Looks like the driver is initing just fine to me. Is setting up the
> jumpers and running gpio-test warranted?
Well, that test only makes sure that input/output is actually working
on the hardware level, but it also makes sure that the GPIOs are
numbered correctly.
If you want, just put a printk(... offset) in msm_gpio_get() and read
from a GPIO that you know you have access to, and make sure the
'offset' is correct.
Then try reading from a GPIO that you don't have access to, and make
sure you get a failure before msm_gpio_get() is called.
next prev parent reply other threads:[~2018-10-05 16:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 6:52 [PATCH v5 1/3] gpiolib: Add init_valid_mask exported function Ricardo Ribalda Delgado
2018-10-05 6:52 ` [PATCH v5 2/3] pinctrl: msm: Use " Ricardo Ribalda Delgado
2018-10-07 13:03 ` Timur Tabi
2018-10-10 8:30 ` Linus Walleij
2018-10-05 6:53 ` [PATCH v5 3/3] gpiolib: Show correct direction from the beginning Ricardo Ribalda Delgado
2018-10-05 16:17 ` Jeffrey Hugo
2018-10-05 16:54 ` Timur Tabi [this message]
2018-10-05 20:44 ` Timur Tabi
2018-10-09 17:14 ` Jeffrey Hugo
2018-10-10 8:31 ` Linus Walleij
2018-10-11 12:18 ` Vignesh R
2018-10-11 13:42 ` Ricardo Ribalda Delgado
2018-10-12 5:59 ` Vignesh R
2018-10-12 6:03 ` Linus Walleij
2018-10-12 9:00 ` REGRESSION: " Marcel Ziswiler
2018-10-12 9:08 ` Linus Walleij
2018-10-12 9:34 ` Marcel Ziswiler
2018-10-10 7:55 ` [PATCH v5 1/3] gpiolib: Add init_valid_mask exported function Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOZdJXU=p0kz0PNhP8KwCQ0o7TuM=z2SvEz4b60_KveCrT7zPA@mail.gmail.com' \
--to=timur@kernel.org \
--cc=jhugo@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ricardo.ribalda@gmail.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).