From: Joe Perches <joe@perches.com>
To: Doug Anderson <dianders@chromium.org>
Cc: LinusW <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] gpio: Make "offset" and "unsigned int", not just "unsigned"
Date: Tue, 28 Apr 2020 19:32:48 -0700 [thread overview]
Message-ID: <8e225a3166998c441049e9561703f357919d5499.camel@perches.com> (raw)
In-Reply-To: <CAD=FV=VtUEgwwB6C4GhTKx3TP37=i4shtwbG41r=wkELcpNmyQ@mail.gmail.com>
On Tue, 2020-04-28 at 18:04 -0700, Doug Anderson wrote:
> Hi,
<slurring but replying with hi again...>
> On Tue, Apr 28, 2020 at 5:57 PM Joe Perches <joe@perches.com> wrote:
> > On Tue, 2020-04-28 at 17:50 -0700, Doug Anderson wrote:
> > > $ git grep -P -n '\bunsigned\s+(?!int|long)' include/linux/gpio/driver.h
> > include/linux/gpio/driver.h:352: unsigned offset);
> > include/linux/gpio/driver.h:354: unsigned offset);
> > include/linux/gpio/driver.h:356: unsigned offset);
> > include/linux/gpio/driver.h:358: unsigned offset);
> > include/linux/gpio/driver.h:360: unsigned offset, int value);
> > include/linux/gpio/driver.h:362: unsigned offset);
> > include/linux/gpio/driver.h:367: unsigned offset, int value);
> > include/linux/gpio/driver.h:372: unsigned offset,
> > include/linux/gpio/driver.h:375: unsigned offset);
> > include/linux/gpio/driver.h:462: unsigned offset);
> > include/linux/gpio/driver.h:660:int gpiochip_generic_request(struct gpio_chip *gc, unsigned offset);
> > include/linux/gpio/driver.h:661:void gpiochip_generic_free(struct gpio_chip *gc, unsigned offset);
> > include/linux/gpio/driver.h:662:int gpiochip_generic_config(struct gpio_chip *gc, unsigned offset,
>
> ...riiiiiggght. ...and now I run your sed script _after_ my patch
> and I get no hits. ...so I'm still confused about what you want me to
> do that's not already done in my patch.
So you did say it's the g&t.
It seems I only looked at the first diff block.
cheers, <hck>, Joe
next prev parent reply other threads:[~2020-04-29 2:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 0:23 [PATCH 1/2] gpio: Document proper return value for gpio drivers Douglas Anderson
2020-04-29 0:23 ` [PATCH 2/2] gpio: Make "offset" and "unsigned int", not just "unsigned" Douglas Anderson
2020-04-29 0:38 ` Joe Perches
2020-04-29 0:50 ` Doug Anderson
2020-04-29 0:57 ` Joe Perches
2020-04-29 1:04 ` Doug Anderson
2020-04-29 2:32 ` Joe Perches [this message]
2020-05-12 21:09 ` Andy Shevchenko
2020-04-29 12:19 ` Linus Walleij
2020-04-29 12:16 ` [PATCH 1/2] gpio: Document proper return value for gpio drivers Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e225a3166998c441049e9561703f357919d5499.camel@perches.com \
--to=joe@perches.com \
--cc=bgolaszewski@baylibre.com \
--cc=dianders@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).