From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Douglas Anderson <dianders@chromium.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] gpio: Make "offset" and "unsigned int", not just "unsigned"
Date: Wed, 13 May 2020 00:09:07 +0300 [thread overview]
Message-ID: <CAHp75VewDvjDJjvKgQ_5v_=Kxp6B1js0J+PrsfP-WC+qa=ogtQ@mail.gmail.com> (raw)
In-Reply-To: <a23b7a97f349e6f74b993a4e127564ad3f7d6929.camel@perches.com>
On Wed, Apr 29, 2020 at 3:40 AM Joe Perches <joe@perches.com> wrote:
> On Tue, 2020-04-28 at 17:23 -0700, Douglas Anderson wrote:
...
> + int (*request)(struct gpio_chip *gc, unsigned int offset);
> + void (*free)(struct gpio_chip *gc, unsigned int offset);
> + int (*get_direction)(struct gpio_chip *gc, unsigned int offset);
> + int (*direction_input)(struct gpio_chip *gc, unsigned int offset);
> + int (*direction_output)(struct gpio_chip *gc,
> + unsigned int offset, int value);
Here...
> + int (*get)(struct gpio_chip *gc, unsigned int offset);
> + int (*get_multiple)(struct gpio_chip *gc,
> + unsigned long *mask, unsigned long *bits);
> + void (*set)(struct gpio_chip *gc, unsigned int offset, int value);
> + void (*set_multiple)(struct gpio_chip *gc,
> + unsigned long *mask, unsigned long *bits);
> + int (*set_config)(struct gpio_chip *gc,
> + unsigned int offset, unsigned long config);
...and here perhaps offset to move to previous line despite checkpatch warnings.
> + int (*to_irq)(struct gpio_chip *gc, unsigned int offset);
> + void (*dbg_show)(struct seq_file *s, struct gpio_chip *gc);
> + int (*init_valid_mask)(struct gpio_chip *gc,
> + unsigned long *valid_mask,
> + unsigned int ngpios);
> + int (*add_pin_ranges)(struct gpio_chip *gc);
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-05-12 21:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 0:23 [PATCH 1/2] gpio: Document proper return value for gpio drivers Douglas Anderson
2020-04-29 0:23 ` [PATCH 2/2] gpio: Make "offset" and "unsigned int", not just "unsigned" Douglas Anderson
2020-04-29 0:38 ` Joe Perches
2020-04-29 0:50 ` Doug Anderson
2020-04-29 0:57 ` Joe Perches
2020-04-29 1:04 ` Doug Anderson
2020-04-29 2:32 ` Joe Perches
2020-05-12 21:09 ` Andy Shevchenko [this message]
2020-04-29 12:19 ` Linus Walleij
2020-04-29 12:16 ` [PATCH 1/2] gpio: Document proper return value for gpio drivers Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VewDvjDJjvKgQ_5v_=Kxp6B1js0J+PrsfP-WC+qa=ogtQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=dianders@chromium.org \
--cc=joe@perches.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).