Re: [PATCH 0/7] selftests/resctrl: Add resctrl selftest

From: "Moger, Babu" <Babu.Moger@amd.com>
To: Fenghua Yu <fenghua.yu@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, H Peter Anvin <hpa@zytor.com>,
	Tony Luck <tony.luck@intel.com>,
	Reinette Chatre <reinette.chatre@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	James Morse <james.morse@arm.com>,
	Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
	Arshiya Hayatkhan Pathan <arshiya.hayatkhan.pathan@intel.com>,
	Ravi V Shankar <ravi.v.shankar@intel.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/7] selftests/resctrl: Add resctrl selftest
Date: Tue, 16 Oct 2018 17:40:03 +0000	[thread overview]
Message-ID: <933e752f-2533-c982-cf0f-acd59ac50cde@amd.com> (raw)
In-Reply-To: <1539709001-38018-1-git-send-email-fenghua.yu@intel.com>

Hi Fenghua,

On 10/16/2018 11:56 AM, Fenghua Yu wrote:
> With more and more resctrl features are being added by Intel, AMD
> and ARM, a test tool is becoming more and more useful to validate
> that both hardware and software functionalities work as expected.

I like the initiative here. It is always good to have a single code base.

One question. I see that there is a tool at
https://github.com/intel/intel-cmt-cat to test and verify the
functionality of resctrl feature. I also see some of the distros have this
tool already. Is this tool going to replace intel-cmt-cat? I have not
looked at the patches closely yet.

> 
> We introduce resctrl selftest to cover resctrl features on both
> X86 and ARM architectures. It first implements MBM (Memory Bandwidth
> Monitoring) and MBA (Memory Bandwidth Allocation) tests. We can enhance
> the selftest tool to include more functionality tests in future.
> 
> The tests are in tools/testing/selftests/resctrl in order to have
> generic test code for all architectures.
> 
> Arshiya Hayatkhan Pathan (2):
>   selftests/resctrl: Add mbm test
>   selftests/resctrl: Add mba test
> 
> Fenghua Yu (1):
>   selftests/resctrl: Add the test in MAINTAINERS
> 
> Sai Praneeth Prakhya (4):
>   selftests/resctrl: Add basic resctrl file system operations and data
>   selftests/resctrl: Read memory bandwidth from perf IMC counter and
>     from resctrl file system
>   selftests/resctrl: Add callback to start a benchmark
>   selftests/resctrl: Add built in benchmark
> 
>  MAINTAINERS                                     |   1 +
>  tools/testing/selftests/resctrl/Makefile        |  16 ++
>  tools/testing/selftests/resctrl/fill_buf.c      | 178 ++++++++++++
>  tools/testing/selftests/resctrl/mba.c           | 144 ++++++++++
>  tools/testing/selftests/resctrl/mbm.c           | 113 ++++++++
>  tools/testing/selftests/resctrl/resctrl.c       | 367 ++++++++++++++++++++++++
>  tools/testing/selftests/resctrl/resctrl.h       | 107 +++++++
>  tools/testing/selftests/resctrl/resctrl_membw.c | 328 +++++++++++++++++++++
>  tools/testing/selftests/resctrl/resctrl_membw.h |  49 ++++
>  tools/testing/selftests/resctrl/resctrl_tests.c | 104 +++++++
>  tools/testing/selftests/resctrl/resctrl_val.c   | 192 +++++++++++++
>  11 files changed, 1599 insertions(+)
>  create mode 100644 tools/testing/selftests/resctrl/Makefile
>  create mode 100644 tools/testing/selftests/resctrl/fill_buf.c
>  create mode 100644 tools/testing/selftests/resctrl/mba.c
>  create mode 100644 tools/testing/selftests/resctrl/mbm.c
>  create mode 100644 tools/testing/selftests/resctrl/resctrl.c
>  create mode 100644 tools/testing/selftests/resctrl/resctrl.h
>  create mode 100644 tools/testing/selftests/resctrl/resctrl_membw.c
>  create mode 100644 tools/testing/selftests/resctrl/resctrl_membw.h
>  create mode 100644 tools/testing/selftests/resctrl/resctrl_tests.c
>  create mode 100644 tools/testing/selftests/resctrl/resctrl_val.c
> 