linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Moger, Babu" <Babu.Moger@amd.com>
To: "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@intel.com>,
	"Yu, Fenghua" <fenghua.yu@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, H Peter Anvin <hpa@zytor.com>,
	"Luck, Tony" <tony.luck@intel.com>,
	"Chatre, Reinette" <reinette.chatre@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	James Morse <james.morse@arm.com>,
	"Pathan, Arshiya Hayatkhan" <arshiya.hayatkhan.pathan@intel.com>,
	"Shankar, Ravi V" <ravi.v.shankar@intel.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/7] selftests/resctrl: Add resctrl selftest
Date: Wed, 17 Oct 2018 18:28:30 +0000	[thread overview]
Message-ID: <feb572ec-4495-c52c-0127-213417a67c3c@amd.com> (raw)
In-Reply-To: <FFF73D592F13FD46B8700F0A279B802F485D4D41@ORSMSX114.amr.corp.intel.com>



On 10/17/2018 12:28 PM, Prakhya, Sai Praneeth wrote:
>>> No, the selftest in this patch set will not replace intel-cmt-cat or
>>> vice versa.
>>>
>>> The selftest in this patch set has a different purpose from intel-cmt-cat:
>>> the selftest is a test tool which validates resctrl functionalities
>>> while intel-cmt-cat is mainly a utility that provides base library for
>>> higher level applications including performance analysis tools,
>>> benchmark measurement tools, and potential resctrl tests. For example,
>>> running MBA test in the selftests tells MBA working or not working
>>> (fail/pass) right way. The
>>
>> Ok. Sure. Let me take a look at selftest closely. Will send my feedback soon.
> 
> Great!
> 
>>
>>> intel-cmt-cat doesn't have this testing capability unless we extend
>>> the tool.
>>>
>>> And intel-cmt-cat is maintained and developed by Intel. I don't think
>>> it's easy to extend it to AMD and ARM features. The selftest will be
>>> maintained
>>
>> We1l.. We were hoping to have a common tool across. It makes it easy for
>> distros. Probably, we can have a separate discussion on this.
>>
> 
> The main goal of this test suite is to validate values reported by resctrl features 
> i.e. we need _some_way_ to check if values reported by resctrl features are 
> correct or not.
> 
> For (Intel) Memory Bandwidth features like MBA and MBM, perf iMC 
> (Integrated Memory Controller) is used for validation. As a part of test, we run a 
> benchmark (eg: fill_buf) and get memory bandwidth values from MBM and iMC 
> and verify if the difference between both the reported values are in a reasonable range.
> 
> To make this common across x86, could you please let us know if similar things 
> (i.e. perf iMC) exist on AMD? If so, you could add it in. The same applies for ARM.

We dont have iMC. You can go ahead with what you have right now. We can
add those details later if required.

> 
> Regards,
> Sai
> 

  reply	other threads:[~2018-10-17 18:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-16 16:56 [PATCH 0/7] selftests/resctrl: Add resctrl selftest Fenghua Yu
2018-10-16 16:56 ` [PATCH 1/7] selftests/resctrl: Add basic resctrl file system operations and data Fenghua Yu
2018-10-16 16:56 ` [PATCH 2/7] selftests/resctrl: Read memory bandwidth from perf IMC counter and from resctrl file system Fenghua Yu
2018-10-16 16:56 ` [PATCH 3/7] selftests/resctrl: Add callback to start a benchmark Fenghua Yu
2018-10-16 16:56 ` [PATCH 4/7] selftests/resctrl: Add built in benchmark Fenghua Yu
2018-10-16 16:56 ` [PATCH 5/7] selftests/resctrl: Add mbm test Fenghua Yu
2018-10-16 16:56 ` [PATCH 6/7] selftests/resctrl: Add mba test Fenghua Yu
2018-10-16 16:56 ` [PATCH 7/7] selftests/resctrl: Add the test in MAINTAINERS Fenghua Yu
2018-10-16 17:40 ` [PATCH 0/7] selftests/resctrl: Add resctrl selftest Moger, Babu
     [not found]   ` <FFF73D592F13FD46B8700F0A279B802F485D47DE@ORSMSX114.amr.corp.intel.com>
2018-10-16 20:32     ` Fenghua Yu
2018-10-17 14:40       ` Moger, Babu
2018-10-17 17:28         ` Prakhya, Sai Praneeth
2018-10-17 18:28           ` Moger, Babu [this message]
2018-10-17 18:31             ` Prakhya, Sai Praneeth
2018-10-17 18:03         ` Moger, Babu
2018-10-17 18:23           ` Moger, Babu
     [not found]           ` <CALBSrqBXdXfNdZ1yJ_-zUSkk_2m_8R-VHNqk8DH3HmxCti4hhA@mail.gmail.com>
2018-10-17 20:24             ` Fenghua Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=feb572ec-4495-c52c-0127-213417a67c3c@amd.com \
    --to=babu.moger@amd.com \
    --cc=arshiya.hayatkhan.pathan@intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=ravi.v.shankar@intel.com \
    --cc=reinette.chatre@intel.com \
    --cc=sai.praneeth.prakhya@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).