Re: [PATCH 0/7] selftests/resctrl: Add resctrl selftest

From: "Moger, Babu" <Babu.Moger@amd.com>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, H Peter Anvin <hpa@zytor.com>,
	Tony Luck <tony.luck@intel.com>,
	Reinette Chatre <reinette.chatre@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	James Morse <james.morse@arm.com>,
	Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
	Arshiya Hayatkhan Pathan <arshiya.hayatkhan.pathan@intel.com>,
	Ravi V Shankar <ravi.v.shankar@intel.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/7] selftests/resctrl: Add resctrl selftest
Date: Wed, 17 Oct 2018 14:40:40 +0000	[thread overview]
Message-ID: <bc44fb0c-1ce2-031d-f2b4-3941f1517bbf@amd.com> (raw)
In-Reply-To: <20181016203215.GA39177@romley-ivt3.sc.intel.com>

On 10/16/2018 03:32 PM, Fenghua Yu wrote:
>> From: Moger, Babu [mailto:Babu.Moger@amd.com] 
>> On 10/16/2018 11:56 AM, Fenghua Yu wrote:
>>> With more and more resctrl features are being added by Intel, AMD and 
>>> ARM, a test tool is becoming more and more useful to validate that 
>>> both hardware and software functionalities work as expected.
>>
>> I like the initiative here. It is always good to have a single code base.
>>
>> One question. I see that there is a tool at https://github.com/intel/intel-cmt-cat to test and verify the functionality of resctrl feature. I also see some of the distros have this tool already.
>> Is this tool going to replace intel-cmt-cat? I have not looked at the
>> patches closely yet.
> 
> No, the selftest in this patch set will not replace intel-cmt-cat or
> vice versa.
> 
> The selftest in this patch set has a different purpose from intel-cmt-cat:
> the selftest is a test tool which validates resctrl functionalities while
> intel-cmt-cat is mainly a utility that provides base library for higher
> level applications including performance analysis tools, benchmark measurement
> tools, and potential resctrl tests. For example, running MBA test in the
> selftests tells MBA working or not working (fail/pass) right way. The

Ok. Sure. Let me take a look at selftest closely. Will send my feedback soon.

> intel-cmt-cat doesn't have this testing capability unless we extend the
> tool.
> 
> And intel-cmt-cat is maintained and developed by Intel. I don't think it's
> easy to extend it to AMD and ARM features. The selftest will be maintained

We1l.. We were hoping to have a common tool across. It makes it easy for
distros. Probably, we can have a separate discussion on this.

> and developed by the community and will hopefully cover all architectures.
> 
> We have seen a few issues recently in resctrl and may see more issues
> while expending the features. A convevient selftest may be useful to help
> identify and fix those potential issues.
> 
> Thanks.
> 
> -Fenghua 
>  
> 