From: Steev Klimaszewski <steev@kali.org>
To: Sandeep Maheswaram <quic_c_sanm@quicinc.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Mathias Nyman <mathias.nyman@intel.com>
Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_pkondeti@quicinc.com,
quic_ppratap@quicinc.com
Subject: Re: [PATCH v10 6/6] usb: dwc3: qcom: Enable the interrupts during probe
Date: Tue, 18 Jan 2022 00:12:30 -0600 [thread overview]
Message-ID: <93b68251-7e7e-ac92-fb47-346c410744b2@kali.org> (raw)
In-Reply-To: <1642398248-21753-7-git-send-email-quic_c_sanm@quicinc.com>
On 1/16/22 11:44 PM, Sandeep Maheswaram wrote:
> Enable the interrupts during probe and remove the disable interrupts
> function.
>
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> ---
> drivers/usb/dwc3/dwc3-qcom.c | 28 ++++------------------------
> 1 file changed, 4 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> index 54dc3d3..7c5e636 100644
> --- a/drivers/usb/dwc3/dwc3-qcom.c
> +++ b/drivers/usb/dwc3/dwc3-qcom.c
> @@ -306,25 +306,7 @@ static void dwc3_qcom_enable_wakeup_irq(int irq)
> enable_irq_wake(irq);
> }
>
> -static void dwc3_qcom_disable_wakeup_irq(int irq)
> -{
> - if (!irq)
> - return;
> -
> - disable_irq_wake(irq);
> - disable_irq_nosync(irq);
> -}
>
> -static void dwc3_qcom_disable_interrupts(struct dwc3_qcom *qcom)
> -{
> - dwc3_qcom_disable_wakeup_irq(qcom->hs_phy_irq);
> -
> - dwc3_qcom_disable_wakeup_irq(qcom->dp_hs_phy_irq);
> -
> - dwc3_qcom_disable_wakeup_irq(qcom->dm_hs_phy_irq);
> -
> - dwc3_qcom_disable_wakeup_irq(qcom->ss_phy_irq);
> -}
>
> static void dwc3_qcom_enable_interrupts(struct dwc3_qcom *qcom)
> {
> @@ -356,9 +338,6 @@ static int dwc3_qcom_suspend(struct dwc3_qcom *qcom)
> if (ret)
> dev_warn(qcom->dev, "failed to disable interconnect: %d\n", ret);
>
> - if (device_may_wakeup(qcom->dev))
> - dwc3_qcom_enable_interrupts(qcom);
> -
> qcom->is_suspended = true;
>
> return 0;
> @@ -372,9 +351,6 @@ static int dwc3_qcom_resume(struct dwc3_qcom *qcom)
> if (!qcom->is_suspended)
> return 0;
>
> - if (device_may_wakeup(qcom->dev))
> - dwc3_qcom_disable_interrupts(qcom);
> -
> for (i = 0; i < qcom->num_clocks; i++) {
> ret = clk_prepare_enable(qcom->clks[i]);
> if (ret < 0) {
> @@ -832,6 +808,10 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
> genpd->flags |= GENPD_FLAG_ALWAYS_ON;
>
> device_init_wakeup(&pdev->dev, 1);
> +
> + if (device_may_wakeup(qcom->dev))
> + dwc3_qcom_enable_interrupts(qcom);
> +
> qcom->is_suspended = false;
> pm_runtime_set_active(dev);
> pm_runtime_enable(dev);
Hi Sandeep,
I was testing this series on my Lenovo Yoga C630, and with this patch in
particular applied, my system will no longer boot. Unfortunately I don't
get any sort of good output at all, I just get hung tasks when trying to
probe things it would seem.
With the other 5 patches in the series applied, the system still boots
and works correctly.
-- Steev
next prev parent reply other threads:[~2022-01-18 6:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 5:44 [PATCH v10 0/6] USB DWC3 host wake up support from system suspend Sandeep Maheswaram
2022-01-17 5:44 ` [PATCH v10 1/6] usb: host: xhci: plat: Add suspend quirk for dwc3 controller Sandeep Maheswaram
2022-01-26 12:47 ` Greg Kroah-Hartman
2022-01-17 5:44 ` [PATCH v10 2/6] usb: dwc3: core: Host wake up support from system suspend Sandeep Maheswaram
2022-01-18 8:57 ` Jun Li
2022-01-24 5:27 ` Sandeep Maheswaram
2022-01-17 5:44 ` [PATCH v10 3/6] usb: dwc3: qcom: Add helper functions to enable,disable wake irqs Sandeep Maheswaram
2022-01-17 5:44 ` [PATCH v10 4/6] usb: dwc3: qcom: Change the IRQ flag for DP/DM hs phy irq Sandeep Maheswaram
2022-01-17 5:44 ` [PATCH v10 5/6] usb: dwc3: qcom: Keep power domain on to retain controller status Sandeep Maheswaram
2022-01-17 5:44 ` [PATCH v10 6/6] usb: dwc3: qcom: Enable the interrupts during probe Sandeep Maheswaram
2022-01-18 6:12 ` Steev Klimaszewski [this message]
2022-01-18 6:30 ` Sandeep Maheswaram
2022-01-18 8:46 ` Steev Klimaszewski
2022-01-18 9:52 ` Pavan Kondeti
2022-01-20 5:22 ` Sandeep Maheswaram
2022-01-25 9:17 ` Sandeep Maheswaram
2022-01-28 8:36 ` Steev Klimaszewski
2022-01-28 9:00 ` Pavan Kondeti
2022-02-15 9:40 ` Sandeep Maheswaram
2022-02-16 3:22 ` Steev Klimaszewski
2022-02-16 6:27 ` Sandeep Maheswaram
2022-02-16 9:51 ` Steev Klimaszewski
[not found] ` <cad907b6-4434-45e7-bd70-b93c0035d90c@quicinc.com>
2022-02-17 22:16 ` Steev Klimaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93b68251-7e7e-ac92-fb47-346c410744b2@kali.org \
--to=steev@kali.org \
--cc=balbi@kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mka@chromium.org \
--cc=quic_c_sanm@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).