From: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
To: Steev Klimaszewski <steev@kali.org>,
Pavan Kondeti <quic_pkondeti@quicinc.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Mathias Nyman <mathias.nyman@intel.com>,
<linux-arm-msm@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <quic_ppratap@quicinc.com>
Subject: Re: [PATCH v10 6/6] usb: dwc3: qcom: Enable the interrupts during probe
Date: Wed, 16 Feb 2022 11:57:56 +0530 [thread overview]
Message-ID: <bb36a205-fbfe-536e-5bf6-4a717ffd4e6e@quicinc.com> (raw)
In-Reply-To: <47ae3e73-5880-bfb7-fc14-7dd95a75ce14@kali.org>
Hi Steev
On 2/16/2022 8:52 AM, Steev Klimaszewski wrote:
> Hi Sandeep,
>
> On 2/15/22 3:40 AM, Sandeep Maheswaram wrote:
>> Hi Steev,
>>
>>>>>
>>>> Can you try with IRQ_TYPE_EDGE_BOTH in your device tree and see if
>>>> you are getting the issue.
>>>>
>>>> Regards
>>>>
>>>> Sandeep
>>>>
>>> I just tested here, changing both of the IRQ_TYPE_LEVEL_HIGH in the
>>> yoga's dts to EDGE_BOTH and I still do not get a booting system.
>>>
>>> -- Steev
>>>
>> Please let us know what devices are connected to your setup and share
>> the device tree file you are using.
>>
>> Please share the failure logs also,
>>
>> Regards
>>
>> Sandeep
>>
> The setup is a Lenovo Yoga C630 (Windows on ARM laptop). I do not
> have any sort of serial console access to the device, unfortunately.
> Even when taking it apart, it seems to have some sort of 26pin debug
> adapter port that I've never seen before which you can see on the far
> right in this picture of the motherboard at
> https://i.ebayimg.com/images/g/a2EAAOSwwzZiCxPM/s-l1600.jpg
>
> I do not have anything plugged in to the USB ports (sometimes the
> power adapter, but I have tried both on mains as well as off.)
>
> I am using this diff
>
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> index eab3f00c603235..c54042b9e21df2 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> @@ -370,7 +370,7 @@
> reg = <0x15>;
> hid-descr-addr = <0x1>;
>
> - interrupts-extended = <&tlmm 37 IRQ_TYPE_LEVEL_HIGH>;
> + interrupts-extended = <&tlmm 37 IRQ_TYPE_EDGE_BOTH>;
> };
>
> tsc2: hid@2c {
> @@ -378,7 +378,7 @@
> reg = <0x2c>;
> hid-descr-addr = <0x20>;
>
> - interrupts-extended = <&tlmm 37 IRQ_TYPE_LEVEL_HIGH>;
> + interrupts-extended = <&tlmm 37 IRQ_TYPE_EDGE_BOTH>;
> };
> };
>
> Which I added as a commit to my kernel tree, and pushed so you can see
> the full dts here:
> https://github.com/steev/linux/blob/c8234e664491e35e3edcd211f3b78c04436402b0/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
>
> I am booting with the command line arguments of
>
> clk_ignore_unused verbose module_blacklist=msm video=efifb
> earlyconsole=efifb
>
> I can't provide a boot log, because I'm not actually getting
> anything. Booting a different kernel, and it doesn't appear that
> anything is logged at all.
>
>
> -- steev
>
Can you try with below change
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 0d6286d..0a9c0f7 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -3796,8 +3796,8 @@
interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 486 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 488 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 489 IRQ_TYPE_LEVEL_HIGH>;
+ <GIC_SPI 488 IRQ_TYPE_EDGE_BOTH>,
+ <GIC_SPI 489 IRQ_TYPE_EDGE_BOTH>;
interrupt-names = "hs_phy_irq", "ss_phy_irq",
"dm_hs_phy_irq", "dp_hs_phy_irq";
@@ -3844,8 +3844,8 @@
interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 487 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 490 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 491 IRQ_TYPE_LEVEL_HIGH>;
+ <GIC_SPI 490 IRQ_TYPE_EDGE_BOTH>,
+ <GIC_SPI 491 IRQ_TYPE_EDGE_BOTH>;
interrupt-names = "hs_phy_irq", "ss_phy_irq",
"dm_hs_phy_irq", "dp_hs_phy_irq";
Regards
Sandeep
next prev parent reply other threads:[~2022-02-16 6:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 5:44 [PATCH v10 0/6] USB DWC3 host wake up support from system suspend Sandeep Maheswaram
2022-01-17 5:44 ` [PATCH v10 1/6] usb: host: xhci: plat: Add suspend quirk for dwc3 controller Sandeep Maheswaram
2022-01-26 12:47 ` Greg Kroah-Hartman
2022-01-17 5:44 ` [PATCH v10 2/6] usb: dwc3: core: Host wake up support from system suspend Sandeep Maheswaram
2022-01-18 8:57 ` Jun Li
2022-01-24 5:27 ` Sandeep Maheswaram
2022-01-17 5:44 ` [PATCH v10 3/6] usb: dwc3: qcom: Add helper functions to enable,disable wake irqs Sandeep Maheswaram
2022-01-17 5:44 ` [PATCH v10 4/6] usb: dwc3: qcom: Change the IRQ flag for DP/DM hs phy irq Sandeep Maheswaram
2022-01-17 5:44 ` [PATCH v10 5/6] usb: dwc3: qcom: Keep power domain on to retain controller status Sandeep Maheswaram
2022-01-17 5:44 ` [PATCH v10 6/6] usb: dwc3: qcom: Enable the interrupts during probe Sandeep Maheswaram
2022-01-18 6:12 ` Steev Klimaszewski
2022-01-18 6:30 ` Sandeep Maheswaram
2022-01-18 8:46 ` Steev Klimaszewski
2022-01-18 9:52 ` Pavan Kondeti
2022-01-20 5:22 ` Sandeep Maheswaram
2022-01-25 9:17 ` Sandeep Maheswaram
2022-01-28 8:36 ` Steev Klimaszewski
2022-01-28 9:00 ` Pavan Kondeti
2022-02-15 9:40 ` Sandeep Maheswaram
2022-02-16 3:22 ` Steev Klimaszewski
2022-02-16 6:27 ` Sandeep Maheswaram [this message]
2022-02-16 9:51 ` Steev Klimaszewski
[not found] ` <cad907b6-4434-45e7-bd70-b93c0035d90c@quicinc.com>
2022-02-17 22:16 ` Steev Klimaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb36a205-fbfe-536e-5bf6-4a717ffd4e6e@quicinc.com \
--to=quic_c_sanm@quicinc.com \
--cc=balbi@kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mka@chromium.org \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=steev@kali.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).