From: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
To: Jun Li <lijun.kernel@gmail.com>, Li Jun <jun.li@nxp.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Mathias Nyman <mathias.nyman@intel.com>,
<linux-arm-msm@vger.kernel.org>,
Linux USB List <linux-usb@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>, <quic_pkondeti@quicinc.com>,
<quic_ppratap@quicinc.com>
Subject: Re: [PATCH v10 2/6] usb: dwc3: core: Host wake up support from system suspend
Date: Mon, 24 Jan 2022 10:57:59 +0530 [thread overview]
Message-ID: <eaca1146-666d-2b1f-637d-7a5f3e2ad989@quicinc.com> (raw)
In-Reply-To: <CAKgpwJUpMZTUKRbuWye8Qxjw6odqTS=ZLFLnPfunc=iA79ckew@mail.gmail.com>
On 1/18/2022 2:27 PM, Jun Li wrote:
> Sandeep Maheswaram <quic_c_sanm@quicinc.com> 于2022年1月17日周一 22:03写道:
>> Avoiding phy powerdown when wakeup capable devices are connected
>> by checking wakeup property of xhci plat device.
>> Phy should be on to wake up the device from suspend using wakeup capable
>> devices such as keyboard and mouse.
>>
>> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
>> Tested-by: Brian Norris <briannorris@chromium.org>
>> ---
>> Remove redundant else part in dwc3_resume_common. This will not be
>> required if GDSC is always on during suspend/resume.
>>
>>
>> drivers/usb/dwc3/core.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
>> index f4c0995..e7a5e3f 100644
>> --- a/drivers/usb/dwc3/core.c
>> +++ b/drivers/usb/dwc3/core.c
>> @@ -1789,7 +1789,7 @@ static int dwc3_suspend_common(struct dwc3 *dwc, pm_message_t msg)
>> dwc3_core_exit(dwc);
>> break;
>> case DWC3_GCTL_PRTCAP_HOST:
>> - if (!PMSG_IS_AUTO(msg)) {
>> + if (!PMSG_IS_AUTO(msg) && !device_may_wakeup(&dwc->xhci->dev)) {
>> dwc3_core_exit(dwc);
>> break;
>> }
>> @@ -1850,7 +1850,7 @@ static int dwc3_resume_common(struct dwc3 *dwc, pm_message_t msg)
>> spin_unlock_irqrestore(&dwc->lock, flags);
>> break;
>> case DWC3_GCTL_PRTCAP_HOST:
>> - if (!PMSG_IS_AUTO(msg)) {
>> + if (!PMSG_IS_AUTO(msg) && !device_may_wakeup(&dwc->xhci->dev)) {
> If XHCI_SKIP_PHY_INIT is not set, I see the usb core will help to
> handle phy power on/off and init/exit via drivers/usb/core/phy.c, so
> if the wakeup is enabled for controller, then finally the phy will not
> be power off/exit. I am wondering if this change is actually required if
> that is the case.
>
> Sorry for the late comment.
>
> Li Jun
>
The patch is to avoid phy power off in case only if some wakeup capable
devices are connected.
Regarding XHCI_SKIP_PHY_INIT we are setting in this patch
https://patchwork.kernel.org/project/linux-arm-msm/patch/1640153383-21036-1-git-send-email-quic_c_sanm@quicinc.com/
>
>> ret = dwc3_core_init_for_resume(dwc);
>> if (ret)
>> return ret;
>> --
>> 2.7.4
>>
next prev parent reply other threads:[~2022-01-24 5:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 5:44 [PATCH v10 0/6] USB DWC3 host wake up support from system suspend Sandeep Maheswaram
2022-01-17 5:44 ` [PATCH v10 1/6] usb: host: xhci: plat: Add suspend quirk for dwc3 controller Sandeep Maheswaram
2022-01-26 12:47 ` Greg Kroah-Hartman
2022-01-17 5:44 ` [PATCH v10 2/6] usb: dwc3: core: Host wake up support from system suspend Sandeep Maheswaram
2022-01-18 8:57 ` Jun Li
2022-01-24 5:27 ` Sandeep Maheswaram [this message]
2022-01-17 5:44 ` [PATCH v10 3/6] usb: dwc3: qcom: Add helper functions to enable,disable wake irqs Sandeep Maheswaram
2022-01-17 5:44 ` [PATCH v10 4/6] usb: dwc3: qcom: Change the IRQ flag for DP/DM hs phy irq Sandeep Maheswaram
2022-01-17 5:44 ` [PATCH v10 5/6] usb: dwc3: qcom: Keep power domain on to retain controller status Sandeep Maheswaram
2022-01-17 5:44 ` [PATCH v10 6/6] usb: dwc3: qcom: Enable the interrupts during probe Sandeep Maheswaram
2022-01-18 6:12 ` Steev Klimaszewski
2022-01-18 6:30 ` Sandeep Maheswaram
2022-01-18 8:46 ` Steev Klimaszewski
2022-01-18 9:52 ` Pavan Kondeti
2022-01-20 5:22 ` Sandeep Maheswaram
2022-01-25 9:17 ` Sandeep Maheswaram
2022-01-28 8:36 ` Steev Klimaszewski
2022-01-28 9:00 ` Pavan Kondeti
2022-02-15 9:40 ` Sandeep Maheswaram
2022-02-16 3:22 ` Steev Klimaszewski
2022-02-16 6:27 ` Sandeep Maheswaram
2022-02-16 9:51 ` Steev Klimaszewski
[not found] ` <cad907b6-4434-45e7-bd70-b93c0035d90c@quicinc.com>
2022-02-17 22:16 ` Steev Klimaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaca1146-666d-2b1f-637d-7a5f3e2ad989@quicinc.com \
--to=quic_c_sanm@quicinc.com \
--cc=balbi@kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jun.li@nxp.com \
--cc=lijun.kernel@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mka@chromium.org \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).