From: Suzuki K Poulose <Suzuki.Poulose@arm.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>, acme@kernel.org
Cc: acme@infradead.org, peterz@infradead.org, jolsa@kernel.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V7 5/5] perf tools: adding sink configuration for cs_etm PMU
Date: Wed, 31 Aug 2016 10:37:43 +0100 [thread overview]
Message-ID: <94a6e940-cce8-a179-fe0c-c69a543e302c@arm.com> (raw)
In-Reply-To: <1472573965-3881-6-git-send-email-mathieu.poirier@linaro.org>
On 30/08/16 17:19, Mathieu Poirier wrote:
> Using the PMU::set_drv_config() callback to enable the CoreSight
> sink that will be used for the trace session.
> +int cs_etm_set_drv_config(struct perf_evsel_config_term *term)
> +{
> + int ret;
> + char enable_sink[ENABLE_SINK_MAX];
> +
> + snprintf(enable_sink, ENABLE_SINK_MAX, "%s/%s",
> + term->val.drv_cfg, "enable_sink");
> +
> + ret = cs_device__print_file(enable_sink, "%d", 1);
> + if (ret < 0)
> + return ret;
> +
> + return 0;
> +}
Don't we have to disable the sink at the end of the session ? How is that
taken care of ? Did I miss that ?
Suzuki
next prev parent reply other threads:[~2016-08-31 9:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 16:19 [PATCH V7 0/5] perf: Driver specific configuration for PMU Mathieu Poirier
2016-08-30 16:19 ` [PATCH V7 1/5] perf tools: making coresight PMU listable Mathieu Poirier
2016-08-30 16:19 ` [PATCH V7 2/5] perf tools: adding coresight etm PMU record capabilities Mathieu Poirier
2016-08-30 16:19 ` [PATCH V7 3/5] perf tools: add infrastructure for PMU specific configuration Mathieu Poirier
2016-08-30 16:19 ` [PATCH V7 4/5] perf tools: Pushing configuration down to PMU driver Mathieu Poirier
2016-08-30 16:19 ` [PATCH V7 5/5] perf tools: adding sink configuration for cs_etm PMU Mathieu Poirier
2016-08-31 9:37 ` Suzuki K Poulose [this message]
2016-08-31 14:14 ` Mathieu Poirier
2016-09-01 9:04 ` Suzuki K Poulose
2016-09-01 15:13 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a6e940-cce8-a179-fe0c-c69a543e302c@arm.com \
--to=suzuki.poulose@arm.com \
--cc=acme@infradead.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).