[PATCH] Fixes hang in zstd compression test by changing the source of random data.

linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] Fixes hang in zstd compression test by changing the source of random data.
@ 2019-08-22 13:55 James Clark
  2019-08-22 21:24 ` Arnaldo Carvalho de Melo
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: James Clark @ 2019-08-22 13:55 UTC (permalink / raw)
  To: peterz, mingo, acme, alexander.shishkin, jolsa, namhyung,
	alexey.budankov
  Cc: linux-perf-users, nd, linux-kernel, Jeremy Linton

Running 'perf test' with zstd compression linked will hang at the test
'Zstd perf.data compression/decompression' because /dev/random blocks
reads until there is enough entropy. This means that the test will
appear to never complete unless the mouse is continually moved while
running it.

Signed-off-by: James Clark <james.clark@arm.com>
---
 tools/perf/tests/shell/record+zstd_comp_decomp.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/shell/record+zstd_comp_decomp.sh b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
index 899604d1..63a91ec 100755
--- a/tools/perf/tests/shell/record+zstd_comp_decomp.sh
+++ b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
@@ -13,7 +13,7 @@ skip_if_no_z_record() {
 collect_z_record() {
 	echo "Collecting compressed record file:"
 	$perf_tool record -o $trace_file -g -z -F 5000 -- \
-		dd count=500 if=/dev/random of=/dev/null
+		dd count=500 if=/dev/urandom of=/dev/null
 }
 
 check_compressed_stats() {
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] Fixes hang in zstd compression test by changing the source of random data.
  2019-08-22 13:55 [PATCH] Fixes hang in zstd compression test by changing the source of random data James Clark
@ 2019-08-22 21:24 ` Arnaldo Carvalho de Melo
  2019-08-22 21:24   ` Arnaldo Carvalho de Melo
  2019-08-23  6:00 ` Alexey Budankov
  2019-08-27  8:26 ` [tip: perf/core] perf tests: " tip-bot2 for James Clark
  2 siblings, 1 reply; 6+ messages in thread
From: Arnaldo Carvalho de Melo @ 2019-08-22 21:24 UTC (permalink / raw)
  To: James Clark
  Cc: peterz, mingo, alexander.shishkin, jolsa, namhyung,
	alexey.budankov, linux-perf-users, nd, linux-kernel,
	Jeremy Linton

Em Thu, Aug 22, 2019 at 01:55:15PM +0000, James Clark escreveu:
> Running 'perf test' with zstd compression linked will hang at the test
> 'Zstd perf.data compression/decompression' because /dev/random blocks
> reads until there is enough entropy. This means that the test will
> appear to never complete unless the mouse is continually moved while
> running it.

message came mangled, had to do it by hand and then hook up your header
so as to get the correct date, attribution, etc, please check
Documentation/process/email-clients.rst,

- Arnaldo
 
> Signed-off-by: James Clark <james.clark@arm.com>
> ---
>  tools/perf/tests/shell/record+zstd_comp_decomp.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/shell/record+zstd_comp_decomp.sh b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> index 899604d1..63a91ec 100755
> --- a/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> +++ b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> @@ -13,7 +13,7 @@ skip_if_no_z_record() {
>  collect_z_record() {
>  	echo "Collecting compressed record file:"
>  	$perf_tool record -o $trace_file -g -z -F 5000 -- \
> -		dd count=500 if=/dev/random of=/dev/null
> +		dd count=500 if=/dev/urandom of=/dev/null
>  }
>  
>  check_compressed_stats() {
> -- 
> 2.7.4
> 

-- 

- Arnaldo

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Fixes hang in zstd compression test by changing the source of random data.
  2019-08-22 21:24 ` Arnaldo Carvalho de Melo
@ 2019-08-22 21:24   ` Arnaldo Carvalho de Melo
  2019-08-23  8:30     ` James Clark
  0 siblings, 1 reply; 6+ messages in thread
From: Arnaldo Carvalho de Melo @ 2019-08-22 21:24 UTC (permalink / raw)
  To: James Clark
  Cc: peterz, mingo, alexander.shishkin, jolsa, namhyung,
	alexey.budankov, linux-perf-users, nd, linux-kernel,
	Jeremy Linton

Em Thu, Aug 22, 2019 at 06:24:07PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Aug 22, 2019 at 01:55:15PM +0000, James Clark escreveu:
> > Running 'perf test' with zstd compression linked will hang at the test
> > 'Zstd perf.data compression/decompression' because /dev/random blocks
> > reads until there is enough entropy. This means that the test will
> > appear to never complete unless the mouse is continually moved while
> > running it.
> 
> message came mangled, had to do it by hand and then hook up your header
> so as to get the correct date, attribution, etc, please check
> Documentation/process/email-clients.rst,

Having said that, thanks, applied.

- Arnaldo

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Fixes hang in zstd compression test by changing the source of random data.
  2019-08-22 21:24   ` Arnaldo Carvalho de Melo
@ 2019-08-23  8:30     ` James Clark
  0 siblings, 0 replies; 6+ messages in thread
From: James Clark @ 2019-08-23  8:30 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo
  Cc: peterz, mingo, alexander.shishkin, jolsa, namhyung,
	alexey.budankov, linux-perf-users, nd, linux-kernel,
	Jeremy Linton

Sorry about that, I will look into it.

Thanks
James

On 22/08/2019 22:24, Arnaldo Carvalho de Melo wrote:
> Em Thu, Aug 22, 2019 at 06:24:07PM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Thu, Aug 22, 2019 at 01:55:15PM +0000, James Clark escreveu:
>>> Running 'perf test' with zstd compression linked will hang at the test
>>> 'Zstd perf.data compression/decompression' because /dev/random blocks
>>> reads until there is enough entropy. This means that the test will
>>> appear to never complete unless the mouse is continually moved while
>>> running it.
>>
>> message came mangled, had to do it by hand and then hook up your header
>> so as to get the correct date, attribution, etc, please check
>> Documentation/process/email-clients.rst,
> 
> Having said that, thanks, applied.
> 
> - Arnaldo
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Fixes hang in zstd compression test by changing the source of random data.
  2019-08-22 13:55 [PATCH] Fixes hang in zstd compression test by changing the source of random data James Clark
  2019-08-22 21:24 ` Arnaldo Carvalho de Melo
@ 2019-08-23  6:00 ` Alexey Budankov
  2019-08-27  8:26 ` [tip: perf/core] perf tests: " tip-bot2 for James Clark
  2 siblings, 0 replies; 6+ messages in thread
From: Alexey Budankov @ 2019-08-23  6:00 UTC (permalink / raw)
  To: James Clark, peterz, mingo, acme, alexander.shishkin, jolsa, namhyung
  Cc: linux-perf-users, nd, linux-kernel, Jeremy Linton

On 22.08.2019 16:55, James Clark wrote:
> Running 'perf test' with zstd compression linked will hang at the test
> 'Zstd perf.data compression/decompression' because /dev/random blocks
> reads until there is enough entropy. This means that the test will
> appear to never complete unless the mouse is continually moved while
> running it.
> 
> Signed-off-by: James Clark <james.clark@arm.com>
> ---
>  tools/perf/tests/shell/record+zstd_comp_decomp.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/shell/record+zstd_comp_decomp.sh b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> index 899604d1..63a91ec 100755
> --- a/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> +++ b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> @@ -13,7 +13,7 @@ skip_if_no_z_record() {
>  collect_z_record() {
>  	echo "Collecting compressed record file:"
>  	$perf_tool record -o $trace_file -g -z -F 5000 -- \
> -		dd count=500 if=/dev/random of=/dev/null
> +		dd count=500 if=/dev/urandom of=/dev/null

Acked-by: Alexey Budankov <alexey.budankov@linux.intel.com>

~Alexey

>  }
>  
>  check_compressed_stats() {
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [tip: perf/core] perf tests: Fixes hang in zstd compression test by changing the source of random data
  2019-08-22 13:55 [PATCH] Fixes hang in zstd compression test by changing the source of random data James Clark
  2019-08-22 21:24 ` Arnaldo Carvalho de Melo
  2019-08-23  6:00 ` Alexey Budankov
@ 2019-08-27  8:26 ` tip-bot2 for James Clark
  2 siblings, 0 replies; 6+ messages in thread
From: tip-bot2 for James Clark @ 2019-08-27  8:26 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: James Clark, Alexander Shishkin, Alexey Budankov, Jeremy Linton,
	Jiri Olsa, Namhyung Kim, Peter Zijlstra,
	Arnaldo Carvalho de Melo, Ingo Molnar, Borislav Petkov,
	linux-kernel

The following commit has been merged into the perf/core branch of tip:

Commit-ID:     d93fc7ac88c7347d1c31ca158d1466d1ce2097e1
Gitweb:        https://git.kernel.org/tip/d93fc7ac88c7347d1c31ca158d1466d1ce2097e1
Author:        James Clark <James.Clark@arm.com>
AuthorDate:    Thu, 22 Aug 2019 13:55:15 
Committer:     Arnaldo Carvalho de Melo <acme@redhat.com>
CommitterDate: Mon, 26 Aug 2019 11:58:29 -03:00

perf tests: Fixes hang in zstd compression test by changing the source of random data

Running 'perf test' with zstd compression linked will hang at the test
'Zstd perf.data compression/decompression' because /dev/random blocks
reads until there is enough entropy. This means that the test will
appear to never complete unless the mouse is continually moved while
running it.

Signed-off-by: James Clark <james.clark@arm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Jeremy Linton <jeremy.linton@arm.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/3d8cc701-df4e-f949-1715-5118b530e990@arm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/tests/shell/record+zstd_comp_decomp.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/shell/record+zstd_comp_decomp.sh b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
index 899604d..63a91ec 100755
--- a/tools/perf/tests/shell/record+zstd_comp_decomp.sh
+++ b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
@@ -13,7 +13,7 @@ skip_if_no_z_record() {
 collect_z_record() {
 	echo "Collecting compressed record file:"
 	$perf_tool record -o $trace_file -g -z -F 5000 -- \
-		dd count=500 if=/dev/random of=/dev/null
+		dd count=500 if=/dev/urandom of=/dev/null
 }
 
 check_compressed_stats() {

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-08-27  8:28 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-22 13:55 [PATCH] Fixes hang in zstd compression test by changing the source of random data James Clark
2019-08-22 21:24 ` Arnaldo Carvalho de Melo
2019-08-22 21:24   ` Arnaldo Carvalho de Melo
2019-08-23  8:30     ` James Clark
2019-08-23  6:00 ` Alexey Budankov
2019-08-27  8:26 ` [tip: perf/core] perf tests: " tip-bot2 for James Clark

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).