From: "Xu, Even" <even.xu@intel.com>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Jiri Kosina <jikos@kernel.org>
Cc: "benjamin.tissoires@redhat.com" <benjamin.tissoires@redhat.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] hid: intel_ish-hid: ipc: register more pm callbacks to support hibernation
Date: Wed, 13 Jun 2018 00:05:55 +0000 [thread overview]
Message-ID: <9577C59DB499174B9340876B077C2E9569DF11EC@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <634cd945beca786dc77876f71e39459cef6fbd75.camel@linux.intel.com>
Ok, sure, I will update patch comments and resubmit.
Thanks Srinivas!
Best Regards,
Even Xu
-----Original Message-----
From: Srinivas Pandruvada [mailto:srinivas.pandruvada@linux.intel.com]
Sent: Tuesday, June 12, 2018 11:31 PM
To: Jiri Kosina <jikos@kernel.org>; Xu, Even <even.xu@intel.com>
Cc: benjamin.tissoires@redhat.com; linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; Xu, Even <even.xu@intel.com>
Subject: Re: [PATCH] hid: intel_ish-hid: ipc: register more pm callbacks to support hibernation
On Tue, 2018-06-12 at 16:53 +0200, Jiri Kosina wrote:
> On Sun, 10 Jun 2018, Srinivas Pandruvada wrote:
>
> > From: Even Xu <even.xu@intel.com>
> >
> > Current ish driver only register resume/suspend PM callbacks which
> > don't support hibernation (suspend to disk). Now use the
> > SIMPLE_DEV_PM_OPS() MACRO instead of struct dev_pm_ops directly.
> > The suspend and resume functions will now be used for both suspend
> > to RAM and hibernation.
> >
> > If power management is disable, SIMPLE_DEV_PM_OPS will do nothing,
> > the suspend and resume related functions won't be used, so mark them
> > as __maybe_unused to clarify that this is intended behavior, and
> > remove #ifdefs for power management.
>
> This describes details the patch does on code level, but what are the
> user observable effects? Hibernation resume doesn't fail any more?
> Hibernation
> is possible (and wasn't before)? Did kernel crash while trying to
> hibernate and this is the fix? Or ... ?
Even,
Can you add more details and resubmit ASAP?
Basically after hiberation, the ISH can't resume properly and user may not see sensor events (for example: screen rotation may not work).
User will not see a crash or panic or anything except the following message in log:
hid-sensor-hub 001F:8086:22D8.0001: timeout waiting for response from ISHTP device
So this is adding support for S4/hiberbation to ISH.
Thanks,
Srinivas
>
> Thanks,
>
next prev parent reply other threads:[~2018-06-13 0:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 1:56 [PATCH] hid: intel_ish-hid: ipc: register more pm callbacks to support hibernation Srinivas Pandruvada
2018-06-12 14:53 ` Jiri Kosina
2018-06-12 15:30 ` Srinivas Pandruvada
2018-06-13 0:05 ` Xu, Even [this message]
2018-06-13 0:14 ` Srinivas Pandruvada
2018-06-13 0:04 ` Xu, Even
-- strict thread matches above, loose matches on Subject: below --
2016-02-11 20:11 Even Xu
2018-06-13 11:34 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9577C59DB499174B9340876B077C2E9569DF11EC@SHSMSX101.ccr.corp.intel.com \
--to=even.xu@intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).