From: Jiri Kosina <jikos@kernel.org>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, Even Xu <even.xu@intel.com>
Subject: Re: [PATCH] hid: intel_ish-hid: ipc: register more pm callbacks to support hibernation
Date: Tue, 12 Jun 2018 16:53:12 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.1806121651460.6203@cbobk.fhfr.pm> (raw)
In-Reply-To: <20180611015650.51385-1-srinivas.pandruvada@linux.intel.com>
On Sun, 10 Jun 2018, Srinivas Pandruvada wrote:
> From: Even Xu <even.xu@intel.com>
>
> Current ish driver only register resume/suspend PM callbacks which
> don't support hibernation (suspend to disk). Now use the
> SIMPLE_DEV_PM_OPS() MACRO instead of struct dev_pm_ops directly.
> The suspend and resume functions will now be used for both suspend
> to RAM and hibernation.
>
> If power management is disable, SIMPLE_DEV_PM_OPS will do nothing,
> the suspend and resume related functions won't be used, so mark them
> as __maybe_unused to clarify that this is intended behavior, and
> remove #ifdefs for power management.
This describes details the patch does on code level, but what are the user
observable effects? Hibernation resume doesn't fail any more? Hibernation
is possible (and wasn't before)? Did kernel crash while trying to
hibernate and this is the fix? Or ... ?
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2018-06-12 14:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 1:56 [PATCH] hid: intel_ish-hid: ipc: register more pm callbacks to support hibernation Srinivas Pandruvada
2018-06-12 14:53 ` Jiri Kosina [this message]
2018-06-12 15:30 ` Srinivas Pandruvada
2018-06-13 0:05 ` Xu, Even
2018-06-13 0:14 ` Srinivas Pandruvada
2018-06-13 0:04 ` Xu, Even
-- strict thread matches above, loose matches on Subject: below --
2016-02-11 20:11 Even Xu
2018-06-13 11:34 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.1806121651460.6203@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=even.xu@intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).