From: Jiri Kosina <jikos@kernel.org>
To: Even Xu <even.xu@intel.com>
Cc: srinivas.pandruvada@linux.intel.com,
benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] hid: intel_ish-hid: ipc: register more pm callbacks to support hibernation
Date: Wed, 13 Jun 2018 13:34:12 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.1806131333500.6203@cbobk.fhfr.pm> (raw)
In-Reply-To: <1455221494-2915-1-git-send-email-even.xu@intel.com>
On Fri, 12 Feb 2016, Even Xu wrote:
> Current ISH driver only registers suspend/resume PM callbacks which don't
> support hibernation (suspend to disk). Basically after hiberation, the ISH
> can't resume properly and user may not see sensor events
> (for example: screen rotation may not work).
>
> User will not see a crash or panic or anything except the following message
> in log:
> hid-sensor-hub 001F:8086:22D8.0001: timeout waiting for response from ISHTP device
>
> So this patch adds support for S4/hiberbation to ISH by using the
> SIMPLE_DEV_PM_OPS() MACRO instead of struct dev_pm_ops directly. The suspend
> and resume functions will now be used for both suspend to RAM and hibernation.
>
> If power management is disabled, SIMPLE_DEV_PM_OPS will do nothing, the suspend
> and resume related functions won't be used, so mark them as __maybe_unused to
> clarify that this is the intended behavior, and remove #ifdefs for power
> management.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Even Xu <even.xu@intel.com>
> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Applied to hid.git#for-4.18/upstream-fixes. Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2018-06-13 11:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 20:11 [PATCH] hid: intel_ish-hid: ipc: register more pm callbacks to support hibernation Even Xu
2018-06-13 11:34 ` Jiri Kosina [this message]
2018-06-11 1:56 Srinivas Pandruvada
2018-06-12 14:53 ` Jiri Kosina
2018-06-12 15:30 ` Srinivas Pandruvada
2018-06-13 0:05 ` Xu, Even
2018-06-13 0:14 ` Srinivas Pandruvada
2018-06-13 0:04 ` Xu, Even
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.1806131333500.6203@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=even.xu@intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).