* [PATCH] drm: bridge/dw-hdmi: Fix colorspace and scan information registers values
@ 2016-08-18 14:34 Jose Abreu
2016-08-18 14:46 ` Russell King - ARM Linux
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jose Abreu @ 2016-08-18 14:34 UTC (permalink / raw)
To: dri-devel
Cc: Jose Abreu, Carlos Palminha, David Airlie, Russell King,
Daniel Vetter, linux-kernel
Colorspace and scan information values were being written in wrong
offsets. This patch corrects this and writes the values at the
offsets specified in the databook.
Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Cc: Carlos Palminha <palminha@synopsys.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
---
drivers/gpu/drm/bridge/dw-hdmi.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c
index 77ab473..cdf39aa 100644
--- a/drivers/gpu/drm/bridge/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/dw-hdmi.c
@@ -940,10 +940,11 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
*/
/*
- * AVI data byte 1 differences: Colorspace in bits 4,5 rather than 5,6,
- * active aspect present in bit 6 rather than 4.
+ * AVI data byte 1 differences: Colorspace in bits 0,1 rather than 5,6,
+ * scan info in bits 4,5 rather than 0,1 and active aspect present in
+ * bit 6 rather than 4.
*/
- val = (frame.colorspace & 3) << 4 | (frame.scan_mode & 0x3);
+ val = (frame.scan_mode & 3) << 4 | (frame.colorspace & 3);
if (frame.active_aspect & 15)
val |= HDMI_FC_AVICONF0_ACTIVE_FMT_INFO_PRESENT;
if (frame.top_bar || frame.bottom_bar)
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: bridge/dw-hdmi: Fix colorspace and scan information registers values
2016-08-18 14:34 [PATCH] drm: bridge/dw-hdmi: Fix colorspace and scan information registers values Jose Abreu
@ 2016-08-18 14:46 ` Russell King - ARM Linux
2016-08-29 9:21 ` [PATCH RESEND] " Russell King - ARM Linux
2016-08-31 4:08 ` Archit Taneja
2 siblings, 0 replies; 5+ messages in thread
From: Russell King - ARM Linux @ 2016-08-18 14:46 UTC (permalink / raw)
To: Jose Abreu
Cc: dri-devel, Carlos Palminha, David Airlie, Daniel Vetter, linux-kernel
On Thu, Aug 18, 2016 at 03:34:12PM +0100, Jose Abreu wrote:
> Colorspace and scan information values were being written in wrong
> offsets. This patch corrects this and writes the values at the
> offsets specified in the databook.
>
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> Cc: Carlos Palminha <palminha@synopsys.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-kernel@vger.kernel.org
Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
Thanks.
> ---
> drivers/gpu/drm/bridge/dw-hdmi.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c
> index 77ab473..cdf39aa 100644
> --- a/drivers/gpu/drm/bridge/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/dw-hdmi.c
> @@ -940,10 +940,11 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
> */
>
> /*
> - * AVI data byte 1 differences: Colorspace in bits 4,5 rather than 5,6,
> - * active aspect present in bit 6 rather than 4.
> + * AVI data byte 1 differences: Colorspace in bits 0,1 rather than 5,6,
> + * scan info in bits 4,5 rather than 0,1 and active aspect present in
> + * bit 6 rather than 4.
> */
> - val = (frame.colorspace & 3) << 4 | (frame.scan_mode & 0x3);
> + val = (frame.scan_mode & 3) << 4 | (frame.colorspace & 3);
> if (frame.active_aspect & 15)
> val |= HDMI_FC_AVICONF0_ACTIVE_FMT_INFO_PRESENT;
> if (frame.top_bar || frame.bottom_bar)
> --
> 2.1.4
>
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] drm: bridge/dw-hdmi: Fix colorspace and scan information registers values
2016-08-18 14:34 [PATCH] drm: bridge/dw-hdmi: Fix colorspace and scan information registers values Jose Abreu
2016-08-18 14:46 ` Russell King - ARM Linux
@ 2016-08-29 9:21 ` Russell King - ARM Linux
2016-08-29 9:26 ` Jose Abreu
2016-08-31 4:08 ` Archit Taneja
2 siblings, 1 reply; 5+ messages in thread
From: Russell King - ARM Linux @ 2016-08-29 9:21 UTC (permalink / raw)
To: Jose Abreu
Cc: dri-devel, Carlos Palminha, Archit Taneja, David Airlie,
Daniel Vetter, linux-kernel
On Mon, Aug 29, 2016 at 10:17:04AM +0100, Jose Abreu wrote:
> Colorspace and scan information values were being written in wrong
> offsets. This patch corrects this and writes the values at the
> offsets specified in the databook.
>
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> Acked-by: Russel King <rmk+kernel@armlinux.org.uk>
That's "Russell King" please.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] drm: bridge/dw-hdmi: Fix colorspace and scan information registers values
2016-08-29 9:21 ` [PATCH RESEND] " Russell King - ARM Linux
@ 2016-08-29 9:26 ` Jose Abreu
0 siblings, 0 replies; 5+ messages in thread
From: Jose Abreu @ 2016-08-29 9:26 UTC (permalink / raw)
To: Russell King - ARM Linux, Jose Abreu
Cc: dri-devel, Carlos Palminha, Archit Taneja, David Airlie,
Daniel Vetter, linux-kernel
On 29-08-2016 10:21, Russell King - ARM Linux wrote:
> On Mon, Aug 29, 2016 at 10:17:04AM +0100, Jose Abreu wrote:
>> Colorspace and scan information values were being written in wrong
>> offsets. This patch corrects this and writes the values at the
>> offsets specified in the databook.
>>
>> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
>> Acked-by: Russel King <rmk+kernel@armlinux.org.uk>
> That's "Russell King" please.
>
Sorry. Will send again.
Best regards,
Jose Miguel Abreu
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] drm: bridge/dw-hdmi: Fix colorspace and scan information registers values
2016-08-18 14:34 [PATCH] drm: bridge/dw-hdmi: Fix colorspace and scan information registers values Jose Abreu
2016-08-18 14:46 ` Russell King - ARM Linux
2016-08-29 9:21 ` [PATCH RESEND] " Russell King - ARM Linux
@ 2016-08-31 4:08 ` Archit Taneja
2 siblings, 0 replies; 5+ messages in thread
From: Archit Taneja @ 2016-08-31 4:08 UTC (permalink / raw)
To: Jose Abreu, dri-devel
Cc: Carlos Palminha, David Airlie, Russell King, Daniel Vetter, linux-kernel
Hi,
On 08/29/2016 03:00 PM, Jose Abreu wrote:
> Colorspace and scan information values were being written in wrong
> offsets. This patch corrects this and writes the values at the
> offsets specified in the databook.
queued to drm-misc after cleaning up some checkpatch
errors.
Thanks,
Archit
>
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
> Cc: Carlos Palminha <palminha@synopsys.com>
> Cc: Archit Taneja <architt@codeaurora.org>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/gpu/drm/bridge/dw-hdmi.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c
> index 77ab473..cdf39aa 100644
> --- a/drivers/gpu/drm/bridge/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/dw-hdmi.c
> @@ -940,10 +940,11 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
> */
>
> /*
> - * AVI data byte 1 differences: Colorspace in bits 4,5 rather than 5,6,
> - * active aspect present in bit 6 rather than 4.
> + * AVI data byte 1 differences: Colorspace in bits 0,1 rather than 5,6,
> + * scan info in bits 4,5 rather than 0,1 and active aspect present in
> + * bit 6 rather than 4.
> */
> - val = (frame.colorspace & 3) << 4 | (frame.scan_mode & 0x3);
> + val = (frame.scan_mode & 3) << 4 | (frame.colorspace & 3);
> if (frame.active_aspect & 15)
> val |= HDMI_FC_AVICONF0_ACTIVE_FMT_INFO_PRESENT;
> if (frame.top_bar || frame.bottom_bar)
>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-08-31 4:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-18 14:34 [PATCH] drm: bridge/dw-hdmi: Fix colorspace and scan information registers values Jose Abreu
2016-08-18 14:46 ` Russell King - ARM Linux
2016-08-29 9:21 ` [PATCH RESEND] " Russell King - ARM Linux
2016-08-29 9:26 ` Jose Abreu
2016-08-31 4:08 ` Archit Taneja
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).