From: "Alessandrelli, Daniele" <daniele.alessandrelli@intel.com>
To: "robh@kernel.org" <robh@kernel.org>,
"mgross@linux.intel.com" <mgross@linux.intel.com>
Cc: "corbet@lwn.net" <corbet@lwn.net>,
"palmerdabbelt@google.com" <palmerdabbelt@google.com>,
"peng.fan@nxp.com" <peng.fan@nxp.com>,
"damien.lemoal@wdc.com" <damien.lemoal@wdc.com>,
"bp@suse.de" <bp@suse.de>,
"leonard.crestez@nxp.com" <leonard.crestez@nxp.com>,
"markgross@kernel.org" <markgross@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Murphy, Paul J" <paul.j.murphy@intel.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"jassisinghbrar@gmail.com" <jassisinghbrar@gmail.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"dragan.cvetic@xilinx.com" <dragan.cvetic@xilinx.com>
Subject: Re: [PATCH v2 06/34] dt-bindings: Add bindings for Keem Bay VPU IPC driver
Date: Tue, 19 Jan 2021 14:32:45 +0000 [thread overview]
Message-ID: <9996e4a93e79ffc70e1c401c2ce3ec526060f48c.camel@intel.com> (raw)
In-Reply-To: <20210111192410.GA2906041@robh.at.kernel.org>
Hi Rob,
Thanks for your review.
On Mon, 2021-01-11 at 13:24 -0600, Rob Herring wrote:
> On Fri, Jan 08, 2021 at 01:25:32PM -0800, mgross@linux.intel.com
> wrote:
> > From: Paul Murphy <paul.j.murphy@intel.com>
> >
> > Add DT bindings documentation for the Keem Bay VPU IPC driver.
> >
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: devicetree@vger.kernel.org
> > Reviewed-by: Mark Gross <mgross@linux.intel.com>
> > Signed-off-by: Paul Murphy <paul.j.murphy@intel.com>
> > Co-developed-by: Daniele Alessandrelli <
> > daniele.alessandrelli@intel.com>
> > Signed-off-by: Daniele Alessandrelli <
> > daniele.alessandrelli@intel.com>
>
> Needs your Sob.
>
> > ---
> > .../soc/intel/intel,keembay-vpu-ipc.yaml | 153
> > ++++++++++++++++++
>
> This doesn't fit somewhere else?
It's quite a SoC-specific driver, designed to control (start, stop,
monitor, etc) the Vision Processing Unit (VPU) integrated in the Keem
Bay SoC.
Do you think it would fit better somewhere else?
>
> > 1 file changed, 153 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/soc/intel/intel,keembay-vpu-
> > ipc.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/soc/intel/intel,keembay-vpu-
> > ipc.yaml
> > b/Documentation/devicetree/bindings/soc/intel/intel,keembay-vpu-
> > ipc.yaml
> > new file mode 100644
> > index 000000000000..cd1c4abe8bc9
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/soc/intel/intel,keembay-
> > vpu-ipc.yaml
> > @@ -0,0 +1,153 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +# Copyright (c) Intel Corporation. All rights reserved.
> > +%YAML 1.2
> > +---
> > +$id: "
> > http://devicetree.org/schemas/soc/intel/intel,keembay-vpu-ipc.yaml#
> > "
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: Intel Keem Bay VPU IPC
> > +
> > +maintainers:
> > + - Paul Murphy <paul.j.murphy@intel.com>
> > +
> > +description:
> > + The VPU IPC driver facilitates loading of firmware, control, and
> > communication
> > + with the VPU over the IPC FIFO in the Intel Keem Bay SoC.
>
> VPU is never defined.
We'll spell out the acronym in v3.
Anyway, VPU = Vision Processing Unit
>
> Bindings are for h/w blocks, not drivers.
Will be fixed in v3
>
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - items:
> > + - const: intel,keembay-vpu-ipc
> > +
> > + reg:
> > + items:
> > + - description: NCE WDT registers
> > + - description: NCE TIM_GEN_CONFIG registers
> > + - description: MSS WDT registers
> > + - description: MSS TIM_GEN_CONFIG registers
> > +
> > + reg-names:
> > + items:
> > + - const: nce_wdt
> > + - const: nce_tim_cfg
> > + - const: mss_wdt
> > + - const: mss_tim_cfg
> > +
> > + memory-region:
> > + items:
> > + - description: reference to the VPU reserved memory region
> > + - description: reference to the X509 reserved memory region
> > + - description: reference to the MSS IPC area
> > +
> > + clocks:
> > + items:
> > + - description: cpu clock
> > + - description: pll 0 out 0 rate
> > + - description: pll 0 out 1 rate
> > + - description: pll 0 out 2 rate
> > + - description: pll 0 out 3 rate
> > + - description: pll 1 out 0 rate
> > + - description: pll 1 out 1 rate
> > + - description: pll 1 out 2 rate
> > + - description: pll 1 out 3 rate
> > + - description: pll 2 out 0 rate
> > + - description: pll 2 out 1 rate
> > + - description: pll 2 out 2 rate
> > + - description: pll 2 out 3 rate
> > +
> > + clock-names:
> > + items:
> > + - const: cpu_clock
> > + - const: pll_0_out_0
> > + - const: pll_0_out_1
> > + - const: pll_0_out_2
> > + - const: pll_0_out_3
> > + - const: pll_1_out_0
> > + - const: pll_1_out_1
> > + - const: pll_1_out_2
> > + - const: pll_1_out_3
> > + - const: pll_2_out_0
> > + - const: pll_2_out_1
> > + - const: pll_2_out_2
> > + - const: pll_2_out_3
> > +
> > + interrupts:
> > + items:
> > + - description: number of NCE sub-system WDT timeout IRQ
> > + - description: number of MSS sub-system WDT timeout IRQ
> > +
> > + interrupt-names:
> > + items:
> > + - const: nce_wdt
> > + - const: mss_wdt
> > +
> > + intel,keembay-vpu-ipc-nce-wdt-redirect:
> > + $ref: "/schemas/types.yaml#/definitions/uint32"
> > + description:
> > + Number to which we will request that the NCE sub-system
> > + re-directs it's WDT timeout IRQ
> > +
> > + intel,keembay-vpu-ipc-mss-wdt-redirect:
> > + $ref: "/schemas/types.yaml#/definitions/uint32"
> > + description:
> > + Number to which we will request that the MSS sub-system
> > + re-directs it's WDT timeout IRQ
>
> These look like the same value as the interrupt numbers?
That's a very good point. We'll drop these additional properties and
re-use the interrupt numbers.
>
> > +
> > + intel,keembay-vpu-ipc-imr:
> > + $ref: "/schemas/types.yaml#/definitions/uint32"
> > + description:
> > + IMR (isolated memory region) number which we will request
> > + the runtime service uses to protect the VPU memory region
> > + before authentication
> > +
> > + intel,keembay-vpu-ipc-id:
> > + $ref: "/schemas/types.yaml#/definitions/uint32"
> > + description: The VPU ID to be passed to the VPU firmware.
> > +
> > +additionalProperties: False
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + vpu-ipc@3f00209c {
> > + compatible = "intel,keembay-vpu-ipc";
> > + reg = <0x3f00209c 0x10>,
> > + <0x3f003008 0x4>,
> > + <0x2082009c 0x10>,
> > + <0x20821008 0x4>;
> > + reg-names = "nce_wdt",
> > + "nce_tim_cfg",
> > + "mss_wdt",
> > + "mss_tim_cfg";
> > + memory-region = <&vpu_reserved>,
> > + <&vpu_x509_reserved>,
> > + <&mss_ipc_reserved>;
> > + clocks = <&scmi_clk 0>,
> > + <&scmi_clk 0>,
> > + <&scmi_clk 1>,
> > + <&scmi_clk 2>,
> > + <&scmi_clk 3>,
> > + <&scmi_clk 4>,
> > + <&scmi_clk 5>,
> > + <&scmi_clk 6>,
> > + <&scmi_clk 7>,
> > + <&scmi_clk 8>,
> > + <&scmi_clk 9>,
> > + <&scmi_clk 10>,
> > + <&scmi_clk 11>;
> > + clock-names = "cpu_clock",
> > + "pll_0_out_0", "pll_0_out_1",
> > + "pll_0_out_2", "pll_0_out_3",
> > + "pll_1_out_0", "pll_1_out_1",
> > + "pll_1_out_2", "pll_1_out_3",
> > + "pll_2_out_0", "pll_2_out_1",
> > + "pll_2_out_2", "pll_2_out_3";
> > + interrupts = <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupt-names = "nce_wdt", "mss_wdt";
> > + intel,keembay-vpu-ipc-nce-wdt-redirect = <63>;
> > + intel,keembay-vpu-ipc-mss-wdt-redirect = <47>;
> > + intel,keembay-vpu-ipc-imr = <9>;
> > + intel,keembay-vpu-ipc-id = <0>;
> > + };
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2021-01-19 22:46 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 21:25 [PATCH v2 00/34] Intel Vision Processing base enabling mgross
2021-01-08 21:25 ` [PATCH v2 01/34] Add Vision Processing Unit (VPU) documentation mgross
2021-01-08 21:25 ` [PATCH v2 02/34] dt-bindings: mailbox: Add Intel VPU IPC mailbox bindings mgross
2021-01-08 21:25 ` [PATCH v2 03/34] mailbox: vpu-ipc-mailbox: Add support for Intel VPU IPC mailbox mgross
2021-01-08 21:25 ` [PATCH v2 04/34] dt-bindings: Add bindings for Keem Bay IPC driver mgross
2021-01-08 21:25 ` [PATCH v2 05/34] keembay-ipc: Add Keem Bay IPC module mgross
2021-01-08 21:25 ` [PATCH v2 06/34] dt-bindings: Add bindings for Keem Bay VPU IPC driver mgross
2021-01-10 17:18 ` Rob Herring
2021-01-11 19:24 ` Rob Herring
2021-01-19 14:32 ` Alessandrelli, Daniele [this message]
2021-01-08 21:25 ` [PATCH v2 07/34] keembay-vpu-ipc: Add Keem Bay VPU IPC module mgross
2021-01-08 21:25 ` [PATCH v2 08/34] misc: xlink-pcie: Add documentation for XLink PCIe driver mgross
2021-01-19 19:36 ` Randy Dunlap
2021-01-24 18:27 ` Thokala, Srikanth
2021-01-08 21:25 ` [PATCH v2 09/34] misc: xlink-pcie: lh: Add PCIe EPF driver for Local Host mgross
2021-01-20 17:57 ` Greg KH
2021-01-24 11:48 ` Thokala, Srikanth
2021-01-24 11:56 ` Greg KH
2021-01-24 18:18 ` Thokala, Srikanth
2021-01-08 21:25 ` [PATCH v2 10/34] misc: xlink-pcie: lh: Add PCIe EP DMA functionality mgross
2021-01-08 21:25 ` [PATCH v2 11/34] misc: xlink-pcie: lh: Add core communication logic mgross
2021-01-08 21:25 ` [PATCH v2 12/34] misc: xlink-pcie: lh: Prepare changes for adding remote host driver mgross
2021-01-08 21:25 ` [PATCH v2 13/34] misc: xlink-pcie: rh: Add PCIe EP driver for Remote Host mgross
2021-01-08 21:25 ` [PATCH v2 14/34] misc: xlink-pcie: rh: Add core communication logic mgross
2021-01-08 21:25 ` [PATCH v2 15/34] misc: xlink-pcie: Add XLink API interface mgross
2021-01-20 17:59 ` Greg KH
2021-01-21 23:20 ` mark gross
2021-01-24 11:46 ` Thokala, Srikanth
2021-01-08 21:25 ` [PATCH v2 16/34] misc: xlink-pcie: Add asynchronous event notification support for XLink mgross
2021-01-08 21:25 ` [PATCH v2 17/34] xlink-ipc: Add xlink ipc device tree bindings mgross
2021-01-10 17:18 ` Rob Herring
2021-01-08 21:25 ` [PATCH v2 18/34] xlink-ipc: Add xlink ipc driver mgross
2021-01-08 21:25 ` [PATCH v2 19/34] xlink-core: Add xlink core device tree bindings mgross
2021-01-10 17:18 ` Rob Herring
2021-01-11 19:27 ` Rob Herring
2021-01-08 21:25 ` [PATCH v2 20/34] xlink-core: Add xlink core driver xLink mgross
2021-01-19 19:58 ` Randy Dunlap
2021-01-08 21:25 ` [PATCH v2 21/34] xlink-core: Enable xlink protocol over pcie mgross
2021-01-08 21:25 ` [PATCH v2 22/34] xlink-core: Enable VPU IP management and runtime control mgross
2021-01-08 21:25 ` [PATCH v2 23/34] xlink-core: add async channel and events mgross
2021-01-08 21:25 ` [PATCH v2 24/34] dt-bindings: misc: Add Keem Bay vpumgr mgross
2021-01-08 21:25 ` [PATCH v2 25/34] misc: Add Keem Bay VPU manager mgross
2021-01-08 21:25 ` [PATCH v2 26/34] dt-bindings: misc: intel_tsens: Add tsens thermal bindings documentation mgross
2021-01-08 21:25 ` [PATCH v2 27/34] misc: Tsens ARM host thermal driver mgross
2021-01-08 21:25 ` [PATCH v2 28/34] misc: Intel tsens IA host driver mgross
2021-01-08 21:25 ` [PATCH v2 29/34] Intel tsens i2c slave driver mgross
2021-01-12 7:15 ` Randy Dunlap
2021-01-25 23:39 ` mark gross
2021-01-26 7:45 ` Arnd Bergmann
2021-01-26 14:56 ` Gross, Mark
2021-01-27 4:45 ` C, Udhayakumar
2021-01-27 4:44 ` C, Udhayakumar
2021-01-08 21:25 ` [PATCH v2 30/34] misc:intel_tsens: Intel Keem Bay tsens driver mgross
2021-01-08 21:25 ` [PATCH v2 31/34] Intel Keem Bay XLink SMBus driver mgross
2021-01-08 21:25 ` [PATCH v2 32/34] dt-bindings: misc: hddl_dev: Add hddl device management documentation mgross
2021-01-08 21:25 ` [PATCH v2 33/34] misc: Hddl device management for local host mgross
2021-01-08 21:26 ` [PATCH v2 34/34] misc: HDDL device management for IA host mgross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9996e4a93e79ffc70e1c401c2ce3ec526060f48c.camel@intel.com \
--to=daniele.alessandrelli@intel.com \
--cc=arnd@arndb.de \
--cc=bp@suse.de \
--cc=corbet@lwn.net \
--cc=damien.lemoal@wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=jassisinghbrar@gmail.com \
--cc=leonard.crestez@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mgross@linux.intel.com \
--cc=palmerdabbelt@google.com \
--cc=paul.j.murphy@intel.com \
--cc=paul.walmsley@sifive.com \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).