From: "Thokala, Srikanth" <srikanth.thokala@intel.com>
To: Randy Dunlap <rdunlap@infradead.org>,
"mgross@linux.intel.com" <mgross@linux.intel.com>,
"markgross@kernel.org" <markgross@kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>, "bp@suse.de" <bp@suse.de>,
"damien.lemoal@wdc.com" <damien.lemoal@wdc.com>,
"dragan.cvetic@xilinx.com" <dragan.cvetic@xilinx.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"corbet@lwn.net" <corbet@lwn.net>,
"leonard.crestez@nxp.com" <leonard.crestez@nxp.com>,
"palmerdabbelt@google.com" <palmerdabbelt@google.com>,
"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
"peng.fan@nxp.com" <peng.fan@nxp.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"jassisinghbrar@gmail.com" <jassisinghbrar@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: RE: [PATCH v2 08/34] misc: xlink-pcie: Add documentation for XLink PCIe driver
Date: Sun, 24 Jan 2021 18:27:47 +0000 [thread overview]
Message-ID: <MWHPR11MB14063D4E9312923FF5F9DFB885BE9@MWHPR11MB1406.namprd11.prod.outlook.com> (raw)
In-Reply-To: <0e68a2f9-f02d-c777-d9b8-b1ad13555ab3@infradead.org>
Hi Randy,
Thank you for the review.
> -----Original Message-----
> From: Randy Dunlap <rdunlap@infradead.org>
> Sent: Wednesday, January 20, 2021 1:06 AM
> To: mgross@linux.intel.com; markgross@kernel.org; arnd@arndb.de;
> bp@suse.de; damien.lemoal@wdc.com; dragan.cvetic@xilinx.com;
> gregkh@linuxfoundation.org; corbet@lwn.net; leonard.crestez@nxp.com;
> palmerdabbelt@google.com; paul.walmsley@sifive.com; peng.fan@nxp.com;
> robh+dt@kernel.org; shawnguo@kernel.org; jassisinghbrar@gmail.com
> Cc: linux-kernel@vger.kernel.org; Thokala, Srikanth
> <srikanth.thokala@intel.com>; linux-doc@vger.kernel.org
> Subject: Re: [PATCH v2 08/34] misc: xlink-pcie: Add documentation for
> XLink PCIe driver
>
> Hi,
> Here are a few doc comments for you:
>
> On 1/8/21 1:25 PM, mgross@linux.intel.com wrote:
> > From: Srikanth Thokala <srikanth.thokala@intel.com>
> >
> > Provide overview of XLink PCIe driver implementation
> >
> > Cc: Jonathan Corbet <corbet@lwn.net>
> > Cc: linux-doc@vger.kernel.org
> > Reviewed-by: Mark Gross <mgross@linux.intel.com>
> > Signed-off-by: Srikanth Thokala <srikanth.thokala@intel.com>
> > ---
> > Documentation/vpu/index.rst | 1 +
> > Documentation/vpu/xlink-pcie.rst | 90 ++++++++++++++++++++++++++++++++
> > 2 files changed, 91 insertions(+)
> > create mode 100644 Documentation/vpu/xlink-pcie.rst
> >
>
> > diff --git a/Documentation/vpu/xlink-pcie.rst b/Documentation/vpu/xlink-
> pcie.rst
> > new file mode 100644
> > index 000000000000..2d877c966b1e
> > --- /dev/null
> > +++ b/Documentation/vpu/xlink-pcie.rst
> > @@ -0,0 +1,90 @@
> > +.. SPDX-License-Identifier: GPL-2.0
> > +
> > +================================
> > +Kernel driver: Xlink-pcie driver
> > +================================
> > +Supported chips:
> > + * Intel Edge.AI Computer Vision platforms: Keem Bay
> > + Suffix: Bay
> > + Slave address: 6240
> > + Datasheet: Publicly available at Intel
> > +
> > +Author: Srikanth Thokala Srikanth.Thokala@intel.com
> > +
> > +Introduction
> > +============
> > +The Xlink-pcie driver provides transport layer implementation for
> > +the data transfers to support Xlink protocol subsystem communication
> with the
> > +peer device. i.e, between remote host system and Keem Bay device.
>
> device, i.e.,
Ok.
>
> > +
> > +The Keem Bay device is an ARM-based SOC that includes a vision
> processing
> > +unit (VPU) and deep learning, neural network core in the hardware.
> > +The Xlink-pcie driver exports a functional device endpoint to the Keem
> Bay
> > +device and supports two-way communication with the peer device.
> > +
> > +High-level architecture
> > +=======================
> > +Remote Host: IA CPU
> > +Local Host: ARM CPU (Keem Bay)::
> > +
> > + +--------------------------------------------------------------
> ----------+
> > + | Remote Host IA CPU | | Local Host ARM CPU (Keem
> Bay) | |
> > +
> +==================================+=+===============================+===+
> > + | User App | | User App
> | |
> > + +----------------------------------+-+-------------------------
> ------+---+
> > + | XLink UAPI | | XLink UAPI
> | |
> > + +----------------------------------+-+-------------------------
> ------+---+
> > + | XLink Core | | XLink Core
> | |
> > + +----------------------------------+-+-------------------------
> ------+---+
> > + | XLink PCIe | | XLink PCIe
> | |
> > + +----------------------------------+-+-------------------------
> ------+---+
> > + | XLink-PCIe Remote Host driver | | XLink-PCIe Local Host
> driver | |
> > + +----------------------------------+-+-------------------------
> ------+---+
> > + |-:-:-:-:-:-:-:-:-:-:-:-:-:-:-:-:-:|:|:-:-:-:-:-:-:-:-:-:-:-:-
> :-:-:-:-:-:|
> > + +----------------------------------+-+-------------------------
> ------+---+
> > + | PCIe Host Controller | | PCIe Device Controller
> | HW|
> > + +----------------------------------+-+-------------------------
> ------+---+
> > + ^ ^
> > + | |
> > + |------------- PCIe x2 Link -----------------|
> > +
> > +This XLink PCIe driver comprises of two variants:
> > +* Local Host driver
> > +
> > + * Intended for ARM CPU
> > + * It is based on PCI Endpoint Framework
> > + * Driver path: {tree}/drivers/misc/Xlink-pcie/local_host
> > +
> > +* Remote Host driver
> > +
> > + * Intended for IA CPU
> > + * It is a PCIe endpoint driver
> > + * Driver path: {tree}/drivers/misc/Xlink-pcie/remote_host
> > +
> > +XLink PCIe communication between local host and remote host is achieved
> through
> > +ring buffer management and MSI/Doorbell interrupts.
> > +
> > +The Xlink-pcie driver subsystem registers the Keem Bay device as an
> endpoint
> > +driver and provides standard linux PCIe sysfs interface, #
>
> Linux
Ok.
> What is the '#' sign for above?
It denotes Linux prompt; I will change it to be more meaningful.
Thanks!
Srikanth
>
> > +/sys/bus/pci/devices/xxxx:xx:xx.0/
> > +
> > +
> > +XLink protocol subsystem
> > +========================
> > +Xlink is an abstracted control and communication subsystem based on
> channel
> > +identification. It is intended to support VPU technology both at SoC
> level as
> > +well as at IP level, over multiple interfaces.
> > +
> > +- The Xlink subsystem abstracts several types of communication channels
> > + underneath, allowing the usage of different interfaces with the
> > + same function call interface.
> > +- The Communication channels are full-duplex protocol channels allowing
> > + concurrent bidirectional communication.
> > +- The Xlink subsystem also supports control operations to VPU either
> > + from standalone local system or from remote system based on
> communication
> > + interface underneath.
> > +- The Xlink subsystem supports the following communication interfaces:
> > + * USB CDC
> > + * Gigabit Ethernet
> > + * PCIe
> > + * IPC
> >
>
>
> --
> ~Randy
> "He closes his eyes and drops the goggles. You can't get hurt
> by looking at a bitmap. Or can you?"
> (Neal Stephenson: Snow Crash)
next prev parent reply other threads:[~2021-01-24 18:28 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 21:25 [PATCH v2 00/34] Intel Vision Processing base enabling mgross
2021-01-08 21:25 ` [PATCH v2 01/34] Add Vision Processing Unit (VPU) documentation mgross
2021-01-08 21:25 ` [PATCH v2 02/34] dt-bindings: mailbox: Add Intel VPU IPC mailbox bindings mgross
2021-01-08 21:25 ` [PATCH v2 03/34] mailbox: vpu-ipc-mailbox: Add support for Intel VPU IPC mailbox mgross
2021-01-08 21:25 ` [PATCH v2 04/34] dt-bindings: Add bindings for Keem Bay IPC driver mgross
2021-01-08 21:25 ` [PATCH v2 05/34] keembay-ipc: Add Keem Bay IPC module mgross
2021-01-08 21:25 ` [PATCH v2 06/34] dt-bindings: Add bindings for Keem Bay VPU IPC driver mgross
2021-01-10 17:18 ` Rob Herring
2021-01-11 19:24 ` Rob Herring
2021-01-19 14:32 ` Alessandrelli, Daniele
2021-01-08 21:25 ` [PATCH v2 07/34] keembay-vpu-ipc: Add Keem Bay VPU IPC module mgross
2021-01-08 21:25 ` [PATCH v2 08/34] misc: xlink-pcie: Add documentation for XLink PCIe driver mgross
2021-01-19 19:36 ` Randy Dunlap
2021-01-24 18:27 ` Thokala, Srikanth [this message]
2021-01-08 21:25 ` [PATCH v2 09/34] misc: xlink-pcie: lh: Add PCIe EPF driver for Local Host mgross
2021-01-20 17:57 ` Greg KH
2021-01-24 11:48 ` Thokala, Srikanth
2021-01-24 11:56 ` Greg KH
2021-01-24 18:18 ` Thokala, Srikanth
2021-01-08 21:25 ` [PATCH v2 10/34] misc: xlink-pcie: lh: Add PCIe EP DMA functionality mgross
2021-01-08 21:25 ` [PATCH v2 11/34] misc: xlink-pcie: lh: Add core communication logic mgross
2021-01-08 21:25 ` [PATCH v2 12/34] misc: xlink-pcie: lh: Prepare changes for adding remote host driver mgross
2021-01-08 21:25 ` [PATCH v2 13/34] misc: xlink-pcie: rh: Add PCIe EP driver for Remote Host mgross
2021-01-08 21:25 ` [PATCH v2 14/34] misc: xlink-pcie: rh: Add core communication logic mgross
2021-01-08 21:25 ` [PATCH v2 15/34] misc: xlink-pcie: Add XLink API interface mgross
2021-01-20 17:59 ` Greg KH
2021-01-21 23:20 ` mark gross
2021-01-24 11:46 ` Thokala, Srikanth
2021-01-08 21:25 ` [PATCH v2 16/34] misc: xlink-pcie: Add asynchronous event notification support for XLink mgross
2021-01-08 21:25 ` [PATCH v2 17/34] xlink-ipc: Add xlink ipc device tree bindings mgross
2021-01-10 17:18 ` Rob Herring
2021-01-08 21:25 ` [PATCH v2 18/34] xlink-ipc: Add xlink ipc driver mgross
2021-01-08 21:25 ` [PATCH v2 19/34] xlink-core: Add xlink core device tree bindings mgross
2021-01-10 17:18 ` Rob Herring
2021-01-11 19:27 ` Rob Herring
2021-01-08 21:25 ` [PATCH v2 20/34] xlink-core: Add xlink core driver xLink mgross
2021-01-19 19:58 ` Randy Dunlap
2021-01-08 21:25 ` [PATCH v2 21/34] xlink-core: Enable xlink protocol over pcie mgross
2021-01-08 21:25 ` [PATCH v2 22/34] xlink-core: Enable VPU IP management and runtime control mgross
2021-01-08 21:25 ` [PATCH v2 23/34] xlink-core: add async channel and events mgross
2021-01-08 21:25 ` [PATCH v2 24/34] dt-bindings: misc: Add Keem Bay vpumgr mgross
2021-01-08 21:25 ` [PATCH v2 25/34] misc: Add Keem Bay VPU manager mgross
2021-01-08 21:25 ` [PATCH v2 26/34] dt-bindings: misc: intel_tsens: Add tsens thermal bindings documentation mgross
2021-01-08 21:25 ` [PATCH v2 27/34] misc: Tsens ARM host thermal driver mgross
2021-01-08 21:25 ` [PATCH v2 28/34] misc: Intel tsens IA host driver mgross
2021-01-08 21:25 ` [PATCH v2 29/34] Intel tsens i2c slave driver mgross
2021-01-12 7:15 ` Randy Dunlap
2021-01-25 23:39 ` mark gross
2021-01-26 7:45 ` Arnd Bergmann
2021-01-26 14:56 ` Gross, Mark
2021-01-27 4:45 ` C, Udhayakumar
2021-01-27 4:44 ` C, Udhayakumar
2021-01-08 21:25 ` [PATCH v2 30/34] misc:intel_tsens: Intel Keem Bay tsens driver mgross
2021-01-08 21:25 ` [PATCH v2 31/34] Intel Keem Bay XLink SMBus driver mgross
2021-01-08 21:25 ` [PATCH v2 32/34] dt-bindings: misc: hddl_dev: Add hddl device management documentation mgross
2021-01-08 21:25 ` [PATCH v2 33/34] misc: Hddl device management for local host mgross
2021-01-08 21:26 ` [PATCH v2 34/34] misc: HDDL device management for IA host mgross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB14063D4E9312923FF5F9DFB885BE9@MWHPR11MB1406.namprd11.prod.outlook.com \
--to=srikanth.thokala@intel.com \
--cc=arnd@arndb.de \
--cc=bp@suse.de \
--cc=corbet@lwn.net \
--cc=damien.lemoal@wdc.com \
--cc=dragan.cvetic@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=jassisinghbrar@gmail.com \
--cc=leonard.crestez@nxp.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mgross@linux.intel.com \
--cc=palmerdabbelt@google.com \
--cc=paul.walmsley@sifive.com \
--cc=peng.fan@nxp.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).