Re: [PATCH v11 1/5] usb: dwc3: core: Add HS phy mode variable and phy poweroff flag

From: "Sandeep Maheswaram (Temp)" <quic_c_sanm@quicinc.com>
To: Pavan Kondeti <quic_pkondeti@quicinc.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Felipe Balbi <balbi@kernel.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Doug Anderson <dianders@chromium.org>,
	"Matthias Kaehlcke" <mka@chromium.org>,
	Mathias Nyman <mathias.nyman@intel.com>,
	<linux-arm-msm@vger.kernel.org>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <quic_ppratap@quicinc.com>,
	<quic_kriskura@quicinc.com>
Subject: Re: [PATCH v11 1/5] usb: dwc3: core: Add HS phy mode variable and phy poweroff flag
Date: Tue, 22 Mar 2022 14:12:21 +0530	[thread overview]
Message-ID: <9c0d15d5-c5d1-7233-60e3-de36fa9eb287@quicinc.com> (raw)
In-Reply-To: <20220322080937.GI23316@hu-pkondeti-hyd.qualcomm.com>

On 3/22/2022 1:39 PM, Pavan Kondeti wrote:
> Hi Sandeep,
>
> On Tue, Mar 22, 2022 at 12:37:52PM +0530, Sandeep Maheswaram wrote:
>> Add variables in dwc3 structure to check HS phy mode which is
>> used to configure interrupts and phy poweroff flag to check
>> the phy status during system resume.
>>
>> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
>> ---
>>   drivers/usb/dwc3/core.h | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
>> index 5c9d467..f11a60c 100644
>> --- a/drivers/usb/dwc3/core.h
>> +++ b/drivers/usb/dwc3/core.h
>> @@ -1154,6 +1154,9 @@ struct dwc3 {
>>   
>>   	bool			phys_ready;
>>   
>> +	unsigned int            hs_phy_mode;
>> +	bool			phy_power_off;
>> +
>>   	struct ulpi		*ulpi;
>>   	bool			ulpi_ready;
>>   
> Why adding members in a separate patch? This needs to be squashed with
> 2/5 patch in the series where these members are used in taking host
> mode PM decisions. Please fix this.
>
> Thanks,
> Pavan

Sure . Will do in next version.

Regards

Sandeep