* [Patch v002] gcov: Added support for >=gcc-6
@ 2016-07-01 9:06 Florian Meier
2016-07-01 10:58 ` Peter Oberparleiter
0 siblings, 1 reply; 8+ messages in thread
From: Florian Meier @ 2016-07-01 9:06 UTC (permalink / raw)
To: Peter Oberparleiter; +Cc: linux-kernel
Signed-off-by: Florian Meier <Florian.Meier@informatik.uni-erlangen.de>
---
kernel/gcov/gcc_4_7.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
index e25e92f..6a5c239 100644
--- a/kernel/gcov/gcc_4_7.c
+++ b/kernel/gcov/gcc_4_7.c
@@ -18,7 +18,7 @@
#include <linux/vmalloc.h>
#include "gcov.h"
-#if __GNUC__ == 5 && __GNUC_MINOR__ >= 1
+#if (__GNUC__ > 5) || (__GNUC__ == 5 && __GNUC_MINOR__ >= 1)
#define GCOV_COUNTERS 10
#elif __GNUC__ == 4 && __GNUC_MINOR__ >= 9
#define GCOV_COUNTERS 9
--
2.9.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Patch v002] gcov: Added support for >=gcc-6
2016-07-01 9:06 [Patch v002] gcov: Added support for >=gcc-6 Florian Meier
@ 2016-07-01 10:58 ` Peter Oberparleiter
2016-07-01 13:09 ` [PATCH v003] Added support for gcc version >= 6 Florian Meier
0 siblings, 1 reply; 8+ messages in thread
From: Peter Oberparleiter @ 2016-07-01 10:58 UTC (permalink / raw)
To: Florian Meier; +Cc: linux-kernel
On 01.07.2016 11:06, Florian Meier wrote:
> Signed-off-by: Florian Meier <Florian.Meier@informatik.uni-erlangen.de>
> ---
> kernel/gcov/gcc_4_7.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
> index e25e92f..6a5c239 100644
> --- a/kernel/gcov/gcc_4_7.c
> +++ b/kernel/gcov/gcc_4_7.c
> @@ -18,7 +18,7 @@
> #include <linux/vmalloc.h>
> #include "gcov.h"
>
> -#if __GNUC__ == 5 && __GNUC_MINOR__ >= 1
> +#if (__GNUC__ > 5) || (__GNUC__ == 5 && __GNUC_MINOR__ >= 1)
> #define GCOV_COUNTERS 10
> #elif __GNUC__ == 4 && __GNUC_MINOR__ >= 9
> #define GCOV_COUNTERS 9
>
Content looks good but the patch doesn't apply due to whitespace issues.
Could you send a version with the tabs remaining intact? Also a slightly
more verbose patch message (similar to the one of the original patch)
would be helpful.
--
Peter Oberparleiter
Linux on z Systems Development - IBM Germany
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v003] Added support for gcc version >= 6
2016-07-01 10:58 ` Peter Oberparleiter
@ 2016-07-01 13:09 ` Florian Meier
2016-07-01 15:46 ` Peter Oberparleiter
2016-07-01 16:26 ` Joe Perches
0 siblings, 2 replies; 8+ messages in thread
From: Florian Meier @ 2016-07-01 13:09 UTC (permalink / raw)
To: Peter Oberparleiter; +Cc: linux-kernel
Added support for gcc version >= 6 in gcov.
Signed-off-by: Florian Meier <Florian.Meier@informatik.uni-erlangen.de>
---
kernel/gcov/gcc_4_7.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
index e25e92f..6a5c239 100644
--- a/kernel/gcov/gcc_4_7.c
+++ b/kernel/gcov/gcc_4_7.c
@@ -18,7 +18,7 @@
#include <linux/vmalloc.h>
#include "gcov.h"
-#if __GNUC__ == 5 && __GNUC_MINOR__ >= 1
+#if (__GNUC__ > 5) || (__GNUC__ == 5 && __GNUC_MINOR__ >= 1)
#define GCOV_COUNTERS 10
#elif __GNUC__ == 4 && __GNUC_MINOR__ >= 9
#define GCOV_COUNTERS 9
--
2.9.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v003] Added support for gcc version >= 6
2016-07-01 13:09 ` [PATCH v003] Added support for gcc version >= 6 Florian Meier
@ 2016-07-01 15:46 ` Peter Oberparleiter
2016-07-01 16:26 ` Joe Perches
1 sibling, 0 replies; 8+ messages in thread
From: Peter Oberparleiter @ 2016-07-01 15:46 UTC (permalink / raw)
To: Florian Meier, Andrew Morton; +Cc: linux-kernel
On 01.07.2016 15:09, Florian Meier wrote:
> Added support for gcc version >= 6 in gcov.
>
> Signed-off-by: Florian Meier <Florian.Meier@informatik.uni-erlangen.de>
Looks good, thanks! Tested successfully with gcc 4.8.5 and gcc 6.1.0.
Andrew, could you pick this change up via your tree?
Reviewed-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
Tested-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
> ---
> kernel/gcov/gcc_4_7.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
> index e25e92f..6a5c239 100644
> --- a/kernel/gcov/gcc_4_7.c
> +++ b/kernel/gcov/gcc_4_7.c
> @@ -18,7 +18,7 @@
> #include <linux/vmalloc.h>
> #include "gcov.h"
>
> -#if __GNUC__ == 5 && __GNUC_MINOR__ >= 1
> +#if (__GNUC__ > 5) || (__GNUC__ == 5 && __GNUC_MINOR__ >= 1)
> #define GCOV_COUNTERS 10
> #elif __GNUC__ == 4 && __GNUC_MINOR__ >= 9
> #define GCOV_COUNTERS 9
>
--
Peter Oberparleiter
Linux on z Systems Development - IBM Germany
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v003] Added support for gcc version >= 6
2016-07-01 13:09 ` [PATCH v003] Added support for gcc version >= 6 Florian Meier
2016-07-01 15:46 ` Peter Oberparleiter
@ 2016-07-01 16:26 ` Joe Perches
2016-07-04 7:43 ` Peter Oberparleiter
1 sibling, 1 reply; 8+ messages in thread
From: Joe Perches @ 2016-07-01 16:26 UTC (permalink / raw)
To: Florian Meier, Peter Oberparleiter; +Cc: linux-kernel
On Fri, 2016-07-01 at 15:09 +0200, Florian Meier wrote:
> Added support for gcc version >= 6 in gcov.
It's important to mention the subsystem in the patch subject
e.g. "Subject: [PATCH V3] gcov: Support gcc version >= 6"
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v003] Added support for gcc version >= 6
2016-07-01 16:26 ` Joe Perches
@ 2016-07-04 7:43 ` Peter Oberparleiter
2016-07-04 7:56 ` Florian Meier
0 siblings, 1 reply; 8+ messages in thread
From: Peter Oberparleiter @ 2016-07-04 7:43 UTC (permalink / raw)
To: Joe Perches, Florian Meier; +Cc: linux-kernel
On 01.07.2016 18:26, Joe Perches wrote:
> On Fri, 2016-07-01 at 15:09 +0200, Florian Meier wrote:
>> Added support for gcc version >= 6 in gcov.
>
> It's important to mention the subsystem in the patch subject
>
> e.g. "Subject: [PATCH V3] gcov: Support gcc version >= 6"
Thanks for pointing this out - I completely missed that this was lost
between v2 and v3 of the patch. Should we re-post or can this be fixed
another way?
--
Peter Oberparleiter
Linux on z Systems Development - IBM Germany
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v003] Added support for gcc version >= 6
2016-07-04 7:43 ` Peter Oberparleiter
@ 2016-07-04 7:56 ` Florian Meier
2016-07-04 8:19 ` [PATCH v004] gcov: " Florian Meier
0 siblings, 1 reply; 8+ messages in thread
From: Florian Meier @ 2016-07-04 7:56 UTC (permalink / raw)
To: Peter Oberparleiter; +Cc: Joe Perches, linux-kernel
I'll repost it, that's the easiest fix.
On 4 July 2016 at 09:43, Peter Oberparleiter <oberpar@linux.vnet.ibm.com> wrote:
> On 01.07.2016 18:26, Joe Perches wrote:
>> On Fri, 2016-07-01 at 15:09 +0200, Florian Meier wrote:
>>> Added support for gcc version >= 6 in gcov.
>>
>> It's important to mention the subsystem in the patch subject
>>
>> e.g. "Subject: [PATCH V3] gcov: Support gcc version >= 6"
>
> Thanks for pointing this out - I completely missed that this was lost
> between v2 and v3 of the patch. Should we re-post or can this be fixed
> another way?
>
> --
> Peter Oberparleiter
> Linux on z Systems Development - IBM Germany
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v004] gcov: Added support for gcc version >= 6
2016-07-04 7:56 ` Florian Meier
@ 2016-07-04 8:19 ` Florian Meier
0 siblings, 0 replies; 8+ messages in thread
From: Florian Meier @ 2016-07-04 8:19 UTC (permalink / raw)
To: Peter Oberparleiter; +Cc: linux-kernel, Joe Perches
Added support for gcc version >= 6 in gcov.
Signed-off-by: Florian Meier <Florian.Meier@informatik.uni-erlangen.de>
---
kernel/gcov/gcc_4_7.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
index e25e92f..6a5c239 100644
--- a/kernel/gcov/gcc_4_7.c
+++ b/kernel/gcov/gcc_4_7.c
@@ -18,7 +18,7 @@
#include <linux/vmalloc.h>
#include "gcov.h"
-#if __GNUC__ == 5 && __GNUC_MINOR__ >= 1
+#if (__GNUC__ > 5) || (__GNUC__ == 5 && __GNUC_MINOR__ >= 1)
#define GCOV_COUNTERS 10
#elif __GNUC__ == 4 && __GNUC_MINOR__ >= 9
#define GCOV_COUNTERS 9
--
2.9.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-07-04 8:19 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-01 9:06 [Patch v002] gcov: Added support for >=gcc-6 Florian Meier
2016-07-01 10:58 ` Peter Oberparleiter
2016-07-01 13:09 ` [PATCH v003] Added support for gcc version >= 6 Florian Meier
2016-07-01 15:46 ` Peter Oberparleiter
2016-07-01 16:26 ` Joe Perches
2016-07-04 7:43 ` Peter Oberparleiter
2016-07-04 7:56 ` Florian Meier
2016-07-04 8:19 ` [PATCH v004] gcov: " Florian Meier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).