* [PATCH] MIPS: pic32mzda: fix linker error for pic32_get_pbclk().
@ 2016-06-02 5:20 Purna Chandra Mandal
2016-06-02 9:15 ` Harvey Hunt
0 siblings, 1 reply; 3+ messages in thread
From: Purna Chandra Mandal @ 2016-06-02 5:20 UTC (permalink / raw)
To: linux-kernel
Cc: linux-mips, Ralf Baechle, Purna Chandra Mandal, Harvey Hunt,
Joshua Henderson, Joshua Henderson
Early clock API pic32_get_pbclk() is defined in early_clk.c and
used by time.c and early_console.c. When CONFIG_EARLY_PRINTK isn't
set, early_clk.c isn't compiled and so a linker error is reported
while referring the API from time.c.
Fix it by compiling early_clk.c always. Also sort files in
alphabetical order.
Cc: Harvey Hunt <harvey.hunt@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Cc: Joshua Henderson <digitalpeer@digitalpeer.com>
Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
---
arch/mips/pic32/pic32mzda/Makefile | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/mips/pic32/pic32mzda/Makefile b/arch/mips/pic32/pic32mzda/Makefile
index 4a4c272..c286496 100644
--- a/arch/mips/pic32/pic32mzda/Makefile
+++ b/arch/mips/pic32/pic32mzda/Makefile
@@ -2,8 +2,7 @@
# Joshua Henderson, <joshua.henderson@microchip.com>
# Copyright (C) 2015 Microchip Technology, Inc. All rights reserved.
#
-obj-y := init.o time.o config.o
+obj-y := config.o early_clk.o init.o time.o
obj-$(CONFIG_EARLY_PRINTK) += early_console.o \
- early_pin.o \
- early_clk.o
+ early_pin.o
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: pic32mzda: fix linker error for pic32_get_pbclk().
2016-06-02 5:20 [PATCH] MIPS: pic32mzda: fix linker error for pic32_get_pbclk() Purna Chandra Mandal
@ 2016-06-02 9:15 ` Harvey Hunt
2016-06-02 9:19 ` Purna Chandra Mandal
0 siblings, 1 reply; 3+ messages in thread
From: Harvey Hunt @ 2016-06-02 9:15 UTC (permalink / raw)
To: Purna Chandra Mandal, linux-kernel
Cc: linux-mips, Ralf Baechle, Joshua Henderson, Joshua Henderson
Hi Purna,
On 02/06/16 06:20, Purna Chandra Mandal wrote:
> Early clock API pic32_get_pbclk() is defined in early_clk.c and
> used by time.c and early_console.c. When CONFIG_EARLY_PRINTK isn't
> set, early_clk.c isn't compiled and so a linker error is reported
> while referring the API from time.c.
Maybe "early_clk.c isn't compiled and so time.c fails to link"?
>
> Fix it by compiling early_clk.c always. Also sort files in
> alphabetical order.
>
> Cc: Harvey Hunt <harvey.hunt@imgtec.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> Cc: Joshua Henderson <digitalpeer@digitalpeer.com>
>
> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
>
> ---
>
> arch/mips/pic32/pic32mzda/Makefile | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/mips/pic32/pic32mzda/Makefile b/arch/mips/pic32/pic32mzda/Makefile
> index 4a4c272..c286496 100644
> --- a/arch/mips/pic32/pic32mzda/Makefile
> +++ b/arch/mips/pic32/pic32mzda/Makefile
> @@ -2,8 +2,7 @@
> # Joshua Henderson, <joshua.henderson@microchip.com>
> # Copyright (C) 2015 Microchip Technology, Inc. All rights reserved.
> #
> -obj-y := init.o time.o config.o
> +obj-y := config.o early_clk.o init.o time.o
>
> obj-$(CONFIG_EARLY_PRINTK) += early_console.o \
> - early_pin.o \
> - early_clk.o
> + early_pin.o
>
Perhaps add:
Reported-by: Harvey Hunt <harvey.hunt@imgtec.com>
Thanks for fixing this,
Reviewed-by: Harvey Hunt <harvey.hunt@imgtec.com>
Thanks,
Harvey
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: pic32mzda: fix linker error for pic32_get_pbclk().
2016-06-02 9:15 ` Harvey Hunt
@ 2016-06-02 9:19 ` Purna Chandra Mandal
0 siblings, 0 replies; 3+ messages in thread
From: Purna Chandra Mandal @ 2016-06-02 9:19 UTC (permalink / raw)
To: Harvey Hunt, linux-kernel
Cc: linux-mips, Ralf Baechle, Joshua Henderson, Joshua Henderson
On 06/02/2016 02:45 PM, Harvey Hunt wrote:
> Hi Purna,
>
> On 02/06/16 06:20, Purna Chandra Mandal wrote:
>> Early clock API pic32_get_pbclk() is defined in early_clk.c and
>> used by time.c and early_console.c. When CONFIG_EARLY_PRINTK isn't
>> set, early_clk.c isn't compiled and so a linker error is reported
>> while referring the API from time.c.
>
> Maybe "early_clk.c isn't compiled and so time.c fails to link"?
>
ack.
>>
>> Fix it by compiling early_clk.c always. Also sort files in
>> alphabetical order.
>>
>> Cc: Harvey Hunt <harvey.hunt@imgtec.com>
>> Cc: Ralf Baechle <ralf@linux-mips.org>
>> Cc: linux-mips@linux-mips.org
>> Cc: Joshua Henderson <digitalpeer@digitalpeer.com>
>>
>> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
>>
>> ---
>>
>> arch/mips/pic32/pic32mzda/Makefile | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/mips/pic32/pic32mzda/Makefile b/arch/mips/pic32/pic32mzda/Makefile
>> index 4a4c272..c286496 100644
>> --- a/arch/mips/pic32/pic32mzda/Makefile
>> +++ b/arch/mips/pic32/pic32mzda/Makefile
>> @@ -2,8 +2,7 @@
>> # Joshua Henderson, <joshua.henderson@microchip.com>
>> # Copyright (C) 2015 Microchip Technology, Inc. All rights reserved.
>> #
>> -obj-y := init.o time.o config.o
>> +obj-y := config.o early_clk.o init.o time.o
>>
>> obj-$(CONFIG_EARLY_PRINTK) += early_console.o \
>> - early_pin.o \
>> - early_clk.o
>> + early_pin.o
>>
>
> Perhaps add:
>
> Reported-by: Harvey Hunt <harvey.hunt@imgtec.com>
>
> Thanks for fixing this,
>
> Reviewed-by: Harvey Hunt <harvey.hunt@imgtec.com>
>
Thanks Harvey.
> Thanks,
>
> Harvey
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-02 9:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-02 5:20 [PATCH] MIPS: pic32mzda: fix linker error for pic32_get_pbclk() Purna Chandra Mandal
2016-06-02 9:15 ` Harvey Hunt
2016-06-02 9:19 ` Purna Chandra Mandal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).