How should we do a 64-bit jiffies?

* How should we do a 64-bit jiffies?
@ 2001-10-22 15:12 george anzinger
  2001-10-23  5:10 ` Keith Owens
  0 siblings, 1 reply; 25+ messages in thread
From: george anzinger @ 2001-10-22 15:12 UTC (permalink / raw)
  To: linux-kernel, Linus Torvalds

I am working on POSIX timers where there is defined a CLOCK_MONOTONIC. 
The most reasonable implementation of this clock is that it is "uptime"
or jiffies.  The problem is that it is most definitely not MONOTONIC
when it rolls back to 0 :(  Thus the need for 64-bits.

As it turns out, the only code that needs to know about the high order
bits is the code that increments jiffies and the POSIX timer code. 
Every thing else can continue to use the current definition with no
problem.

The solution needs to account for the Endianess of the platform.  Here
are the possible solutions I have come up with:

1.) Define jiffies in the arch section of the code using asm.  Looks
like this for x86:

__asm__( ".global jiffies\n\t"
         ".global jiffiesll\n"
         ".global jiffiesh\n"
         "jiffiesll:\n"
         "jiffies: \n\t"

         ".long 0\n"
         "jiffiesh: \n\t"
         ".long 0");

The up side of this method is that none of the current using code needs
to be aware of the change.  We just remove  "unsigned long volatile
jiffies;" from timer.c.

The down side of this method is that all platforms must do something
similar.

2.) Use a C structure that depends on ENDIAN defines:

 #if defined(__LITTLE_ENDIAN)
      union {
        long long jiffiesll;
        struct {
        int jiffiesl
        int jiffiesh
        } jiffieparts;
 }jiffiesu; 
 #elif defined(__BIG_ENDIAN)
     union {
        long long jiffies64;
        struct {
        int jiffiesh
        int jiffiesl
        } jiffieparts;
 }jiffiesu; 
 #else
 #error "I'm probably missing #include <asm/byteorder.h>"
 #endif
 #define jiffies jiffiesu.jiffieparts.jiffiesl
 #define jiffiesll jiffiesu.jiffies64

The down side with this method is that jiffies can not be used as a
local or structure
element, i.e. it is now a reserved name in the kernel.  

3.)  Define jiffies as 64 bit and use C casts to get to the low order
part:

u64 jiffies_u64;

#define jiffies (unsigned long volatile)jiffies_u64

Here again the down side is  that jiffies can not be used as a local or
structure
element, i.e. it is now a reserved name in the kernel.  

I am sure there are other ways to approach this and I would like to hear
them.  

Approach 1.) requires that all platforms be changed at the same time. 
Approaches 2.) and 3.) require that we find all occurrences of jiffies
should not be "defined" to something else.  The Ibm tick less patch
found most of these, but I am sure there are more lurking in drivers.

Comments?

George

^ permalink raw reply	[flat|nested] 25+ messages in thread