From: Bard Liao <bardliao@realtek.com>
To: Shrirang Bagul <shrirang.bagul@canonical.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Oder Chiou <oder_chiou@realtek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Subject: RE: [PATCH v2 1/4] ASoC: rt5660: Add ACPI support
Date: Fri, 13 Jan 2017 02:53:10 +0000 [thread overview]
Message-ID: <ABFD875FF5FB574BA706497D987D48D7012363F1@RTITMBSV03.realtek.com.tw> (raw)
In-Reply-To: <20170112120101.16933-2-shrirang.bagul@canonical.com>
> -----Original Message-----
> From: Shrirang Bagul [mailto:shrirang.bagul@canonical.com]
> Sent: Thursday, January 12, 2017 8:01 PM
> To: alsa-devel@alsa-project.org
> Cc: linux-kernel@vger.kernel.org; Bard Liao; Oder Chiou; Liam Girdwood; Mark
> Brown; Jaroslav Kysela; Takashi Iwai
> Subject: [PATCH v2 1/4] ASoC: rt5660: Add ACPI support
>
> On Dell IoT Gateways, RT5660 codec is available with ACPI ID 10EC3277.
> Also, GPIO's are only available by index, so we register mappings to allow
> machine drivers to access them by name.
>
> Signed-off-by: Shrirang Bagul <shrirang.bagul@canonical.com>
> ---
> +static const struct acpi_gpio_params audio_wake_intr_gpio =
> { RT5660_GPIO_WAKE_INTR, 0, false };
> +static const struct acpi_gpio_params lineout_mute_gpio =
> { RT5660_GPIO_LINEOUT_MUTE, 0, true };
> +
> +static const struct acpi_gpio_mapping byt_rt5660_gpios[] = {
> + { "audio-wake-intr-gpios", &audio_wake_intr_gpio, 1 },
> + { "lineout-mute-gpios", &lineout_mute_gpio, 1 },
> + { NULL },
> +};
> +
I am thinking if it is more suitable to move the gpio params to
machine driver? They are not codec's gpios and are only used
by machine driver.
> --
> 2.9.3
next prev parent reply other threads:[~2017-01-13 2:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 12:00 [PATCH v2 0/4] ASoC: Dell IoT Gateway audio support Shrirang Bagul
2017-01-12 12:00 ` [PATCH v2 1/4] ASoC: rt5660: Add ACPI support Shrirang Bagul
2017-01-13 2:53 ` Bard Liao [this message]
2017-01-13 22:30 ` Andy Shevchenko
2017-01-12 12:00 ` [PATCH v2 2/4] ASoC: Intel: bytcr_rt5640: move codec clks to card driver data Shrirang Bagul
2017-01-12 12:01 ` [PATCH v2 3/4] ASoC: Intel: Support rt5660 codec for Baytrail Shrirang Bagul
2017-01-12 14:40 ` [alsa-devel] " Pierre-Louis Bossart
2017-01-16 7:45 ` Shrirang Bagul
2017-01-16 15:10 ` Pierre-Louis Bossart
2017-01-12 12:01 ` [PATCH v2 4/4] ASoC: Intel: bytcr_rt5640: Support line-out mute gpio Shrirang Bagul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ABFD875FF5FB574BA706497D987D48D7012363F1@RTITMBSV03.realtek.com.tw \
--to=bardliao@realtek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=shrirang.bagul@canonical.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).