From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Bard Liao <bardliao@realtek.com>
Cc: Shrirang Bagul <shrirang.bagul@canonical.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Oder Chiou <oder_chiou@realtek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v2 1/4] ASoC: rt5660: Add ACPI support
Date: Sat, 14 Jan 2017 00:30:08 +0200 [thread overview]
Message-ID: <CAHp75VdeAZH9U=xnzva+vkTE_3jH7i7tRDQPmKcJ3TTdmj=J8A@mail.gmail.com> (raw)
In-Reply-To: <ABFD875FF5FB574BA706497D987D48D7012363F1@RTITMBSV03.realtek.com.tw>
On Fri, Jan 13, 2017 at 4:53 AM, Bard Liao <bardliao@realtek.com> wrote:
>> +static const struct acpi_gpio_mapping byt_rt5660_gpios[] = {
>> + { "audio-wake-intr-gpios", &audio_wake_intr_gpio, 1 },
>> + { "lineout-mute-gpios", &lineout_mute_gpio, 1 },
>> + { NULL },
>> +};
>> +
>
> I am thinking if it is more suitable to move the gpio params to
> machine driver? They are not codec's gpios and are only used
> by machine driver.
Generally speaking those properties should come per ACPI ID. So, they
should share the same module which has MODULE_DEVICE_TABLE(acpi, ...)
defined.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-01-13 22:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 12:00 [PATCH v2 0/4] ASoC: Dell IoT Gateway audio support Shrirang Bagul
2017-01-12 12:00 ` [PATCH v2 1/4] ASoC: rt5660: Add ACPI support Shrirang Bagul
2017-01-13 2:53 ` Bard Liao
2017-01-13 22:30 ` Andy Shevchenko [this message]
2017-01-12 12:00 ` [PATCH v2 2/4] ASoC: Intel: bytcr_rt5640: move codec clks to card driver data Shrirang Bagul
2017-01-12 12:01 ` [PATCH v2 3/4] ASoC: Intel: Support rt5660 codec for Baytrail Shrirang Bagul
2017-01-12 14:40 ` [alsa-devel] " Pierre-Louis Bossart
2017-01-16 7:45 ` Shrirang Bagul
2017-01-16 15:10 ` Pierre-Louis Bossart
2017-01-12 12:01 ` [PATCH v2 4/4] ASoC: Intel: bytcr_rt5640: Support line-out mute gpio Shrirang Bagul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VdeAZH9U=xnzva+vkTE_3jH7i7tRDQPmKcJ3TTdmj=J8A@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=shrirang.bagul@canonical.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).