* [PATCH] arm: dts: imx7ulp: fix reg of cpu node
@ 2019-12-18 12:03 Peng Fan
2019-12-18 12:07 ` Baruch Siach
0 siblings, 1 reply; 3+ messages in thread
From: Peng Fan @ 2019-12-18 12:03 UTC (permalink / raw)
To: robh+dt, mark.rutland, shawnguo, kernel, festevam
Cc: dl-linux-imx, Aisheng Dong, devicetree, linux-arm-kernel,
linux-kernel, Alice Guo, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
According to arm cpus binding doc,
"
On 32-bit ARM v7 or later systems this property is
required and matches the CPU MPIDR[23:0] register
bits.
Bits [23:0] in the reg cell must be set to
bits [23:0] in MPIDR.
All other bits in the reg cell must be set to 0.
"
In i.MX7ULP, the MPIDR[23:0] is 0xf00, not 0, so fix it.
Otherwise there will be warning:
"DT missing boot CPU MPIDR[23:0], fall back to default cpu_logical_map"
Fixes: 20434dc92c05 ("ARM: dts: imx: add common imx7ulp dtsi support")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
arch/arm/boot/dts/imx7ulp.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi
index d37a1927c88e..aa9e50178d6b 100644
--- a/arch/arm/boot/dts/imx7ulp.dtsi
+++ b/arch/arm/boot/dts/imx7ulp.dtsi
@@ -40,7 +40,7 @@
cpu0: cpu@0 {
compatible = "arm,cortex-a7";
device_type = "cpu";
- reg = <0>;
+ reg = <0xf00>;
};
};
--
2.16.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm: dts: imx7ulp: fix reg of cpu node
2019-12-18 12:03 [PATCH] arm: dts: imx7ulp: fix reg of cpu node Peng Fan
@ 2019-12-18 12:07 ` Baruch Siach
2019-12-18 12:10 ` Peng Fan
0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach @ 2019-12-18 12:07 UTC (permalink / raw)
To: linux-arm-kernel
Cc: robh+dt, mark.rutland, shawnguo, kernel, festevam, Aisheng Dong,
devicetree, Peng Fan, Alice Guo, linux-kernel, dl-linux-imx
Hi Peng,
On Wed, Dec 18 2019, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> According to arm cpus binding doc,
> "
> On 32-bit ARM v7 or later systems this property is
> required and matches the CPU MPIDR[23:0] register
> bits.
>
> Bits [23:0] in the reg cell must be set to
> bits [23:0] in MPIDR.
>
> All other bits in the reg cell must be set to 0.
> "
>
> In i.MX7ULP, the MPIDR[23:0] is 0xf00, not 0, so fix it.
> Otherwise there will be warning:
> "DT missing boot CPU MPIDR[23:0], fall back to default cpu_logical_map"
>
> Fixes: 20434dc92c05 ("ARM: dts: imx: add common imx7ulp dtsi support")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> arch/arm/boot/dts/imx7ulp.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi
> index d37a1927c88e..aa9e50178d6b 100644
> --- a/arch/arm/boot/dts/imx7ulp.dtsi
> +++ b/arch/arm/boot/dts/imx7ulp.dtsi
> @@ -40,7 +40,7 @@
> cpu0: cpu@0 {
The address suffix in the node name should update to match 'reg'.
> compatible = "arm,cortex-a7";
> device_type = "cpu";
> - reg = <0>;
> + reg = <0xf00>;
> };
> };
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] arm: dts: imx7ulp: fix reg of cpu node
2019-12-18 12:07 ` Baruch Siach
@ 2019-12-18 12:10 ` Peng Fan
0 siblings, 0 replies; 3+ messages in thread
From: Peng Fan @ 2019-12-18 12:10 UTC (permalink / raw)
To: Baruch Siach, linux-arm-kernel
Cc: robh+dt, mark.rutland, shawnguo, kernel, festevam, Aisheng Dong,
devicetree, Alice Guo, linux-kernel, dl-linux-imx
> Subject: Re: [PATCH] arm: dts: imx7ulp: fix reg of cpu node
>
> Hi Peng,
>
> On Wed, Dec 18 2019, Peng Fan wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > According to arm cpus binding doc,
> > "
> > On 32-bit ARM v7 or later systems this property is
> > required and matches the CPU MPIDR[23:0] register
> > bits.
> >
> > Bits [23:0] in the reg cell must be set to
> > bits [23:0] in MPIDR.
> >
> > All other bits in the reg cell must be set to 0.
> > "
> >
> > In i.MX7ULP, the MPIDR[23:0] is 0xf00, not 0, so fix it.
> > Otherwise there will be warning:
> > "DT missing boot CPU MPIDR[23:0], fall back to default cpu_logical_map"
> >
> > Fixes: 20434dc92c05 ("ARM: dts: imx: add common imx7ulp dtsi support")
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > arch/arm/boot/dts/imx7ulp.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/imx7ulp.dtsi
> > b/arch/arm/boot/dts/imx7ulp.dtsi index d37a1927c88e..aa9e50178d6b
> > 100644
> > --- a/arch/arm/boot/dts/imx7ulp.dtsi
> > +++ b/arch/arm/boot/dts/imx7ulp.dtsi
> > @@ -40,7 +40,7 @@
> > cpu0: cpu@0 {
>
> The address suffix in the node name should update to match 'reg'.
Yes, indeed, I will change to "cpu0: cpu@f00".
Thanks,
Peng.
>
> > compatible = "arm,cortex-a7";
> > device_type = "cpu";
> > - reg = <0>;
> > + reg = <0xf00>;
> > };
> > };
>
> baruch
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-18 12:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-18 12:03 [PATCH] arm: dts: imx7ulp: fix reg of cpu node Peng Fan
2019-12-18 12:07 ` Baruch Siach
2019-12-18 12:10 ` Peng Fan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).