* re: irqchip: Add IMX MU MSI controller driver
@ 2022-10-04 19:37 Colin King (gmail)
2022-10-04 19:44 ` Marc Zyngier
0 siblings, 1 reply; 3+ messages in thread
From: Colin King (gmail) @ 2022-10-04 19:37 UTC (permalink / raw)
To: Frank Li, Marc Zyngier
Cc: Thomas Gleixner, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
linux-kernel
Hi,
Static analysis with clang scan-build detected an issue with the
following commit in linux-next:
commit 70afdab904d2d1e68bffe75fe08e7e48e0b0ff8e
Author: Frank Li <Frank.Li@nxp.com>
Date: Thu Sep 22 11:12:43 2022 -0500
irqchip: Add IMX MU MSI controller driver
The issue is as follows in source drivers/irqchip/irq-imx-mu-msi.c :
static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp = {
.type = IMX_MU_V2,
.xTR = 0x200,
.xRR = 0x280,
.xSR = {
[IMX_MU_SR] = 0xC,
[IMX_MU_GSR] = 0x118,
[IMX_MU_GSR] = 0x124, /* <--- issue here */
[IMX_MU_RSR] = 0x12C,
},
.xCR = {
[IMX_MU_GIER] = 0x110,
[IMX_MU_GCR] = 0x114,
[IMX_MU_TCR] = 0x120,
[IMX_MU_RCR] = 0x128
},
};
The .xSR object with index IMX_MU_GSR is being set twice, once with
0x118 and again with 0x128. I believe the first one should be IMX_MU_TSR
but w/o the datasheet I don't want to make any assumptions.
Colin
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: irqchip: Add IMX MU MSI controller driver
2022-10-04 19:37 irqchip: Add IMX MU MSI controller driver Colin King (gmail)
@ 2022-10-04 19:44 ` Marc Zyngier
2022-10-04 19:49 ` [EXT] " Frank Li
0 siblings, 1 reply; 3+ messages in thread
From: Marc Zyngier @ 2022-10-04 19:44 UTC (permalink / raw)
To: Colin King (gmail), Frank Li
Cc: Thomas Gleixner, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
linux-kernel
On Tue, 04 Oct 2022 20:37:46 +0100,
"Colin King (gmail)" <colin.i.king@gmail.com> wrote:
>
> Hi,
>
> Static analysis with clang scan-build detected an issue with the
> following commit in linux-next:
>
> commit 70afdab904d2d1e68bffe75fe08e7e48e0b0ff8e
> Author: Frank Li <Frank.Li@nxp.com>
> Date: Thu Sep 22 11:12:43 2022 -0500
>
> irqchip: Add IMX MU MSI controller driver
>
> The issue is as follows in source drivers/irqchip/irq-imx-mu-msi.c :
>
>
> static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp = {
> .type = IMX_MU_V2,
> .xTR = 0x200,
> .xRR = 0x280,
> .xSR = {
> [IMX_MU_SR] = 0xC,
> [IMX_MU_GSR] = 0x118,
> [IMX_MU_GSR] = 0x124, /* <--- issue here */
> [IMX_MU_RSR] = 0x12C,
> },
> .xCR = {
> [IMX_MU_GIER] = 0x110,
> [IMX_MU_GCR] = 0x114,
> [IMX_MU_TCR] = 0x120,
> [IMX_MU_RCR] = 0x128
> },
> };
>
> The .xSR object with index IMX_MU_GSR is being set twice, once with
> 0x118 and again with 0x128. I believe the first one should be
> IMX_MU_TSR but w/o the datasheet I don't want to make any assumptions.
Huh, nice catch.
Frank, can you please provide a fix for this ASAP?
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [EXT] Re: irqchip: Add IMX MU MSI controller driver
2022-10-04 19:44 ` Marc Zyngier
@ 2022-10-04 19:49 ` Frank Li
0 siblings, 0 replies; 3+ messages in thread
From: Frank Li @ 2022-10-04 19:49 UTC (permalink / raw)
To: Marc Zyngier, Colin King (gmail)
Cc: Thomas Gleixner, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, dl-linux-imx,
linux-kernel
> -----Original Message-----
> From: Marc Zyngier <maz@kernel.org>
> Sent: Tuesday, October 4, 2022 2:44 PM
> To: Colin King (gmail) <colin.i.king@gmail.com>; Frank Li <frank.li@nxp.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>; Shawn Guo
> <shawnguo@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>;
> Pengutronix Kernel Team <kernel@pengutronix.de>; Fabio Estevam
> <festevam@gmail.com>; dl-linux-imx <linux-imx@nxp.com>; linux-
> kernel@vger.kernel.org
> Subject: [EXT] Re: irqchip: Add IMX MU MSI controller driver
>
> Caution: EXT Email
>
> On Tue, 04 Oct 2022 20:37:46 +0100,
> "Colin King (gmail)" <colin.i.king@gmail.com> wrote:
> >
> > Hi,
> >
> > Static analysis with clang scan-build detected an issue with the
> > following commit in linux-next:
> >
> > commit 70afdab904d2d1e68bffe75fe08e7e48e0b0ff8e
> > Author: Frank Li <Frank.Li@nxp.com>
> > Date: Thu Sep 22 11:12:43 2022 -0500
> >
> > irqchip: Add IMX MU MSI controller driver
> >
> > The issue is as follows in source drivers/irqchip/irq-imx-mu-msi.c :
> >
> >
> > static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp = {
> > .type = IMX_MU_V2,
> > .xTR = 0x200,
> > .xRR = 0x280,
> > .xSR = {
> > [IMX_MU_SR] = 0xC,
> > [IMX_MU_GSR] = 0x118,
> > [IMX_MU_GSR] = 0x124, /* <--- issue here */
> > [IMX_MU_RSR] = 0x12C,
> > },
> > .xCR = {
> > [IMX_MU_GIER] = 0x110,
> > [IMX_MU_GCR] = 0x114,
> > [IMX_MU_TCR] = 0x120,
> > [IMX_MU_RCR] = 0x128
> > },
> > };
> >
> > The .xSR object with index IMX_MU_GSR is being set twice, once with
> > 0x118 and again with 0x128. I believe the first one should be
> > IMX_MU_TSR but w/o the datasheet I don't want to make any assumptions.
>
> Huh, nice catch.
>
> Frank, can you please provide a fix for this ASAP?
[Frank Li] Okay, will fix today.
>
> Thanks,
>
> M.
>
> --
> Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-04 19:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-04 19:37 irqchip: Add IMX MU MSI controller driver Colin King (gmail)
2022-10-04 19:44 ` Marc Zyngier
2022-10-04 19:49 ` [EXT] " Frank Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).