linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: 黄学森 <hxseverything@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	David Miller <davem@davemloft.net>, bpf <bpf@vger.kernel.org>,
	Network Development <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Willem de Bruijn <willemb@google.com>,
	chengzhiyong <chengzhiyong@kuaishou.com>,
	wangli <wangli09@kuaishou.com>,
	Alan Maguire <alan.maguire@oracle.com>
Subject: Re: [PATCH/v2] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH
Date: Fri, 19 Feb 2021 00:35:44 +0800	[thread overview]
Message-ID: <B016D7B9-A347-4105-AA03-33713FDD2427@gmail.com> (raw)
In-Reply-To: <29b5395f-daff-99f2-4a4b-6d462623a9fe@iogearbox.net>

Thanks Daniel and Willem!

So sorry to reply to you late for I just took the Chinese Spring Festival vacation.

I will resubmit this patch.

Thanks again!

> 2021年2月11日 下午11:26，Daniel Borkmann <daniel@iogearbox.net> 写道：
> 
> On 2/10/21 3:50 PM, Willem de Bruijn wrote:
>> On Wed, Feb 10, 2021 at 1:59 AM huangxuesen <hxseverything@gmail.com> wrote:
>>> 
>>> From: huangxuesen <huangxuesen@kuaishou.com>
>>> 
>>> bpf_skb_adjust_room sets the inner_protocol as skb->protocol for packets
>>> encapsulation. But that is not appropriate when pushing Ethernet header.
>>> 
>>> Add an option to further specify encap L2 type and set the inner_protocol
>>> as ETH_P_TEB.
>>> 
>>> Suggested-by: Willem de Bruijn <willemb@google.com>
>>> Signed-off-by: huangxuesen <huangxuesen@kuaishou.com>
>>> Signed-off-by: chengzhiyong <chengzhiyong@kuaishou.com>
>>> Signed-off-by: wangli <wangli09@kuaishou.com>
>> Thanks, this is exactly what I meant.
>> Acked-by: Willem de Bruijn <willemb@google.com>
>> One small point regarding Signed-off-by: It is customary to capitalize
>> family and given names.
> 
> +1, huangxuesen, would be great if you could resubmit with capitalized names in
> your SoB as well as From (both seem affected).
> 
> Thanks,
> Daniel


  reply	other threads:[~2021-02-18 18:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10  6:59 [PATCH/v2] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH huangxuesen
2021-02-10 14:50 ` Willem de Bruijn
2021-02-11 15:26   ` Daniel Borkmann
2021-02-18 16:35     ` 黄学森 [this message]
2021-02-18 16:39 Xuesen Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B016D7B9-A347-4105-AA03-33713FDD2427@gmail.com \
    --to=hxseverything@gmail.com \
    --cc=alan.maguire@oracle.com \
    --cc=bpf@vger.kernel.org \
    --cc=chengzhiyong@kuaishou.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=wangli09@kuaishou.com \
    --cc=willemb@google.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).