From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: huangxuesen <hxseverything@gmail.com>
Cc: David Miller <davem@davemloft.net>, bpf <bpf@vger.kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Network Development <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
huangxuesen <huangxuesen@kuaishou.com>,
Willem de Bruijn <willemb@google.com>,
chengzhiyong <chengzhiyong@kuaishou.com>,
wangli <wangli09@kuaishou.com>,
Alan Maguire <alan.maguire@oracle.com>
Subject: Re: [PATCH/v2] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH
Date: Wed, 10 Feb 2021 09:50:43 -0500 [thread overview]
Message-ID: <CAF=yD-LLzAheej1upLdBOeJc9d0RUXMrL9f9+QVC-4thj1EG5Q@mail.gmail.com> (raw)
In-Reply-To: <20210210065925.22614-1-hxseverything@gmail.com>
On Wed, Feb 10, 2021 at 1:59 AM huangxuesen <hxseverything@gmail.com> wrote:
>
> From: huangxuesen <huangxuesen@kuaishou.com>
>
> bpf_skb_adjust_room sets the inner_protocol as skb->protocol for packets
> encapsulation. But that is not appropriate when pushing Ethernet header.
>
> Add an option to further specify encap L2 type and set the inner_protocol
> as ETH_P_TEB.
>
> Suggested-by: Willem de Bruijn <willemb@google.com>
> Signed-off-by: huangxuesen <huangxuesen@kuaishou.com>
> Signed-off-by: chengzhiyong <chengzhiyong@kuaishou.com>
> Signed-off-by: wangli <wangli09@kuaishou.com>
Thanks, this is exactly what I meant.
Acked-by: Willem de Bruijn <willemb@google.com>
One small point regarding Signed-off-by: It is customary to capitalize
family and given names.
next prev parent reply other threads:[~2021-02-10 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 6:59 [PATCH/v2] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH huangxuesen
2021-02-10 14:50 ` Willem de Bruijn [this message]
2021-02-11 15:26 ` Daniel Borkmann
2021-02-18 16:35 ` 黄学森
2021-02-18 16:39 Xuesen Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF=yD-LLzAheej1upLdBOeJc9d0RUXMrL9f9+QVC-4thj1EG5Q@mail.gmail.com' \
--to=willemdebruijn.kernel@gmail.com \
--cc=alan.maguire@oracle.com \
--cc=bpf@vger.kernel.org \
--cc=chengzhiyong@kuaishou.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=huangxuesen@kuaishou.com \
--cc=hxseverything@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wangli09@kuaishou.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).