* [PATCH] ARM: at91: sama5/dts: move hsmc_clk out of nfc node
@ 2016-02-17 5:42 Wenyou Yang
2016-02-22 12:58 ` Nicolas Ferre
0 siblings, 1 reply; 3+ messages in thread
From: Wenyou Yang @ 2016-02-17 5:42 UTC (permalink / raw)
To: Rob Herring, Pawel Moll, Mark Brown, Ian Campbell, Kumar Gala,
Nicolas Ferre, Alexandre Belloni,
Jean-Christophe Plagniol-Villard, Russell King
Cc: linux-arm-kernel, linux-kernel, devicetree, Josh Wu, Josh Wu,
Wenyou Yang
From: Josh Wu <josh.wu@atmel.com>
In sama5d3, sama5d4 chips, pmecc will use the hsmc clock. As pmecc is
part of HSMC. So move out hsmc_clk from nfc node to nand node.
Signed-off-by: Josh Wu <rainyfeeling@outlook.com>
Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
---
arch/arm/boot/dts/sama5d3.dtsi | 2 +-
arch/arm/boot/dts/sama5d4.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
index a532791..a242d27 100644
--- a/arch/arm/boot/dts/sama5d3.dtsi
+++ b/arch/arm/boot/dts/sama5d3.dtsi
@@ -1474,6 +1474,7 @@
atmel,nand-has-dma;
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_nand0_ale_cle>;
+ clocks = <&hsmc_clk>;
atmel,pmecc-lookup-table-offset = <0x0 0x8000>;
status = "disabled";
@@ -1486,7 +1487,6 @@
0xffffc000 0x00000070 /* NFC HSMC regs */
0x00200000 0x00100000 /* NFC SRAM banks */
>;
- clocks = <&hsmc_clk>;
};
};
};
diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
index b8032bc..1499b33 100644
--- a/arch/arm/boot/dts/sama5d4.dtsi
+++ b/arch/arm/boot/dts/sama5d4.dtsi
@@ -295,6 +295,7 @@
atmel,nand-has-dma;
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_nand>;
+ clocks = <&hsmc_clk>;
status = "disabled";
nfc@90000000 {
@@ -306,7 +307,6 @@
0xfc05c000 0x00000070 /* NFC HSMC regs */
0x00100000 0x00100000 /* NFC SRAM banks */
>;
- clocks = <&hsmc_clk>;
atmel,write-by-sram;
};
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: at91: sama5/dts: move hsmc_clk out of nfc node
2016-02-17 5:42 [PATCH] ARM: at91: sama5/dts: move hsmc_clk out of nfc node Wenyou Yang
@ 2016-02-22 12:58 ` Nicolas Ferre
2016-02-23 6:02 ` Yang, Wenyou
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Ferre @ 2016-02-22 12:58 UTC (permalink / raw)
To: Wenyou Yang, Rob Herring, Pawel Moll, Mark Brown, Ian Campbell,
Kumar Gala, Alexandre Belloni, Jean-Christophe Plagniol-Villard,
Russell King
Cc: linux-arm-kernel, linux-kernel, devicetree, Josh Wu, Josh Wu,
Alexandre Belloni
Le 17/02/2016 06:42, Wenyou Yang a écrit :
> From: Josh Wu <josh.wu@atmel.com>
>
> In sama5d3, sama5d4 chips, pmecc will use the hsmc clock. As pmecc is
> part of HSMC. So move out hsmc_clk from nfc node to nand node.
>
> Signed-off-by: Josh Wu <rainyfeeling@outlook.com>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
I'm not against this change, but beware, it must be applied in
synchronization with the patch just posted "[PATCH] mtd: atmel_nand:
move the hsmc_clk from nfc node to nand node"
Bye,
> ---
>
> arch/arm/boot/dts/sama5d3.dtsi | 2 +-
> arch/arm/boot/dts/sama5d4.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
> index a532791..a242d27 100644
> --- a/arch/arm/boot/dts/sama5d3.dtsi
> +++ b/arch/arm/boot/dts/sama5d3.dtsi
> @@ -1474,6 +1474,7 @@
> atmel,nand-has-dma;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_nand0_ale_cle>;
> + clocks = <&hsmc_clk>;
> atmel,pmecc-lookup-table-offset = <0x0 0x8000>;
> status = "disabled";
>
> @@ -1486,7 +1487,6 @@
> 0xffffc000 0x00000070 /* NFC HSMC regs */
> 0x00200000 0x00100000 /* NFC SRAM banks */
> >;
> - clocks = <&hsmc_clk>;
> };
> };
> };
> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
> index b8032bc..1499b33 100644
> --- a/arch/arm/boot/dts/sama5d4.dtsi
> +++ b/arch/arm/boot/dts/sama5d4.dtsi
> @@ -295,6 +295,7 @@
> atmel,nand-has-dma;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_nand>;
> + clocks = <&hsmc_clk>;
> status = "disabled";
>
> nfc@90000000 {
> @@ -306,7 +307,6 @@
> 0xfc05c000 0x00000070 /* NFC HSMC regs */
> 0x00100000 0x00100000 /* NFC SRAM banks */
> >;
> - clocks = <&hsmc_clk>;
> atmel,write-by-sram;
> };
> };
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] ARM: at91: sama5/dts: move hsmc_clk out of nfc node
2016-02-22 12:58 ` Nicolas Ferre
@ 2016-02-23 6:02 ` Yang, Wenyou
0 siblings, 0 replies; 3+ messages in thread
From: Yang, Wenyou @ 2016-02-23 6:02 UTC (permalink / raw)
To: Ferre, Nicolas, Rob Herring, Pawel Moll, Mark Brown,
Ian Campbell, Kumar Gala, Alexandre Belloni,
Jean-Christophe Plagniol-Villard, Russell King
Cc: linux-arm-kernel, linux-kernel, devicetree, Wu, Josh, Josh Wu,
Alexandre Belloni
> -----Original Message-----
> From: Ferre, Nicolas
> Sent: 2016年2月22日 20:58
> To: Yang, Wenyou <Wenyou.Yang@atmel.com>; Rob Herring
> <robh+dt@kernel.org>; Pawel Moll <pawel.moll@arm.com>; Mark Brown
> <broonie@kernel.org>; Ian Campbell <ijc+devicetree@hellion.org.uk>; Kumar
> Gala <galak@codeaurora.org>; Alexandre Belloni <alexandre.belloni@free-
> electrons.com>; Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>;
> Russell King <linux@arm.linux.org.uk>
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org; Wu, Josh <Josh.wu@atmel.com>; Josh Wu
> <rainyfeeling@outlook.com>; Alexandre Belloni <alexandre.belloni@free-
> electrons.com>
> Subject: Re: [PATCH] ARM: at91: sama5/dts: move hsmc_clk out of nfc node
>
> Le 17/02/2016 06:42, Wenyou Yang a écrit :
> > From: Josh Wu <josh.wu@atmel.com>
> >
> > In sama5d3, sama5d4 chips, pmecc will use the hsmc clock. As pmecc is
> > part of HSMC. So move out hsmc_clk from nfc node to nand node.
> >
> > Signed-off-by: Josh Wu <rainyfeeling@outlook.com>
> > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
>
> I'm not against this change, but beware, it must be applied in synchronization with
> the patch just posted "[PATCH] mtd: atmel_nand:
> move the hsmc_clk from nfc node to nand node"
Okay, revert the mail address to the original one, keep it consistent.
And add this address to CC.
>
> Bye,
>
>
> > ---
> >
> > arch/arm/boot/dts/sama5d3.dtsi | 2 +-
> > arch/arm/boot/dts/sama5d4.dtsi | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/sama5d3.dtsi
> > b/arch/arm/boot/dts/sama5d3.dtsi index a532791..a242d27 100644
> > --- a/arch/arm/boot/dts/sama5d3.dtsi
> > +++ b/arch/arm/boot/dts/sama5d3.dtsi
> > @@ -1474,6 +1474,7 @@
> > atmel,nand-has-dma;
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_nand0_ale_cle>;
> > + clocks = <&hsmc_clk>;
> > atmel,pmecc-lookup-table-offset = <0x0 0x8000>;
> > status = "disabled";
> >
> > @@ -1486,7 +1487,6 @@
> > 0xffffc000 0x00000070 /* NFC HSMC
> regs */
> > 0x00200000 0x00100000 /* NFC
> SRAM banks */
> > >;
> > - clocks = <&hsmc_clk>;
> > };
> > };
> > };
> > diff --git a/arch/arm/boot/dts/sama5d4.dtsi
> > b/arch/arm/boot/dts/sama5d4.dtsi index b8032bc..1499b33 100644
> > --- a/arch/arm/boot/dts/sama5d4.dtsi
> > +++ b/arch/arm/boot/dts/sama5d4.dtsi
> > @@ -295,6 +295,7 @@
> > atmel,nand-has-dma;
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_nand>;
> > + clocks = <&hsmc_clk>;
> > status = "disabled";
> >
> > nfc@90000000 {
> > @@ -306,7 +307,6 @@
> > 0xfc05c000 0x00000070 /* NFC
> HSMC regs */
> > 0x00100000 0x00100000 /* NFC
> SRAM banks */
> > >;
> > - clocks = <&hsmc_clk>;
> > atmel,write-by-sram;
> > };
> > };
> >
>
>
> --
> Nicolas Ferre
Best Regards,
Wenyou Yang
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-23 6:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-17 5:42 [PATCH] ARM: at91: sama5/dts: move hsmc_clk out of nfc node Wenyou Yang
2016-02-22 12:58 ` Nicolas Ferre
2016-02-23 6:02 ` Yang, Wenyou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).