From: "Chintakuntla, Radha" <Radha.Chintakuntla@cavium.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Scot Doyle <lkml14@scotdoyle.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jeremy Kerr <jk@ozlabs.org>, Ming Lei <ming.lei@canonical.com>,
"Daney, David" <David.Daney@cavium.com>,
Dann Frazier <dann.frazier@canonical.com>,
Peter Hurley <peter@hurleysoftware.com>,
Pavel Machek <pavel@ucw.cz>, Jonathan Liu <net147@gmail.com>,
Alistair Popple <alistair@popple.id.au>,
Jean-Philippe Brucker <jean-philippe.brucker@arm.com>,
Jiri Slaby <jslaby@suse.com>, David Airlie <airlied@linux.ie>,
David Daney <ddaney.cavm@gmail.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>,
"Chintakuntla, Radha" <Radha.Chintakuntla@cavium.com>
Subject: RE: [PATCH] fbcon: warn on invalid cursor blink intervals
Date: Sun, 12 Jun 2016 05:05:27 +0000 [thread overview]
Message-ID: <BLUPR0701MB1620B3F8C64E2CF5723B8FDCF0520@BLUPR0701MB1620.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20160528114846.GC13329@khazad-dum.debian.net>
> -----Original Message-----
> From: Henrique de Moraes Holschuh [mailto:hmh@hmh.eng.br]
> Sent: Saturday, May 28, 2016 4:49 AM
> To: Scot Doyle <lkml14@scotdoyle.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>; Jean-Christophe Plagniol-
> Villard <plagnioj@jcrosoft.com>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>; Jeremy Kerr <jk@ozlabs.org>; Ming Lei
> <ming.lei@canonical.com>; Daney, David <David.Daney@cavium.com>;
> Dann Frazier <dann.frazier@canonical.com>; Peter Hurley
> <peter@hurleysoftware.com>; Pavel Machek <pavel@ucw.cz>; Jonathan Liu
> <net147@gmail.com>; Alistair Popple <alistair@popple.id.au>; Jean-Philippe
> Brucker <jean-philippe.brucker@arm.com>; Chintakuntla, Radha
> <Radha.Chintakuntla@cavium.com>; Jiri Slaby <jslaby@suse.com>; David
> Airlie <airlied@linux.ie>; David Daney <ddaney.cavm@gmail.com>; dri-
> devel@lists.freedesktop.org; linux-fbdev@vger.kernel.org; Linux Kernel
> Mailing List <linux-kernel@vger.kernel.org>; stable
> <stable@vger.kernel.org>
> Subject: Re: [PATCH] fbcon: warn on invalid cursor blink intervals
>
> On Fri, 20 May 2016, Scot Doyle wrote:
> > On Fri, 20 May 2016, Jeremy Kerr wrote:
> > > >Then looks there are two fix patches acked & tested:
> > > >
> > > > - the patch in this thread
> > > > - another one "[PATCH] tty: vt: Fix soft lockup in fbcon cursor
> > > >blink timer."
> > > > https://lkml.org/lkml/2016/5/17/455
> > > >
> > > >So which one will be pushed to linus?
> > >
> > > Not that it's my call, but we may want both; the first as a safety
> > > measure to prevent an invalid cur_blink_jiffies ever being set, and the
> > > second one to actually fix the initialisation of vc_cur_blink_ms (and
> > > address the warning introduced by the first).
> >
> > Tomi / Greg,
> >
> > I'd suggest
> > - applying "tty: vt: Fix soft lockup in fbcon cursor blink timer." to 4.7 and
> stable[4.2]
> > - applying "fbcon: warn on invalid cursor blink intervals" to 4.7
> > - ignoring "fbcon: use default if cursor blink interval is not valid"
> >
> > Note: the patches don't depend on each other
>
> I applied both recommended patches on top of 4.4.11 for testing, and they
> made things a lot better here.
>
> I suggest the second patch should be backported to stable too, might as well
> fix this thing for good *and keep the door closed*.
Is this patch available on some tree so that I can point to ?
And hope it will make it to linux-next soon ?
>
> --
> "One disk to rule them all, One disk to find them. One disk to bring
> them all and in the darkness grind them. In the Land of Redmond
> where the shadows lie." -- The Silicon Valley Tarot
> Henrique Holschuh
next prev parent reply other threads:[~2016-06-12 5:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 18:41 [PATCH] tty: vt: Fix soft lockup in fbcon cursor blink timer David Daney
2016-05-17 20:49 ` Pavel Machek
2016-05-18 0:42 ` Ming Lei
2016-05-18 20:24 ` Scot Doyle
2016-05-18 20:38 ` David Daney
2016-05-19 4:21 ` [PATCH] fbcon: use default if cursor blink interval is not valid Scot Doyle
2016-05-19 7:25 ` Jeremy Kerr
2016-05-19 8:29 ` Ming Lei
2016-05-19 9:01 ` Pavel Machek
2016-05-19 14:22 ` Scot Doyle
2016-05-19 15:31 ` Ming Lei
2016-05-19 15:59 ` David Daney
2016-05-19 22:25 ` Scot Doyle
2016-05-19 22:31 ` [PATCH] fbcon: warn on invalid cursor blink intervals Scot Doyle
2016-05-19 22:50 ` David Daney
2016-05-20 1:21 ` Jeremy Kerr
2016-05-20 2:17 ` Ming Lei
2016-05-20 2:26 ` Jeremy Kerr
2016-05-20 2:48 ` Ming Lei
2016-05-20 5:04 ` Jeremy Kerr
2016-05-20 16:27 ` Scot Doyle
2016-05-24 1:19 ` Scot Doyle
2016-05-28 11:48 ` Henrique de Moraes Holschuh
2016-06-12 5:05 ` Chintakuntla, Radha [this message]
2016-05-28 11:45 ` Henrique de Moraes Holschuh
2016-05-19 0:27 ` [PATCH] tty: vt: Fix soft lockup in fbcon cursor blink timer Ming Lei
2016-05-19 7:08 ` Pavel Machek
2016-05-19 22:35 ` Scot Doyle
2016-05-28 11:44 ` Henrique de Moraes Holschuh
2016-06-14 16:22 ` Ping: " David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BLUPR0701MB1620B3F8C64E2CF5723B8FDCF0520@BLUPR0701MB1620.namprd07.prod.outlook.com \
--to=radha.chintakuntla@cavium.com \
--cc=David.Daney@cavium.com \
--cc=airlied@linux.ie \
--cc=alistair@popple.id.au \
--cc=dann.frazier@canonical.com \
--cc=ddaney.cavm@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hmh@hmh.eng.br \
--cc=jean-philippe.brucker@arm.com \
--cc=jk@ozlabs.org \
--cc=jslaby@suse.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml14@scotdoyle.com \
--cc=ming.lei@canonical.com \
--cc=net147@gmail.com \
--cc=pavel@ucw.cz \
--cc=peter@hurleysoftware.com \
--cc=plagnioj@jcrosoft.com \
--cc=stable@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).