From: "Zhang, Tianfei" <tianfei.zhang@intel.com>
To: Tom Rix <trix@redhat.com>, "Wu, Hao" <hao.wu@intel.com>,
"mdf@kernel.org" <mdf@kernel.org>,
"Xu, Yilun" <yilun.xu@intel.com>,
"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "corbet@lwn.net" <corbet@lwn.net>
Subject: RE: [PATCH v1 2/7] fpga: dfl: check feature type before parse irq info
Date: Mon, 21 Feb 2022 12:05:25 +0000 [thread overview]
Message-ID: <BN9PR11MB5483C46D41DC8CF5893F1832E33A9@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <447ce66b-dea7-da2b-6879-e4d37a74ba7d@redhat.com>
> -----Original Message-----
> From: Tom Rix <trix@redhat.com>
> Sent: Friday, February 18, 2022 10:30 PM
> To: Zhang, Tianfei <tianfei.zhang@intel.com>; Wu, Hao <hao.wu@intel.com>;
> mdf@kernel.org; Xu, Yilun <yilun.xu@intel.com>; linux-fpga@vger.kernel.org;
> linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: corbet@lwn.net
> Subject: Re: [PATCH v1 2/7] fpga: dfl: check feature type before parse irq info
>
>
> On 2/17/22 10:53 PM, Zhang, Tianfei wrote:
> >
> >> -----Original Message-----
> >> From: Tom Rix <trix@redhat.com>
> >> Sent: Tuesday, February 15, 2022 10:49 PM
> >> To: Zhang, Tianfei <tianfei.zhang@intel.com>; Wu, Hao
> >> <hao.wu@intel.com>; mdf@kernel.org; Xu, Yilun <yilun.xu@intel.com>;
> >> linux-fpga@vger.kernel.org; linux-doc@vger.kernel.org;
> >> linux-kernel@vger.kernel.org
> >> Cc: corbet@lwn.net
> >> Subject: Re: [PATCH v1 2/7] fpga: dfl: check feature type before
> >> parse irq info
> >>
> >>
> >> On 2/14/22 3:26 AM, Tianfei zhang wrote:
> >>> From: Tianfei Zhang <tianfei.zhang@intel.com>
> >>>
> >>> The feature ID of "Port User Interrupt" and the "PMCI Subsystem" are
> >>> identical, 0x12, but one is for FME, other is for Port. It should
> >>> check the feature type While parsing the irq info in
> >>> parse_feature_irqs().
> >> This seems like a bug fix and not part of iofs feature.
> >>
> >> Split this out of the patchset.
>
> ?
I agree, I will send this patch as a bug fix.
>
> >>
> >> This is a workaround a hardware problem, there should be some
> >> comments to the effect that you can't trust _this_ or _that_ feature
> >> id and some special handling earlier.
> >>
> >> The ambiguity of feature id is a problem, and this sort of bug will happen
> again.
> >>
> >> What can be done to prevent this in the future ?
> > This patch is not workaround, this is a bug fix for DFL driver.
> > The root cause is that DLF driver miss check the feature type while
> > parsing the interrupt information, because some Feature IDs are identical
> between FME and Port, like PMCI in FME and "Port User Interrupt"
> > in Port.
> > The definition of Feature ID is here:
> > https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl-feature-i
> > ds.rst
> Helpful but hidden. At least a link to this should be added to
> Documentation/fpga/dfl.rst.
> >>> Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> >>> ---
> >>> drivers/fpga/dfl.c | 11 +++++++++++
> >>> 1 file changed, 11 insertions(+)
> >>>
> >>> diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c index
> >>> 599bb21d86af..26f8cf890700 100644
> >>> --- a/drivers/fpga/dfl.c
> >>> +++ b/drivers/fpga/dfl.c
> >>> @@ -940,9 +940,14 @@ static int parse_feature_irqs(struct
> >> build_feature_devs_info *binfo,
> >>> {
> >>> void __iomem *base = binfo->ioaddr + ofst;
> >>> unsigned int i, ibase, inr = 0;
> >>> + enum dfl_id_type type;
> >>> int virq;
> >>> u64 v;
> >>>
> >>> + type = feature_dev_id_type(binfo->feature_dev);
> >>> + if (type >= DFL_ID_MAX)
> >>> + return -EINVAL;
> >>> +
> >>> /*
> >>> * Ideally DFL framework should only read info from DFL header, but
> >>> * current version DFL only provides mmio resources information
> >>> for @@ -959,16 +964,22 @@ static int parse_feature_irqs(struct
> >> build_feature_devs_info *binfo,
> >>> */
> >>> switch (fid) {
> >>> case PORT_FEATURE_ID_UINT:
> >>> + if (type != PORT_ID)
> >>> + break;
> >> Instead of embedding a break in the switch, break the switch into fme
> >> switch and port switch
> >>
> >> if (type == PORT_ID)
> >>
> >> port-switch
> >>
> >> else if (type == FME_ID
> >>
> >> fme-switch
> > Your suggestion is looks good for me, I will change on next version.
> >
> >> Tom
> >>
> >>> v = readq(base + PORT_UINT_CAP);
> >>> ibase = FIELD_GET(PORT_UINT_CAP_FST_VECT, v);
> >>> inr = FIELD_GET(PORT_UINT_CAP_INT_NUM, v);
> >>> break;
> >>> case PORT_FEATURE_ID_ERROR:
> >>> + if (type != PORT_ID)
> >>> + break;
> >>> v = readq(base + PORT_ERROR_CAP);
> >>> ibase = FIELD_GET(PORT_ERROR_CAP_INT_VECT, v);
> >>> inr = FIELD_GET(PORT_ERROR_CAP_SUPP_INT, v);
> >>> break;
> >>> case FME_FEATURE_ID_GLOBAL_ERR:
> >>> + if (type != FME_ID)
> >>> + break;
> >>> v = readq(base + FME_ERROR_CAP);
> >>> ibase = FIELD_GET(FME_ERROR_CAP_INT_VECT, v);
> >>> inr = FIELD_GET(FME_ERROR_CAP_SUPP_INT, v);
next prev parent reply other threads:[~2022-02-21 12:05 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 11:26 [PATCH v1 0/7] Add Intel OFS support for DFL driver Tianfei zhang
2022-02-14 11:26 ` [PATCH v1 1/7] Documentation: fpga: dfl: add description of IOFS Tianfei zhang
2022-02-14 12:18 ` Akira Yokosawa
2022-02-14 17:56 ` Randy Dunlap
2022-02-14 23:27 ` Zhang, Tianfei
2022-02-15 14:32 ` Tom Rix
2022-02-16 3:34 ` Wu, Hao
2022-02-21 7:39 ` Zhang, Tianfei
2022-02-14 11:26 ` [PATCH v1 2/7] fpga: dfl: check feature type before parse irq info Tianfei zhang
2022-02-15 14:49 ` Tom Rix
2022-02-17 2:38 ` Xu Yilun
2022-02-21 7:54 ` Zhang, Tianfei
2022-02-18 6:53 ` Zhang, Tianfei
2022-02-18 14:29 ` Tom Rix
2022-02-21 12:05 ` Zhang, Tianfei [this message]
2022-02-16 3:35 ` Wu, Hao
2022-02-21 7:41 ` Zhang, Tianfei
2022-02-14 11:26 ` [PATCH v1 3/7] fpga: dfl: Allow for ports with no local bar space Tianfei zhang
2022-02-15 15:05 ` Tom Rix
2022-02-18 7:31 ` Zhang, Tianfei
2022-02-18 14:49 ` Tom Rix
2022-02-21 17:22 ` matthew.gerlach
2022-02-21 17:51 ` Tom Rix
2022-02-22 9:07 ` Zhang, Tianfei
2022-02-16 3:38 ` Wu, Hao
2022-02-21 7:48 ` Zhang, Tianfei
2022-02-14 11:26 ` [PATCH v1 4/7] fpga: dfl: fix VF creation when ports have no local BAR space Tianfei zhang
2022-02-15 15:50 ` Tom Rix
2022-02-18 8:14 ` Zhang, Tianfei
2022-02-18 14:55 ` Tom Rix
2022-02-14 11:26 ` [PATCH v1 5/7] drivers: fpga: dfl: handle empty port list Tianfei zhang
2022-02-15 15:55 ` Tom Rix
2022-02-18 8:24 ` Zhang, Tianfei
2022-02-14 11:26 ` [PATCH v1 6/7] fpga: dfl: Handle dfl's starting with AFU Tianfei zhang
2022-02-15 16:09 ` Tom Rix
2022-02-14 11:26 ` [PATCH v1 7/7] fpga: dfl: pci: Add generic OFS PCI PID Tianfei zhang
2022-02-15 16:16 ` Tom Rix
2022-02-18 9:03 ` Zhang, Tianfei
2022-02-18 15:27 ` Tom Rix
2022-02-21 17:50 ` matthew.gerlach
2022-02-21 18:09 ` Tom Rix
2022-02-22 3:11 ` Zhang, Tianfei
2022-02-22 16:11 ` Tom Rix
2022-02-23 1:48 ` Zhang, Tianfei
2022-02-24 17:54 ` matthew.gerlach
2022-02-28 10:57 ` Wu, Hao
2022-03-01 0:25 ` matthew.gerlach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB5483C46D41DC8CF5893F1832E33A9@BN9PR11MB5483.namprd11.prod.outlook.com \
--to=tianfei.zhang@intel.com \
--cc=corbet@lwn.net \
--cc=hao.wu@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).