* [PATCH] drivers: bluetooth: hci_serdev: Removed unnecessary curly braces
@ 2018-05-14 21:38 Vaibhav Murkute
2018-05-22 7:25 ` Marcel Holtmann
0 siblings, 1 reply; 4+ messages in thread
From: Vaibhav Murkute @ 2018-05-14 21:38 UTC (permalink / raw)
To: marcel, johan.hedberg; +Cc: linux-bluetooth, linux-kernel, Vaibhav Murkute
checkpatch.pl shows a warning for these unnecessary curly braces.
so just removed those curly braces.
Signed-off-by: Vaibhav Murkute <vaibhavmurkute88@gmail.com>
---
drivers/bluetooth/hci_serdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/bluetooth/hci_serdev.c b/drivers/bluetooth/hci_serdev.c
index e0e6461..a0e9398 100644
--- a/drivers/bluetooth/hci_serdev.c
+++ b/drivers/bluetooth/hci_serdev.c
@@ -204,9 +204,8 @@ static int hci_uart_setup(struct hci_dev *hdev)
return 0;
}
- if (skb->len != sizeof(*ver)) {
+ if (skb->len != sizeof(*ver))
bt_dev_err(hdev, "Event length mismatch for version info");
- }
kfree_skb(skb);
return 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] drivers: bluetooth: hci_serdev: Removed unnecessary curly braces
@ 2018-05-11 22:12 Vaibhav Murkute
2018-05-13 22:49 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Vaibhav Murkute @ 2018-05-11 22:12 UTC (permalink / raw)
To: marcel, johan.hedberg; +Cc: linux-bluetooth, linux-kernel, Vaibhav Murkute
checkpatch.pl shows a warning for these unnecessary curly braces.
so just removed those curly braces.
Signed-off-by: Vaibhav Murkute <vaibhavmurkute88@gmail.com>
---
drivers/bluetooth/hci_serdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bluetooth/hci_serdev.c b/drivers/bluetooth/hci_serdev.c
index e0e6461..137c314 100644
--- a/drivers/bluetooth/hci_serdev.c
+++ b/drivers/bluetooth/hci_serdev.c
@@ -204,9 +204,9 @@ static int hci_uart_setup(struct hci_dev *hdev)
return 0;
}
- if (skb->len != sizeof(*ver)) {
+ if (skb->len != sizeof(*ver))
bt_dev_err(hdev, "Event length mismatch for version info");
- }
+
kfree_skb(skb);
return 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drivers: bluetooth: hci_serdev: Removed unnecessary curly braces
2018-05-11 22:12 Vaibhav Murkute
@ 2018-05-13 22:49 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2018-05-13 22:49 UTC (permalink / raw)
To: Vaibhav Murkute
Cc: Marcel Holtmann, Johan Hedberg, linux-bluetooth,
Linux Kernel Mailing List
On Sat, May 12, 2018 at 1:12 AM, Vaibhav Murkute
<vaibhavmurkute88@gmail.com> wrote:
> checkpatch.pl shows a warning for these unnecessary curly braces.
> so just removed those curly braces.
>
> Signed-off-by: Vaibhav Murkute <vaibhavmurkute88@gmail.com>
> ---
> drivers/bluetooth/hci_serdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bluetooth/hci_serdev.c b/drivers/bluetooth/hci_serdev.c
> index e0e6461..137c314 100644
> --- a/drivers/bluetooth/hci_serdev.c
> +++ b/drivers/bluetooth/hci_serdev.c
> @@ -204,9 +204,9 @@ static int hci_uart_setup(struct hci_dev *hdev)
> return 0;
> }
>
> - if (skb->len != sizeof(*ver)) {
> + if (skb->len != sizeof(*ver))
> bt_dev_err(hdev, "Event length mismatch for version info");
> - }
> +
>
> kfree_skb(skb);
> return 0;
Why did you add redundant empty line(s) instead?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-22 7:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-14 21:38 [PATCH] drivers: bluetooth: hci_serdev: Removed unnecessary curly braces Vaibhav Murkute
2018-05-22 7:25 ` Marcel Holtmann
-- strict thread matches above, loose matches on Subject: below --
2018-05-11 22:12 Vaibhav Murkute
2018-05-13 22:49 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).