From: Linus Torvalds <torvalds@linux-foundation.org>
To: Dave Airlie <airlied@linux.ie>
Cc: DRI mailing list <dri-devel@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] drm merge for 3.9-rc1
Date: Mon, 25 Feb 2013 17:22:58 -0800 [thread overview]
Message-ID: <CA+55aFxGfRpYAn8BqTV=akmsvmDbJoefb+UMMo6FB7M6RPa82A@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1302260003460.24684@skynet.skynet.ie>
On Mon, Feb 25, 2013 at 4:05 PM, Dave Airlie <airlied@linux.ie> wrote:
>
> So up front, this has a massive merge conflict in
> drivers/gpu/drm/radeon/evergreen_cs.c I've fixed it up in drm-next-merged
> in the same tree, I fixed up some small ordering issues in my merge as
> well, however they aren't important if you want the fun of doing a major
> conflict resolution.
I did the fun conflict resolution, so my tree doesn't have the ordering changes.
I also did some things slightly differently from you - you had left
some direct ib[] accesses that I spotted (see for example "case 0x48"
(aka "Copy L2T Frame to Field"), and yours apparently has a few cases
where you use "idx_value" instead of my mindless conflict resolution
that just re-did the brute-force "repace direct ib[] read accesses
with the radeon_get_ib_value() helper function". But you don't do it
for *all* the radeon_get_ib_value(p, idx+2) users, so whatever.
Anyway - my conflict resolution isn't exactly the same as yours, and
maybe I screwed something up. But it's damn close, and the differences
_seem_ be all be benign.
Btw, why is it ok that some functions still read the ib[] array
directly (eg evergreen_vm_packet3_check() or evergreen_cs_check_reg()
etc)?
Whatever. I prefer doing my own resolutions just so that I know what's
going on, and it all seems to build and looks reasonable, but it's
always good to get a second opinion. Particularly since I can't
actually test the radeon stuff, so just eyeballing it and saying
"looks semantically identical to Dave's resolution" may not be 100%
sufficient..
Linus
next prev parent reply other threads:[~2013-02-26 1:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 0:05 [git pull] drm merge for 3.9-rc1 Dave Airlie
2013-02-26 1:22 ` Linus Torvalds [this message]
2013-02-26 1:59 ` Dave Airlie
2013-02-27 1:39 ` Linus Torvalds
2013-02-27 2:25 ` Linus Torvalds
2013-02-27 3:30 ` Dave Airlie
2013-02-27 3:38 ` Linus Torvalds
2013-02-27 10:04 ` Chris Wilson
2013-03-03 15:39 ` Azat Khuzhin
2013-03-05 19:18 ` Daniel Vetter
2013-02-27 16:34 ` Josh Boyer
2013-02-27 20:20 ` Josh Boyer
2013-02-27 20:24 ` Josh Boyer
2013-02-28 0:01 ` Josh Boyer
2013-02-28 1:14 ` Josh Boyer
2013-02-28 13:38 ` Alex Deucher
2013-02-28 13:44 ` Josh Boyer
2013-02-28 15:09 ` Alex Deucher
2013-02-28 15:15 ` Josh Boyer
2013-02-28 18:59 ` Josh Boyer
2013-03-05 15:21 ` Josh Boyer
2013-03-05 15:48 ` Alex Deucher
2013-02-27 22:36 Sedat Dilek
2013-02-27 23:06 ` Sedat Dilek
2013-02-28 11:18 ` Chris Wilson
2013-02-28 17:07 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFxGfRpYAn8BqTV=akmsvmDbJoefb+UMMo6FB7M6RPa82A@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).