From: Alex Deucher <alexdeucher@gmail.com>
To: Josh Boyer <jwboyer@gmail.com>
Cc: Dave Airlie <airlied@linux.ie>,
Alex Deucher <alexander.deucher@amd.com>,
Jerome Glisse <jglisse@redhat.com>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
DRI mailing list <dri-devel@lists.freedesktop.org>
Subject: Re: [git pull] drm merge for 3.9-rc1
Date: Tue, 5 Mar 2013 10:48:48 -0500 [thread overview]
Message-ID: <CADnq5_OXKQP3-ra5d2k26cGcL-jtPbXOkN6eg5m2R8SaM6hmJg@mail.gmail.com> (raw)
In-Reply-To: <CA+5PVA40SFq1EprA9Y1U-eUdmYTzqDbxbTaC1Y1WSh7EwEEqfw@mail.gmail.com>
On Tue, Mar 5, 2013 at 10:21 AM, Josh Boyer <jwboyer@gmail.com> wrote:
> On Thu, Feb 28, 2013 at 1:59 PM, Josh Boyer <jwboyer@gmail.com> wrote:
>> On Thu, Feb 28, 2013 at 10:15 AM, Josh Boyer <jwboyer@gmail.com> wrote:
>>> On Thu, Feb 28, 2013 at 10:09 AM, Alex Deucher <alexdeucher@gmail.com> wrote:
>>>> On Thu, Feb 28, 2013 at 8:44 AM, Josh Boyer <jwboyer@gmail.com> wrote:
>>>>> On Thu, Feb 28, 2013 at 8:38 AM, Alex Deucher <alexdeucher@gmail.com> wrote:
>>>>>>>>>> ca57802e521de54341efc8a56f70571f79ffac72 is the first bad commit
>>>>>>>>>
>>>>>>>>> So I don't think that's actually the cause of the problem. Or at least
>>>>>>>>> not that alone. I reverted it on top of Linus' latest tree and I still
>>>>>>>>> get the lockups.
>>>>>>>>
>>>>>>>> Actually, git bisect does seem to have gotten it correct. Once I
>>>>>>>> actually tested the revert of just that on top of Linus' tree (commit
>>>>>>>> d895cb1af1), things seem to be working much better. I've rebooted a
>>>>>>>> dozen times without a lockup. The most I've seen it take on a kernel
>>>>>>>> with that commit included is 3 reboots, so that's definitely at least an
>>>>>>>> improvement.
>>>>>>>
>>>>>>> I give up. GPU issues are not my thing. 2 reboots after I sent that it
>>>>>>> gave me pretty rainbow static again. So it might have been an
>>>>>>> improvement, but revert it is not a solution.
>>>>>>>
>>>>>>> Looking at there rest of the commits, the whole GPU rework might be
>>>>>>> suspect, but I clearly have no clue.
>>>>>>
>>>>>> GPUs are tricky beasts :)
>>>>>
>>>>> Understatement ;).
>>>>>
>>>>>> ca57802e521de54341efc8a56f70571f79ffac72 mostly likely wasn't the
>>>>>> problem anyway since it only affects 6xx/7xx and your card is handled
>>>>>> by the evergreen code. I'll put together some patches to help narrow
>>>>>> down the problem.
>>>>>
>>>>> Yeah, that's the biggest problem I have, not knowing which functions are
>>>>> actually being executed for this card. It looks like a combination of
>>>>> stuff in evergreen.c and ni.c, but I have no idea.
>>>>>
>>>>> Patches would be great. If nothing else, I'm really good at building
>>>>> kernels and rebooting by now.
>>>>
>>>> Two possible fixes attached. The first attempts a full reset of all
>>>> blocks if the MC (memory controller) is hung. That may work better
>>>> than just resetting the MC. The second just disables MC reset. I'm
>>>> not sure we can reliably tell if it's busy due to display requests
>>>> hitting the MC periodically which would lead to needlessly resetting
>>>> it possibly leading to failures like you are seeing.
>>>
>>> OK. I'll test them individually. It will probably take a bit because
>>> I'll want to do numerous reboots if things seem "fixed" with one or the
>>> other.
>>>
>>> I'll let you know how things go.
>>
>> I applied each individually on top of Linus' tree as of this morning
>> (commit 2a7d2b96d5) built, installed, and tested.
>>
>> 0001-drm-radeon-XXX-try-a-full-reset-if-the-MC-is-busy.patch failed in
>> two reboots.
>>
>> 0001-drm-radeon-XXX-skip-MC-reset-as-it-s-probably-not-hu.patch has gone
>> 21 reboots without a hang/rainbow static. You'll understand if I'm
>> hesitant to declare success, but resetting the MC does indeed appear to
>> be the issue. I'll keep rebooting for a while to make sure.
>
> OK, I'm still running on the kernel with that patch and things still
> work. The only other "issue" I'm seeing at the moment is my dmesg is
> full of:
>
> [349316.595749] radeon 0000:01:00.0: MC busy: 0x00000409, clearing.
> [349436.654946] radeon 0000:01:00.0: MC busy: 0x00000409, clearing.
> [349436.655997] radeon 0000:01:00.0: MC busy: 0x00000409, clearing.
> [349496.698441] radeon 0000:01:00.0: MC busy: 0x00000409, clearing.
> [349556.726767] radeon 0000:01:00.0: MC busy: 0x00000409, clearing.
> [349556.727797] radeon 0000:01:00.0: MC busy: 0x00000409, clearing.
>
I'll make those debug only when the patch goes upstream.
> So hopefully your patch is on the way into Linus' tree at some point
> soon.
It'll be in my next -fixes pull.
Alex
next prev parent reply other threads:[~2013-03-05 15:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 0:05 [git pull] drm merge for 3.9-rc1 Dave Airlie
2013-02-26 1:22 ` Linus Torvalds
2013-02-26 1:59 ` Dave Airlie
2013-02-27 1:39 ` Linus Torvalds
2013-02-27 2:25 ` Linus Torvalds
2013-02-27 3:30 ` Dave Airlie
2013-02-27 3:38 ` Linus Torvalds
2013-02-27 10:04 ` Chris Wilson
2013-03-03 15:39 ` Azat Khuzhin
2013-03-05 19:18 ` Daniel Vetter
2013-02-27 16:34 ` Josh Boyer
2013-02-27 20:20 ` Josh Boyer
2013-02-27 20:24 ` Josh Boyer
2013-02-28 0:01 ` Josh Boyer
2013-02-28 1:14 ` Josh Boyer
2013-02-28 13:38 ` Alex Deucher
2013-02-28 13:44 ` Josh Boyer
2013-02-28 15:09 ` Alex Deucher
2013-02-28 15:15 ` Josh Boyer
2013-02-28 18:59 ` Josh Boyer
2013-03-05 15:21 ` Josh Boyer
2013-03-05 15:48 ` Alex Deucher [this message]
2013-02-27 22:36 Sedat Dilek
2013-02-27 23:06 ` Sedat Dilek
2013-02-28 11:18 ` Chris Wilson
2013-02-28 17:07 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_OXKQP3-ra5d2k26cGcL-jtPbXOkN6eg5m2R8SaM6hmJg@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jglisse@redhat.com \
--cc=jwboyer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).