* [PATCH] staging: st-cec: add parentheses around complex macros
@ 2016-11-04 7:58 Maninder Singh
2016-11-04 9:00 ` Benjamin Gaignard
0 siblings, 1 reply; 2+ messages in thread
From: Maninder Singh @ 2016-11-04 7:58 UTC (permalink / raw)
To: Benjamin Gaignard, Mauro Carvalho Chehab, Greg Kroah-Hartman
Cc: kernel, linux-media, devel, Ravikant Bijendra Sharma,
Maninder Singh, linux-kernel
This patch fixes the following checkpatch.pl error:
ERROR: Macros with complex values should be enclosed in parentheses
Signed-off-by: Maninder Singh <maninder.s2@samsung.com>
---
drivers/staging/media/st-cec/stih-cec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/st-cec/stih-cec.c b/drivers/staging/media/st-cec/stih-cec.c
index 2143448..b22394a 100644
--- a/drivers/staging/media/st-cec/stih-cec.c
+++ b/drivers/staging/media/st-cec/stih-cec.c
@@ -108,11 +108,11 @@
/* Constants for CEC_BIT_TOUT_THRESH register */
#define CEC_SBIT_TOUT_47MS BIT(1)
-#define CEC_SBIT_TOUT_48MS BIT(0) | BIT(1)
+#define CEC_SBIT_TOUT_48MS (BIT(0) | BIT(1))
#define CEC_SBIT_TOUT_50MS BIT(2)
#define CEC_DBIT_TOUT_27MS BIT(0)
#define CEC_DBIT_TOUT_28MS BIT(1)
-#define CEC_DBIT_TOUT_29MS BIT(0) | BIT(1)
+#define CEC_DBIT_TOUT_29MS (BIT(0) | BIT(1))
/* Constants for CEC_BIT_PULSE_THRESH register */
#define CEC_BIT_LPULSE_03MS BIT(1)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: st-cec: add parentheses around complex macros
2016-11-04 7:58 [PATCH] staging: st-cec: add parentheses around complex macros Maninder Singh
@ 2016-11-04 9:00 ` Benjamin Gaignard
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Gaignard @ 2016-11-04 9:00 UTC (permalink / raw)
To: Maninder Singh
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, kernel, linux-media,
devel, Ravikant Bijendra Sharma, Linux Kernel Mailing List
Thanks,
Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
2016-11-04 8:58 GMT+01:00 Maninder Singh <maninder.s2@samsung.com>:
> This patch fixes the following checkpatch.pl error:
> ERROR: Macros with complex values should be enclosed in parentheses
>
> Signed-off-by: Maninder Singh <maninder.s2@samsung.com>
> ---
> drivers/staging/media/st-cec/stih-cec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/st-cec/stih-cec.c b/drivers/staging/media/st-cec/stih-cec.c
> index 2143448..b22394a 100644
> --- a/drivers/staging/media/st-cec/stih-cec.c
> +++ b/drivers/staging/media/st-cec/stih-cec.c
> @@ -108,11 +108,11 @@
>
> /* Constants for CEC_BIT_TOUT_THRESH register */
> #define CEC_SBIT_TOUT_47MS BIT(1)
> -#define CEC_SBIT_TOUT_48MS BIT(0) | BIT(1)
> +#define CEC_SBIT_TOUT_48MS (BIT(0) | BIT(1))
> #define CEC_SBIT_TOUT_50MS BIT(2)
> #define CEC_DBIT_TOUT_27MS BIT(0)
> #define CEC_DBIT_TOUT_28MS BIT(1)
> -#define CEC_DBIT_TOUT_29MS BIT(0) | BIT(1)
> +#define CEC_DBIT_TOUT_29MS (BIT(0) | BIT(1))
>
> /* Constants for CEC_BIT_PULSE_THRESH register */
> #define CEC_BIT_LPULSE_03MS BIT(1)
> --
> 1.7.9.5
>
--
Benjamin Gaignard
Graphic Study Group
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-04 9:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-04 7:58 [PATCH] staging: st-cec: add parentheses around complex macros Maninder Singh
2016-11-04 9:00 ` Benjamin Gaignard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).