From: Vladimir Oltean <olteanv@gmail.com>
To: "Johnson CH Chen (陳昭勳)" <JohnsonCH.Chen@moxa.com>
Cc: "claudiu.manoil@nxp.com" <claudiu.manoil@nxp.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"zero19850401@gmail.com" <zero19850401@gmail.com>
Subject: Re: [PATCH] gianfar: Solve ethernet TX/RX problems for ls1021a
Date: Tue, 7 Jan 2020 17:49:12 +0200 [thread overview]
Message-ID: <CA+h21hpERd-yko+X9G-D9eFwu3LVq625qDUYvNGtEA8Ere_vYw@mail.gmail.com> (raw)
In-Reply-To: <HK0PR01MB3521C806FE109E04FA72858CFA3F0@HK0PR01MB3521.apcprd01.prod.exchangelabs.com>
Hi Chen,
On Tue, 7 Jan 2020 at 12:37, Johnson CH Chen (陳昭勳)
<JohnsonCH.Chen@moxa.com> wrote:
>
> Add dma_endian_le to solve ethernet TX/RX problems for freescale ls1021a. Without this, it will result in
> rx-busy-errors by ethtool, and transmit queue timeout in ls1021a's platforms.
>
> Signed-off-by: Johnson Chen <johnsonch.chen@moxa.com>
> ---
This patch is not valid. The endianness configuration in
eTSECx_DMACTRL is reserved and not applicable.
What is the value of SCFG_ETSECDMAMCR bits ETSEC_BD and ETSEC_FR_DATA
on your board? Typically this is configured by the bootloader.
> drivers/net/ethernet/freescale/gianfar.c | 3 +++
> drivers/net/ethernet/freescale/gianfar.h | 4 ++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
> index 72868a28b621..ab4e45199df9 100644
> --- a/drivers/net/ethernet/freescale/gianfar.c
> +++ b/drivers/net/ethernet/freescale/gianfar.c
> @@ -833,6 +833,7 @@ static int gfar_of_init(struct platform_device *ofdev, struct net_device **pdev)
>
> /* Find the TBI PHY. If it's not there, we don't support SGMII */
> priv->tbi_node = of_parse_phandle(np, "tbi-handle", 0);
> + priv->dma_endian_le = of_property_read_bool(np, "fsl,dma-endian-le");
>
> return 0;
>
> @@ -1209,6 +1210,8 @@ static void gfar_start(struct gfar_private *priv)
> /* Initialize DMACTRL to have WWR and WOP */
> tempval = gfar_read(®s->dmactrl);
> tempval |= DMACTRL_INIT_SETTINGS;
> + if (priv->dma_endian_le)
> + tempval |= DMACTRL_LE;
> gfar_write(®s->dmactrl, tempval);
>
> /* Make sure we aren't stopped */
> diff --git a/drivers/net/ethernet/freescale/gianfar.h b/drivers/net/ethernet/freescale/gianfar.h
> index 432c6a818ae5..aae07db5206b 100644
> --- a/drivers/net/ethernet/freescale/gianfar.h
> +++ b/drivers/net/ethernet/freescale/gianfar.h
> @@ -215,6 +215,7 @@ extern const char gfar_driver_version[];
> #define DMACTRL_INIT_SETTINGS 0x000000c3
> #define DMACTRL_GRS 0x00000010
> #define DMACTRL_GTS 0x00000008
> +#define DMACTRL_LE 0x00008000
>
> #define TSTAT_CLEAR_THALT_ALL 0xFF000000
> #define TSTAT_CLEAR_THALT 0x80000000
> @@ -1140,6 +1141,9 @@ struct gfar_private {
> tx_pause_en:1,
> rx_pause_en:1;
>
> + /* little endian dma buffer and descriptor host interface */
> + unsigned int dma_endian_le;
> +
> /* The total tx and rx ring size for the enabled queues */
> unsigned int total_tx_ring_size;
> unsigned int total_rx_ring_size;
> --
> 2.11.0
>
> Best regards,
> Johnson
Regards,
-Vladimir
next prev parent reply other threads:[~2020-01-07 15:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 10:36 [PATCH] gianfar: Solve ethernet TX/RX problems for ls1021a Johnson CH Chen (陳昭勳)
2020-01-07 13:21 ` Andrew Lunn
2020-01-07 14:17 ` Fabio Estevam
2020-01-08 5:26 ` Johnson CH Chen (陳昭勳)
2020-01-07 15:49 ` Vladimir Oltean [this message]
2020-01-08 7:15 ` Johnson CH Chen (陳昭勳)
2020-01-08 16:30 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+h21hpERd-yko+X9G-D9eFwu3LVq625qDUYvNGtEA8Ere_vYw@mail.gmail.com \
--to=olteanv@gmail.com \
--cc=JohnsonCH.Chen@moxa.com \
--cc=claudiu.manoil@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zero19850401@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).