linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Johnson CH Chen (陳昭勳)" <JohnsonCH.Chen@moxa.com>
To: Fabio Estevam <festevam@gmail.com>, Andrew Lunn <andrew@lunn.ch>
Cc: "claudiu.manoil@nxp.com" <claudiu.manoil@nxp.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"zero19850401@gmail.com" <zero19850401@gmail.com>
Subject: RE: [PATCH] gianfar: Solve ethernet TX/RX problems for ls1021a
Date: Wed, 8 Jan 2020 05:26:35 +0000	[thread overview]
Message-ID: <HK0PR01MB3521CA38E57FA1A5860349DDFA3E0@HK0PR01MB3521.apcprd01.prod.exchangelabs.com> (raw)
In-Reply-To: <CAOMZO5AE1eFjfHwh5HQjn3XmA=_tYZ2qjcU-sX63qFuV=f8ccw@mail.gmail.com>

Hi,

Fabio Estevam <festevam@gmail.com> 於 2020年1月7日 週二 下午10:17寫道：
>
> On Tue, Jan 7, 2020 at 11:13 AM Andrew Lunn <andrew@lunn.ch> wrote:
> >
> > > diff --git a/drivers/net/ethernet/freescale/gianfar.c 
> > > b/drivers/net/ethernet/freescale/gianfar.c
> > > index 72868a28b621..ab4e45199df9 100644
> > > --- a/drivers/net/ethernet/freescale/gianfar.c
> > > +++ b/drivers/net/ethernet/freescale/gianfar.c
> > > @@ -833,6 +833,7 @@ static int gfar_of_init(struct platform_device 
> > > *ofdev, struct net_device **pdev)
> > >
> > >       /* Find the TBI PHY.  If it's not there, we don't support SGMII */
> > >       priv->tbi_node = of_parse_phandle(np, "tbi-handle", 0);
> > > +     priv->dma_endian_le = of_property_read_bool(np, 
> > > + "fsl,dma-endian-le");
> >
> > Hi Johnson
> >
> > You need to document this new property in the binding.

Thanks yuor remind, I'll take care of it later
>
> Yes, but what about calling it 'little-endian' which is commonly used 
> in arch/arm64/boot/dts/freescale/fsl-lsxxx device trees?
It sounds good, use "dma-endian-le" because it's from freescale's SDK for arm (32bit).

Thanks your suggestions!

Best regards,
Johnson

  reply	other threads:[~2020-01-08  5:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-07 10:36 [PATCH] gianfar: Solve ethernet TX/RX problems for ls1021a Johnson CH Chen (陳昭勳)
2020-01-07 13:21 ` Andrew Lunn
2020-01-07 14:17   ` Fabio Estevam
2020-01-08  5:26     ` Johnson CH Chen (陳昭勳) [this message]
2020-01-07 15:49 ` Vladimir Oltean
2020-01-08  7:15   ` Johnson CH Chen (陳昭勳)
2020-01-08 16:30     ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=HK0PR01MB3521CA38E57FA1A5860349DDFA3E0@HK0PR01MB3521.apcprd01.prod.exchangelabs.com \
    --to=johnsonch.chen@moxa.com \
    --cc=andrew@lunn.ch \
    --cc=claudiu.manoil@nxp.com \
    --cc=festevam@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=zero19850401@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).