From: Andrew Lunn <andrew@lunn.ch>
To: "Johnson CH Chen (陳昭勳)" <JohnsonCH.Chen@moxa.com>
Cc: "claudiu.manoil@nxp.com" <claudiu.manoil@nxp.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"zero19850401@gmail.com" <zero19850401@gmail.com>
Subject: Re: [PATCH] gianfar: Solve ethernet TX/RX problems for ls1021a
Date: Tue, 7 Jan 2020 14:21:50 +0100 [thread overview]
Message-ID: <20200107132150.GB23819@lunn.ch> (raw)
In-Reply-To: <HK0PR01MB3521C806FE109E04FA72858CFA3F0@HK0PR01MB3521.apcprd01.prod.exchangelabs.com>
> diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
> index 72868a28b621..ab4e45199df9 100644
> --- a/drivers/net/ethernet/freescale/gianfar.c
> +++ b/drivers/net/ethernet/freescale/gianfar.c
> @@ -833,6 +833,7 @@ static int gfar_of_init(struct platform_device *ofdev, struct net_device **pdev)
>
> /* Find the TBI PHY. If it's not there, we don't support SGMII */
> priv->tbi_node = of_parse_phandle(np, "tbi-handle", 0);
> + priv->dma_endian_le = of_property_read_bool(np, "fsl,dma-endian-le");
Hi Johnson
You need to document this new property in the binding.
Thanks
Andrew
next prev parent reply other threads:[~2020-01-07 13:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 10:36 [PATCH] gianfar: Solve ethernet TX/RX problems for ls1021a Johnson CH Chen (陳昭勳)
2020-01-07 13:21 ` Andrew Lunn [this message]
2020-01-07 14:17 ` Fabio Estevam
2020-01-08 5:26 ` Johnson CH Chen (陳昭勳)
2020-01-07 15:49 ` Vladimir Oltean
2020-01-08 7:15 ` Johnson CH Chen (陳昭勳)
2020-01-08 16:30 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107132150.GB23819@lunn.ch \
--to=andrew@lunn.ch \
--cc=JohnsonCH.Chen@moxa.com \
--cc=claudiu.manoil@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zero19850401@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).