* [PATCH] staging: r8188eu: core: remove condition never execute
@ 2021-09-04 12:50 Saurav Girepunje
2021-09-04 17:53 ` Phillip Potter
2021-09-05 7:55 ` Michael Straube
0 siblings, 2 replies; 3+ messages in thread
From: Saurav Girepunje @ 2021-09-04 12:50 UTC (permalink / raw)
To: Larry.Finger, phil, gregkh, straube.linux, saurav.girepunje,
linux-staging, linux-kernel
Cc: saurav.girepunje
Remove condition which never get execute.
as pattrib->mdata is always zero before if condition check.
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
index 4178b3c1ff57..f314f55997bf 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
@@ -5669,9 +5669,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16
else if ((pmlmeinfo->state & 0x03) == WIFI_FW_STATION_STATE)
SetToDs(fctrl);
- if (pattrib->mdata)
- SetMData(fctrl);
-
qc = (unsigned short *)(pframe + pattrib->hdrlen - 2);
SetPriority(qc, tid);
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: r8188eu: core: remove condition never execute
2021-09-04 12:50 [PATCH] staging: r8188eu: core: remove condition never execute Saurav Girepunje
@ 2021-09-04 17:53 ` Phillip Potter
2021-09-05 7:55 ` Michael Straube
1 sibling, 0 replies; 3+ messages in thread
From: Phillip Potter @ 2021-09-04 17:53 UTC (permalink / raw)
To: Saurav Girepunje
Cc: Larry Finger, Greg KH, Michael Straube,
open list:STAGING SUBSYSTEM, Linux Kernel Mailing List,
saurav.girepunje
On Sat, 4 Sept 2021 at 13:50, Saurav Girepunje
<saurav.girepunje@gmail.com> wrote:
>
> Remove condition which never get execute.
> as pattrib->mdata is always zero before if condition check.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
> drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> index 4178b3c1ff57..f314f55997bf 100644
> --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> @@ -5669,9 +5669,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16
> else if ((pmlmeinfo->state & 0x03) == WIFI_FW_STATION_STATE)
> SetToDs(fctrl);
>
> - if (pattrib->mdata)
> - SetMData(fctrl);
> -
> qc = (unsigned short *)(pframe + pattrib->hdrlen - 2);
>
> SetPriority(qc, tid);
> --
> 2.32.0
>
Thanks for this.
Acked-by: Phillip Potter <phil@philpotter.co.uk>
Regards,
Phil
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: r8188eu: core: remove condition never execute
2021-09-04 12:50 [PATCH] staging: r8188eu: core: remove condition never execute Saurav Girepunje
2021-09-04 17:53 ` Phillip Potter
@ 2021-09-05 7:55 ` Michael Straube
1 sibling, 0 replies; 3+ messages in thread
From: Michael Straube @ 2021-09-05 7:55 UTC (permalink / raw)
To: Saurav Girepunje, Larry.Finger, phil, gregkh, linux-staging,
linux-kernel
Cc: saurav.girepunje
On 9/4/21 14:50, Saurav Girepunje wrote:
> Remove condition which never get execute.
> as pattrib->mdata is always zero before if condition check.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
> drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> index 4178b3c1ff57..f314f55997bf 100644
> --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> @@ -5669,9 +5669,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16
> else if ((pmlmeinfo->state & 0x03) == WIFI_FW_STATION_STATE)
> SetToDs(fctrl);
>
> - if (pattrib->mdata)
> - SetMData(fctrl);
> -
> qc = (unsigned short *)(pframe + pattrib->hdrlen - 2);
>
> SetPriority(qc, tid);
> --
> 2.32.0
>
Looks good to me.
Acked-by: Michael Straube <straube.linux@gmail.com>
Thanks,
Michael
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-05 7:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-04 12:50 [PATCH] staging: r8188eu: core: remove condition never execute Saurav Girepunje
2021-09-04 17:53 ` Phillip Potter
2021-09-05 7:55 ` Michael Straube
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).