* Re: [PATCH v4 1/9] dt-bindings: i2c: npcm: support NPCM845
[not found] ` <CACD3sJa6qEPDD58NqiXJ+hHHSSbB6BRqEPXuX+m49ei8HrHF+g@mail.gmail.com>
@ 2022-05-11 0:28 ` Tyrone Ting
0 siblings, 0 replies; 5+ messages in thread
From: Tyrone Ting @ 2022-05-11 0:28 UTC (permalink / raw)
To: Krzysztof Kozlowski, avifishman70, Tomer Maimon, Tali Perry,
Patrick Venture, Nancy Yuen, Benjamin Fair, robh+dt,
Wolfram Sang, Andy Shevchenko, jarkko.nikula, semen.protsenko,
sven, jsd, lukas.bulwahn, olof, arnd, Tyrone Ting, tali.perry,
Avi.Fishman, tomer.maimon, KWLIU, JJLIU0, kfting
Cc: openbmc, linux-i2c, devicetree, linux-kernel
Tyrone Ting <warp5tw@gmail.com> 於 2022年5月11日 週三 上午8:25寫道:
>
> Hi Krzysztof:
>
> Thank you for your review and it will be addressed.
>
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 於 2022年5月10日 週二 下午6:59寫道:
> >
> > On 10/05/2022 12:03, Tyrone Ting wrote:
> > >
> > > maintainers:
> > > - Tali Perry <tali.perry1@gmail.com>
> > >
> > > properties:
> > > compatible:
> > > - const: nuvoton,npcm750-i2c
> > > + enum:
> > > + - nuvoton,npcm750-i2c
> > > + - nuvoton,npcm845-i2c
> > >
> > > reg:
> > > maxItems: 1
> > > @@ -36,6 +37,10 @@ properties:
> > > default: 100000
> > > enum: [100000, 400000, 1000000]
> > >
> > > + nuvoton,sys-mgr:
> > > + $ref: "/schemas/types.yaml#/definitions/phandle"
> >
> > Minor nit: No quotes. The other places don't have it.
> >
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >
> >
> > Best regards,
> > Krzysztof
>
> Best regards,
> Tyrone
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4 1/9] dt-bindings: i2c: npcm: support NPCM845
2022-05-12 1:31 ` Tyrone Ting
@ 2022-05-13 8:26 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-13 8:26 UTC (permalink / raw)
To: Tyrone Ting, Rob Herring
Cc: sven, JJLIU0, linux-kernel, olof, lukas.bulwahn, jarkko.nikula,
yuenn, arnd, tali.perry1, openbmc, robh+dt,
krzysztof.kozlowski+dt, linux-i2c, tmaimon77, benjaminfair,
tomer.maimon, kfting, semen.protsenko, Avi.Fishman, jsd, wsa,
devicetree, andriy.shevchenko, KWLIU, tali.perry, avifishman70,
venture
On 12/05/2022 03:31, Tyrone Ting wrote:
> Hi Rob:
>
> Thank you for your review. I would like to apply Krzysztof's comment
> from the link https://www.spinics.net/lists/linux-i2c/msg56795.html
> and remove the
> quotes of the statement "$ref: "/schemas/types.yaml#/definitions/phandle"".
>
> If it's okay with you, I'll come up with a new patch with
> "Reviewed-by" from you and Krzysztof.
Go ahead and keep the review-tags in new patch.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4 1/9] dt-bindings: i2c: npcm: support NPCM845
2022-05-11 15:24 ` Rob Herring
@ 2022-05-12 1:31 ` Tyrone Ting
2022-05-13 8:26 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Tyrone Ting @ 2022-05-12 1:31 UTC (permalink / raw)
To: Rob Herring
Cc: sven, JJLIU0, linux-kernel, olof, lukas.bulwahn, jarkko.nikula,
yuenn, arnd, tali.perry1, openbmc, robh+dt,
krzysztof.kozlowski+dt, linux-i2c, tmaimon77, benjaminfair,
tomer.maimon, kfting, semen.protsenko, Avi.Fishman, jsd, wsa,
devicetree, andriy.shevchenko, KWLIU, tali.perry, avifishman70,
venture
Hi Rob:
Thank you for your review. I would like to apply Krzysztof's comment
from the link https://www.spinics.net/lists/linux-i2c/msg56795.html
and remove the
quotes of the statement "$ref: "/schemas/types.yaml#/definitions/phandle"".
If it's okay with you, I'll come up with a new patch with
"Reviewed-by" from you and Krzysztof.
Thank you.
Rob Herring <robh@kernel.org> 於 2022年5月11日 週三 下午11:24寫道:
>
> On Tue, 10 May 2022 17:16:46 +0800, Tyrone Ting wrote:
> > From: Tyrone Ting <kfting@nuvoton.com>
> >
> > Add compatible and nuvoton,sys-mgr description for NPCM i2c module.
> >
> > Signed-off-by: Tyrone Ting <kfting@nuvoton.com>
> > ---
> > .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 25 +++++++++++++++----
> > 1 file changed, 20 insertions(+), 5 deletions(-)
> >
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Best Regards,
Tyrone
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4 1/9] dt-bindings: i2c: npcm: support NPCM845
2022-05-10 9:16 ` [PATCH v4 1/9] dt-bindings: i2c: npcm: support NPCM845 Tyrone Ting
@ 2022-05-11 15:24 ` Rob Herring
2022-05-12 1:31 ` Tyrone Ting
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2022-05-11 15:24 UTC (permalink / raw)
To: Tyrone Ting
Cc: sven, JJLIU0, linux-kernel, jie.deng, olof, lukas.bulwahn,
jarkko.nikula, yuenn, arnd, tali.perry1, openbmc,
krzysztof.kozlowski, robh+dt, linux-i2c, tmaimon77, benjaminfair,
tomer.maimon, kfting, semen.protsenko, Avi.Fishman, jsd, wsa,
devicetree, andriy.shevchenko, KWLIU, tali.perry, avifishman70,
venture
On Tue, 10 May 2022 17:16:46 +0800, Tyrone Ting wrote:
> From: Tyrone Ting <kfting@nuvoton.com>
>
> Add compatible and nuvoton,sys-mgr description for NPCM i2c module.
>
> Signed-off-by: Tyrone Ting <kfting@nuvoton.com>
> ---
> .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 25 +++++++++++++++----
> 1 file changed, 20 insertions(+), 5 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v4 1/9] dt-bindings: i2c: npcm: support NPCM845
2022-05-10 9:16 [PATCH v4 0/9] i2c: npcm: Bug fixes timeout, spurious interrupts Tyrone Ting
@ 2022-05-10 9:16 ` Tyrone Ting
2022-05-11 15:24 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Tyrone Ting @ 2022-05-10 9:16 UTC (permalink / raw)
To: avifishman70, tmaimon77, tali.perry1, venture, yuenn,
benjaminfair, robh+dt, krzysztof.kozlowski, wsa,
andriy.shevchenko, jarkko.nikula, semen.protsenko, sven,
jie.deng, jsd, lukas.bulwahn, olof, arnd, warp5tw, tali.perry,
Avi.Fishman, tomer.maimon, KWLIU, JJLIU0, kfting
Cc: openbmc, linux-i2c, devicetree, linux-kernel
From: Tyrone Ting <kfting@nuvoton.com>
Add compatible and nuvoton,sys-mgr description for NPCM i2c module.
Signed-off-by: Tyrone Ting <kfting@nuvoton.com>
---
.../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 25 +++++++++++++++----
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
index 128444942aec..99fae8489771 100644
--- a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
@@ -7,17 +7,18 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
title: nuvoton NPCM7XX I2C Controller Device Tree Bindings
description: |
- The NPCM750x includes sixteen I2C bus controllers. All Controllers support
- both master and slave mode. Each controller can switch between master and slave
- at run time (i.e. IPMB mode). Each controller has two 16 byte HW FIFO for TX and
- RX.
+ I2C bus controllers of the NPCM series support both master and
+ slave mode. Each controller can switch between master and slave at run time
+ (i.e. IPMB mode). HW FIFO for TX and RX are supported.
maintainers:
- Tali Perry <tali.perry1@gmail.com>
properties:
compatible:
- const: nuvoton,npcm750-i2c
+ enum:
+ - nuvoton,npcm750-i2c
+ - nuvoton,npcm845-i2c
reg:
maxItems: 1
@@ -36,6 +37,10 @@ properties:
default: 100000
enum: [100000, 400000, 1000000]
+ nuvoton,sys-mgr:
+ $ref: "/schemas/types.yaml#/definitions/phandle"
+ description: The phandle of system manager register node.
+
required:
- compatible
- reg
@@ -44,6 +49,15 @@ required:
allOf:
- $ref: /schemas/i2c/i2c-controller.yaml#
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: nuvoton,npcm845-i2c
+
+ then:
+ required:
+ - nuvoton,sys-mgr
unevaluatedProperties: false
@@ -57,6 +71,7 @@ examples:
clock-frequency = <100000>;
interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>;
compatible = "nuvoton,npcm750-i2c";
+ nuvoton,sys-mgr = <&gcr>;
};
...
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-05-13 8:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220510100328.9191-1-warp5tw@gmail.com>
[not found] ` <20220510100328.9191-2-warp5tw@gmail.com>
[not found] ` <28029d30-6d18-d28c-a7d2-d86b9ab9ad35@linaro.org>
[not found] ` <CACD3sJa6qEPDD58NqiXJ+hHHSSbB6BRqEPXuX+m49ei8HrHF+g@mail.gmail.com>
2022-05-11 0:28 ` [PATCH v4 1/9] dt-bindings: i2c: npcm: support NPCM845 Tyrone Ting
2022-05-10 9:16 [PATCH v4 0/9] i2c: npcm: Bug fixes timeout, spurious interrupts Tyrone Ting
2022-05-10 9:16 ` [PATCH v4 1/9] dt-bindings: i2c: npcm: support NPCM845 Tyrone Ting
2022-05-11 15:24 ` Rob Herring
2022-05-12 1:31 ` Tyrone Ting
2022-05-13 8:26 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).