[PATCH] pinctrl: Fix pinconf_pins_show iteration

[PATCH] pinctrl: Fix pinconf_pins_show iteration

[Stephen Warren]

Commit 706e852 "pinctrl: correct a offset while enumerating pins"
modified the variable used by pinconf_pin_show()'s for loop, but didn't
update the for loop test expression.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 drivers/pinctrl/pinconf.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index 1259872..1892a37 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -236,7 +236,7 @@ static int pinconf_pins_show(struct seq_file *s, void *what)
 	seq_puts(s, "Format: pin (name): pinmux setting array\n");
 
 	/* The pin number can be retrived from the pin controller descriptor */
-	for (i = 0; pin < pctldev->desc->npins; i++) {
+	for (i = 0; i < pctldev->desc->npins; i++) {
 		struct pin_desc *desc;
 
 		pin = pctldev->desc->pins[i].number;
-- 
1.7.0.4

RE: [PATCH] pinctrl: Fix pinconf_pins_show iteration

[Chanho Park]

> -----Original Message-----
> From: Stephen Warren [mailto:swarren@nvidia.com]
> Sent: Saturday, January 07, 2012 5:39 AM
> To: Linus Walleij
> Cc: linux-kernel@vger.kernel.org; Chanho Park; Stephen Warren
> Subject: [PATCH] pinctrl: Fix pinconf_pins_show iteration
> 
> Commit 706e852 "pinctrl: correct a offset while enumerating pins"
> modified the variable used by pinconf_pin_show()'s for loop, but didn't
> update the for loop test expression.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
>  drivers/pinctrl/pinconf.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
> index 1259872..1892a37 100644
> --- a/drivers/pinctrl/pinconf.c
> +++ b/drivers/pinctrl/pinconf.c
> @@ -236,7 +236,7 @@ static int pinconf_pins_show(struct seq_file *s,
> void *what)
>  	seq_puts(s, "Format: pin (name): pinmux setting array\n");
> 
>  	/* The pin number can be retrived from the pin controller
> descriptor */
> -	for (i = 0; pin < pctldev->desc->npins; i++) {
> +	for (i = 0; i < pctldev->desc->npins; i++) {
>  		struct pin_desc *desc;
> 
>  		pin = pctldev->desc->pins[i].number;
> --
> 1.7.0.4

Oh, I missed it.
Thank you for refining it.

Best Regards,
Chanho Park

Re: [PATCH] pinctrl: Fix pinconf_pins_show iteration

[Linus Walleij]

On Fri, Jan 6, 2012 at 9:38 PM, Stephen Warren <swarren@nvidia.com> wrote:

> Commit 706e852 "pinctrl: correct a offset while enumerating pins"
> modified the variable used by pinconf_pin_show()'s for loop, but didn't
> update the for loop test expression.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>

OK applied to my fixes branch, will send this along with any other
fixes once Torvalds has pulled the pinctrl tree for this merge window.

Yours,
Linus Walleij

RE: [PATCH] pinctrl: Fix pinconf_pins_show iteration

[Stephen Warren]

Linus Walleij wrote at Tuesday, January 10, 2012 2:17 AM:
> On Fri, Jan 6, 2012 at 9:38 PM, Stephen Warren <swarren@nvidia.com> wrote:
> 
> > Commit 706e852 "pinctrl: correct a offset while enumerating pins"
> > modified the variable used by pinconf_pin_show()'s for loop, but didn't
> > update the for loop test expression.
> >
> > Signed-off-by: Stephen Warren <swarren@nvidia.com>
> 
> OK applied to my fixes branch, will send this along with any other
> fixes once Torvalds has pulled the pinctrl tree for this merge window.

Linus,

This still hasn't shown up in next-20120119. Is that expected?

Thanks.

-- 
nvpublic

Re: [PATCH] pinctrl: Fix pinconf_pins_show iteration

[Linus Walleij]

On Thu, Jan 19, 2012 at 6:52 PM, Stephen Warren <swarren@nvidia.com> wrote:
> Linus Walleij wrote at Tuesday, January 10, 2012 2:17 AM:
>> On Fri, Jan 6, 2012 at 9:38 PM, Stephen Warren <swarren@nvidia.com> wrote:
>>
>> > Commit 706e852 "pinctrl: correct a offset while enumerating pins"
>> > modified the variable used by pinconf_pin_show()'s for loop, but didn't
>> > update the for loop test expression.
>> >
>> > Signed-off-by: Stephen Warren <swarren@nvidia.com>
>>
>> OK applied to my fixes branch, will send this along with any other
>> fixes once Torvalds has pulled the pinctrl tree for this merge window.
>
> Linus,
>
> This still hasn't shown up in next-20120119. Is that expected?

Yes I was waiting for the merge window to close, but I guess that's
a bit over-cautios. I'll push it out tomorrow...

Thanks,
Linus Walleij