* [PATCH] pinctrl: qcom: fix wrong write in update_dual_edge
@ 2020-04-14 0:37 Ansuel Smith
2020-04-14 1:04 ` Bjorn Andersson
2020-04-16 11:16 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Ansuel Smith @ 2020-04-14 0:37 UTC (permalink / raw)
To: Andy Gross
Cc: Ansuel Smith, Bjorn Andersson, Linus Walleij, linux-arm-msm,
linux-gpio, linux-kernel
Fix a typo in the readl/writel accessor conversion where val is used
instead of pol changing the behavior of the original code.
Fixes: 6c73698904aa pinctrl: qcom: Introduce readl/writel accessors
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
drivers/pinctrl/qcom/pinctrl-msm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
index 1a948c3f54b7..9f1c9951949e 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -692,7 +692,7 @@ static void msm_gpio_update_dual_edge_pos(struct msm_pinctrl *pctrl,
pol = msm_readl_intr_cfg(pctrl, g);
pol ^= BIT(g->intr_polarity_bit);
- msm_writel_intr_cfg(val, pctrl, g);
+ msm_writel_intr_cfg(pol, pctrl, g);
val2 = msm_readl_io(pctrl, g) & BIT(g->in_bit);
intstat = msm_readl_intr_status(pctrl, g);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: qcom: fix wrong write in update_dual_edge
2020-04-14 0:37 [PATCH] pinctrl: qcom: fix wrong write in update_dual_edge Ansuel Smith
@ 2020-04-14 1:04 ` Bjorn Andersson
2020-04-16 11:16 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2020-04-14 1:04 UTC (permalink / raw)
To: Ansuel Smith
Cc: Andy Gross, Linus Walleij, linux-arm-msm, linux-gpio, linux-kernel
On Mon 13 Apr 17:37 PDT 2020, Ansuel Smith wrote:
> Fix a typo in the readl/writel accessor conversion where val is used
> instead of pol changing the behavior of the original code.
>
> Fixes: 6c73698904aa pinctrl: qcom: Introduce readl/writel accessors
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Thank you Ansuel
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Linus, when you apply this please add
Cc: stable@vger.kernel.org
Thanks,
Bjorn
> ---
> drivers/pinctrl/qcom/pinctrl-msm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
> index 1a948c3f54b7..9f1c9951949e 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -692,7 +692,7 @@ static void msm_gpio_update_dual_edge_pos(struct msm_pinctrl *pctrl,
>
> pol = msm_readl_intr_cfg(pctrl, g);
> pol ^= BIT(g->intr_polarity_bit);
> - msm_writel_intr_cfg(val, pctrl, g);
> + msm_writel_intr_cfg(pol, pctrl, g);
>
> val2 = msm_readl_io(pctrl, g) & BIT(g->in_bit);
> intstat = msm_readl_intr_status(pctrl, g);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: qcom: fix wrong write in update_dual_edge
2020-04-14 0:37 [PATCH] pinctrl: qcom: fix wrong write in update_dual_edge Ansuel Smith
2020-04-14 1:04 ` Bjorn Andersson
@ 2020-04-16 11:16 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2020-04-16 11:16 UTC (permalink / raw)
To: Ansuel Smith
Cc: Andy Gross, Bjorn Andersson, MSM, open list:GPIO SUBSYSTEM, linux-kernel
On Tue, Apr 14, 2020 at 2:37 AM Ansuel Smith <ansuelsmth@gmail.com> wrote:
> Fix a typo in the readl/writel accessor conversion where val is used
> instead of pol changing the behavior of the original code.
>
> Fixes: 6c73698904aa pinctrl: qcom: Introduce readl/writel accessors
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Patch applied for fixes and tagged for stable with Bjorn's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-16 11:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-14 0:37 [PATCH] pinctrl: qcom: fix wrong write in update_dual_edge Ansuel Smith
2020-04-14 1:04 ` Bjorn Andersson
2020-04-16 11:16 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).