From: Linus Walleij <linus.walleij@linaro.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Lee Jones <lee.jones@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Hoan Tran <hoan@os.amperecomputing.com>
Subject: Re: [PATCH v1 2/4] gpio: dwapb: Read GPIO base from gpio-base property
Date: Wed, 11 Aug 2021 14:40:49 +0200 [thread overview]
Message-ID: <CACRpkdYJyVUix6MSLQvF1Ok21gHdk6d8ToGpP_rh5v6Rpwyn5g@mail.gmail.com> (raw)
In-Reply-To: <YQqnrHAuSneeEFgO@smile.fi.intel.com>
On Wed, Aug 4, 2021 at 4:44 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Wed, Aug 04, 2021 at 03:44:33PM +0300, Serge Semin wrote:
> > Thus, yes, I think we need to make sure here that the property
> > is only used in framework of the kernel and isn't passed via
> > inappropriate paths like DT/ACPI fw so not to get into the
> > maintainability troubles in future.
>
> Got it. I'll add the additional check in next version.
This seems reasonable for me, if you can get this done with
some kind of elegance.
Maybe use the "linux,gpio-base" property as mentioned so it is
clear that this is a Linux-internal thing only.
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-08-11 12:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 12:54 [PATCH v1 1/4] gpio: dwapb: Unify ACPI enumeration checks in get_irq() and configure_irqs() Andy Shevchenko
2021-07-26 12:54 ` [PATCH v1 2/4] gpio: dwapb: Read GPIO base from gpio-base property Andy Shevchenko
2021-08-02 13:58 ` Serge Semin
2021-08-02 15:52 ` Andy Shevchenko
2021-08-04 12:44 ` Serge Semin
2021-08-04 14:43 ` Andy Shevchenko
2021-08-11 12:40 ` Linus Walleij [this message]
2021-08-11 12:47 ` Serge Semin
2021-08-11 12:37 ` Linus Walleij
2021-08-11 13:11 ` Andy Shevchenko
2021-07-26 12:54 ` [PATCH v1 3/4] mfd: intel_quark_i2c_gpio: Convert GPIO to use software nodes Andy Shevchenko
2021-08-11 8:38 ` Linus Walleij
2021-08-11 10:55 ` Andy Shevchenko
2021-08-16 13:05 ` Lee Jones
2021-08-16 13:18 ` Andy Shevchenko
2021-08-16 13:33 ` Lee Jones
2021-08-16 14:00 ` Andy Shevchenko
2021-08-16 14:19 ` Lee Jones
2021-08-16 14:53 ` Andy Shevchenko
2021-08-17 7:26 ` Lee Jones
2021-08-17 11:23 ` Andy Shevchenko
2021-08-18 6:34 ` Lee Jones
2021-08-18 11:04 ` Andy Shevchenko
2021-09-21 15:25 ` Lee Jones
2021-07-26 12:54 ` [PATCH v1 4/4] gpio: dwapb: Get rid of legacy platform data Andy Shevchenko
2021-08-02 14:07 ` Serge Semin
2021-08-02 15:54 ` Andy Shevchenko
2021-08-02 8:48 ` [PATCH v1 1/4] gpio: dwapb: Unify ACPI enumeration checks in get_irq() and configure_irqs() Lee Jones
2021-08-02 13:40 ` Serge Semin
2021-08-02 18:37 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYJyVUix6MSLQvF1Ok21gHdk6d8ToGpP_rh5v6Rpwyn5g@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=fancer.lancer@gmail.com \
--cc=hoan@os.amperecomputing.com \
--cc=lee.jones@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).