From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Hoan Tran <hoan@os.amperecomputing.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v1 1/4] gpio: dwapb: Unify ACPI enumeration checks in get_irq() and configure_irqs()
Date: Mon, 2 Aug 2021 21:37:56 +0300 [thread overview]
Message-ID: <YQg7hNKlUlkz/fkv@smile.fi.intel.com> (raw)
In-Reply-To: <20210802134021.flrkpmlrcjfxdrdr@mobilestation>
On Mon, Aug 02, 2021 at 04:40:21PM +0300, Serge Semin wrote:
> Hello Andy
> Thanks for the cleanup series. A tiny note is below.
Thanks for review!
> On Mon, Jul 26, 2021 at 03:54:33PM +0300, Andy Shevchenko wrote:
> > Shared IRQ is only enabled for ACPI enumeration, there is no need
> > to have a special flag for that, since we simple can test if device
> > has been enumerated by ACPI. This unifies the checks in dwapb_get_irq()
> > and dwapb_configure_irqs().
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > drivers/gpio/gpio-dwapb.c | 13 ++++++-------
> > drivers/mfd/intel_quark_i2c_gpio.c | 1 -
> > include/linux/platform_data/gpio-dwapb.h | 1 -
> > 3 files changed, 6 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
> > index 3eb13d6d31ef..f6ae69d5d644 100644
> > --- a/drivers/gpio/gpio-dwapb.c
> > +++ b/drivers/gpio/gpio-dwapb.c
> > @@ -436,12 +436,7 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio,
> > pirq->irqchip.irq_set_wake = dwapb_irq_set_wake;
> > #endif
> >
>
> > - if (!pp->irq_shared) {
> > - girq->num_parents = pirq->nr_irqs;
> > - girq->parents = pirq->irq;
> > - girq->parent_handler_data = gpio;
> > - girq->parent_handler = dwapb_irq_handler;
> > - } else {
> > + if (has_acpi_companion(gpio->dev)) {
>
> Before this patch the platform flag irq_shared has been as kind of a
> hint regarding the shared IRQ case being covered here. But now it
> doesn't seem obvious why we've got the ACPI and ACPI-less cases
> differently handled. What about adding a small comment about that?
> E.g. like this: "Intel ACPI-based platforms mostly have the DW APB
> GPIO IRQ lane shared between several devices. In that case the
> parental IRQ has to be handled in the shared way so to be properly
> delivered to all the connected devices." or something more detailed
> for your preference. After that the rest of the comments in the
> if-clause could be discarded.
Sure!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-08-02 18:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 12:54 [PATCH v1 1/4] gpio: dwapb: Unify ACPI enumeration checks in get_irq() and configure_irqs() Andy Shevchenko
2021-07-26 12:54 ` [PATCH v1 2/4] gpio: dwapb: Read GPIO base from gpio-base property Andy Shevchenko
2021-08-02 13:58 ` Serge Semin
2021-08-02 15:52 ` Andy Shevchenko
2021-08-04 12:44 ` Serge Semin
2021-08-04 14:43 ` Andy Shevchenko
2021-08-11 12:40 ` Linus Walleij
2021-08-11 12:47 ` Serge Semin
2021-08-11 12:37 ` Linus Walleij
2021-08-11 13:11 ` Andy Shevchenko
2021-07-26 12:54 ` [PATCH v1 3/4] mfd: intel_quark_i2c_gpio: Convert GPIO to use software nodes Andy Shevchenko
2021-08-11 8:38 ` Linus Walleij
2021-08-11 10:55 ` Andy Shevchenko
2021-08-16 13:05 ` Lee Jones
2021-08-16 13:18 ` Andy Shevchenko
2021-08-16 13:33 ` Lee Jones
2021-08-16 14:00 ` Andy Shevchenko
2021-08-16 14:19 ` Lee Jones
2021-08-16 14:53 ` Andy Shevchenko
2021-08-17 7:26 ` Lee Jones
2021-08-17 11:23 ` Andy Shevchenko
2021-08-18 6:34 ` Lee Jones
2021-08-18 11:04 ` Andy Shevchenko
2021-09-21 15:25 ` Lee Jones
2021-07-26 12:54 ` [PATCH v1 4/4] gpio: dwapb: Get rid of legacy platform data Andy Shevchenko
2021-08-02 14:07 ` Serge Semin
2021-08-02 15:54 ` Andy Shevchenko
2021-08-02 8:48 ` [PATCH v1 1/4] gpio: dwapb: Unify ACPI enumeration checks in get_irq() and configure_irqs() Lee Jones
2021-08-02 13:40 ` Serge Semin
2021-08-02 18:37 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQg7hNKlUlkz/fkv@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=bgolaszewski@baylibre.com \
--cc=fancer.lancer@gmail.com \
--cc=hoan@os.amperecomputing.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).