linux-next: build failure after merge of the gpio-lw tree

linux-next: build failure after merge of the gpio-lw tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

Hi Linus,

After merging the gpio-lw tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "irq_set_chip_and_handler_name" [drivers/gpio/gpio-pcf857x.ko] undefined!
ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined!

I have dropped the gpio-lw tree for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the gpio-lw tree

[Linus Walleij]

On Fri, Jul 6, 2012 at 8:14 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the gpio-lw tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: "irq_set_chip_and_handler_name" [drivers/gpio/gpio-pcf857x.ko] undefined!
> ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined!

Thanks, I've dropped the offending patch, Kuninori can you look into this and
provide a new patch? It's the second patch from your patch set.

Yours,
Linus Walleij

Re: linux-next: build failure after merge of the gpio-lw tree

[Kuninori Morimoto]

Dear Linus

> > After merging the gpio-lw tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > ERROR: "irq_set_chip_and_handler_name" [drivers/gpio/gpio-pcf857x.ko] undefined!
> > ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined!
> 
> Thanks, I've dropped the offending patch, Kuninori can you look into this and
> provide a new patch? It's the second patch from your patch set.

OK. I will, but it will be next week.
And could you please show me where is your repository/branch ?

Best regards
--
Kuninori Morimoto
 

Re: linux-next: build failure after merge of the gpio-lw tree

[Linus Walleij]

On Fri, Jul 6, 2012 at 10:55 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
> Dear Linus
>
>> > After merging the gpio-lw tree, today's linux-next build (x86_64
>> > allmodconfig) failed like this:
>> >
>> > ERROR: "irq_set_chip_and_handler_name" [drivers/gpio/gpio-pcf857x.ko] undefined!
>> > ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined!
>>
>> Thanks, I've dropped the offending patch, Kuninori can you look into this and
>> provide a new patch? It's the second patch from your patch set.
>
> OK. I will, but it will be next week.
> And could you please show me where is your repository/branch ?

http://git.kernel.org/?p=linux/kernel/git/linusw/linux-gpio.git;a=summary
branch devel/for-next

Linus Walleij

Re: linux-next: build failure after merge of the gpio-lw tree

[Kuninori Morimoto]

Hi Linus Walleij, Stephen, and Thomas

> >> > After merging the gpio-lw tree, today's linux-next build (x86_64
> >> > allmodconfig) failed like this:
> >> >
> >> > ERROR: "irq_set_chip_and_handler_name" [drivers/gpio/gpio-pcf857x.ko] undefined!
> >> > ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined!
> >>
> >> Thanks, I've dropped the offending patch, Kuninori can you look into this and
> >> provide a new patch? It's the second patch from your patch set.
> >
> > OK. I will, but it will be next week.
> > And could you please show me where is your repository/branch ?
> 
> http://git.kernel.org/?p=linux/kernel/git/linusw/linux-gpio.git;a=summary
> branch devel/for-next

In my check, these are export symbol issue.
I think above 2 function/struct were not exported for module.

Is it poosible to solve this issue by these patches ?

Kuninori Morimoto (2):
      genirq: export irq_set_chip_and_handler_name()
      genirq: export dummy_irq_chip

 kernel/irq/chip.c      |    1 +
 kernel/irq/dummychip.c |    2 ++
 2 files changed, 3 insertions(+), 0 deletions(-)


Best regards
---
Kuninori Morimoto

[PATCH 1/2] genirq: export irq_set_chip_and_handler_name()

[Kuninori Morimoto]

Export irq_set_chip_and_handler_name() to modules to allow them to
do things such as

	irq_set_chip_and_handler(virq,
				 &dummy_irq_chip,
				 handle_level_irq);
This fixes

	ERROR: "irq_set_chip_and_handler_name" \
	          [drivers/gpio/gpio-pcf857x.ko] undefined!

when gpio-pcf857x.c is being built as a module.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 kernel/irq/chip.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index eebd6d5..57d86d0 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -671,6 +671,7 @@ irq_set_chip_and_handler_name(unsigned int irq, struct irq_chip *chip,
 	irq_set_chip(irq, chip);
 	__irq_set_handler(irq, handle, 0, name);
 }
+EXPORT_SYMBOL_GPL(irq_set_chip_and_handler_name);
 
 void irq_modify_status(unsigned int irq, unsigned long clr, unsigned long set)
 {
-- 
1.7.5.4

[PATCH 2/2] genirq: export dummy_irq_chip

[Kuninori Morimoto]

Export dummy_irq_chip to modules to allow them to do things such as

	irq_set_chip_and_handler(virq,
				 &dummy_irq_chip,
				 handle_level_irq);
This fixes

	ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined!

when gpio-pcf857x.c is being built as a module.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 kernel/irq/dummychip.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/kernel/irq/dummychip.c b/kernel/irq/dummychip.c
index b5fcd96..988dc58 100644
--- a/kernel/irq/dummychip.c
+++ b/kernel/irq/dummychip.c
@@ -6,6 +6,7 @@
  */
 #include <linux/interrupt.h>
 #include <linux/irq.h>
+#include <linux/export.h>
 
 #include "internals.h"
 
@@ -57,3 +58,4 @@ struct irq_chip dummy_irq_chip = {
 	.irq_mask	= noop,
 	.irq_unmask	= noop,
 };
+EXPORT_SYMBOL_GPL(dummy_irq_chip);
-- 
1.7.5.4

Re: linux-next: build failure after merge of the gpio-lw tree

[Linus Walleij]

On Mon, Jul 9, 2012 at 4:04 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:

> Hi Linus Walleij, Stephen, and Thomas
>
>> >> > After merging the gpio-lw tree, today's linux-next build (x86_64
>> >> > allmodconfig) failed like this:
>> >> >
>> >> > ERROR: "irq_set_chip_and_handler_name" [drivers/gpio/gpio-pcf857x.ko] undefined!
>> >> > ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined!
>> >>
>> >> Thanks, I've dropped the offending patch, Kuninori can you look into this and
>> >> provide a new patch? It's the second patch from your patch set.
>> >
>> > OK. I will, but it will be next week.
>> > And could you please show me where is your repository/branch ?
>>
>> http://git.kernel.org/?p=linux/kernel/git/linusw/linux-gpio.git;a=summary
>> branch devel/for-next
>
> In my check, these are export symbol issue.
> I think above 2 function/struct were not exported for module.
>
> Is it poosible to solve this issue by these patches ?

Hm Thomas has to answer to that (and merge the patches, if he
likes them).

Yours,
Linus Walleij

Re: linux-next: build failure after merge of the gpio-lw tree

[Kuninori Morimoto]

Hi Thomas

Could you please teach me current status of these patches ?

Kuninori Morimoto (2):
      genirq: export irq_set_chip_and_handler_name()
      genirq: export dummy_irq_chip

At Mon, 9 Jul 2012 22:34:23 +0200,
Linus Walleij wrote:
> 
> On Mon, Jul 9, 2012 at 4:04 AM, Kuninori Morimoto
> <kuninori.morimoto.gx@renesas.com> wrote:
> 
> > Hi Linus Walleij, Stephen, and Thomas
> >
> >> >> > After merging the gpio-lw tree, today's linux-next build (x86_64
> >> >> > allmodconfig) failed like this:
> >> >> >
> >> >> > ERROR: "irq_set_chip_and_handler_name" [drivers/gpio/gpio-pcf857x.ko] undefined!
> >> >> > ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined!
> >> >>
> >> >> Thanks, I've dropped the offending patch, Kuninori can you look into this and
> >> >> provide a new patch? It's the second patch from your patch set.
> >> >
> >> > OK. I will, but it will be next week.
> >> > And could you please show me where is your repository/branch ?
> >>
> >> http://git.kernel.org/?p=linux/kernel/git/linusw/linux-gpio.git;a=summary
> >> branch devel/for-next
> >
> > In my check, these are export symbol issue.
> > I think above 2 function/struct were not exported for module.
> >
> > Is it poosible to solve this issue by these patches ?
> 
> Hm Thomas has to answer to that (and merge the patches, if he
> likes them).
> 
> Yours,
> Linus Walleij


Best regards
---
Kuninori Morimoto

[PATCH 0/2][resend] genirq: export patches

[Kuninori Morimoto]

Hi all

These are "resend" of genirq export patches.

Kuninori Morimoto (2):
      genirq: export irq_set_chip_and_handler_name()
      genirq: export dummy_irq_chip


> 
> Hi Thomas
> 
> Could you please teach me current status of these patches ?
> 
> Kuninori Morimoto (2):
>       genirq: export irq_set_chip_and_handler_name()
>       genirq: export dummy_irq_chip
> 
> At Mon, 9 Jul 2012 22:34:23 +0200,
> Linus Walleij wrote:
> > 
> > On Mon, Jul 9, 2012 at 4:04 AM, Kuninori Morimoto
> > <kuninori.morimoto.gx@renesas.com> wrote:
> > 
> > > Hi Linus Walleij, Stephen, and Thomas
> > >
> > >> >> > After merging the gpio-lw tree, today's linux-next build (x86_64
> > >> >> > allmodconfig) failed like this:
> > >> >> >
> > >> >> > ERROR: "irq_set_chip_and_handler_name" [drivers/gpio/gpio-pcf857x.ko] undefined!
> > >> >> > ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined!
> > >> >>
> > >> >> Thanks, I've dropped the offending patch, Kuninori can you look into this and
> > >> >> provide a new patch? It's the second patch from your patch set.
> > >> >
> > >> > OK. I will, but it will be next week.
> > >> > And could you please show me where is your repository/branch ?
> > >>
> > >> http://git.kernel.org/?p=linux/kernel/git/linusw/linux-gpio.git;a=summary
> > >> branch devel/for-next
> > >
> > > In my check, these are export symbol issue.
> > > I think above 2 function/struct were not exported for module.
> > >
> > > Is it poosible to solve this issue by these patches ?
> > 
> > Hm Thomas has to answer to that (and merge the patches, if he
> > likes them).
> > 
> > Yours,
> > Linus Walleij
> 
> 
> Best regards
> ---
> Kuninori Morimoto

[PATCH 1/2][resend] genirq: export irq_set_chip_and_handler_name()

[Kuninori Morimoto]

Export irq_set_chip_and_handler_name() to modules to allow them to
do things such as

	irq_set_chip_and_handler(....);

This fixes

	ERROR: "irq_set_chip_and_handler_name" \
	          [drivers/gpio/gpio-pcf857x.ko] undefined!

when gpio-pcf857x.c is being built as a module.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 kernel/irq/chip.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index eebd6d5..57d86d0 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -671,6 +671,7 @@ irq_set_chip_and_handler_name(unsigned int irq, struct irq_chip *chip,
 	irq_set_chip(irq, chip);
 	__irq_set_handler(irq, handle, 0, name);
 }
+EXPORT_SYMBOL_GPL(irq_set_chip_and_handler_name);
 
 void irq_modify_status(unsigned int irq, unsigned long clr, unsigned long set)
 {
-- 
1.7.5.4

[tip:irq/core] genirq: Export irq_set_chip_and_handler_name()

[tip-bot for Kuninori Morimoto]

Commit-ID:  b3ae66f209e8929db62b5a5f874ab2cdcf5ef1d4
Gitweb:     http://git.kernel.org/tip/b3ae66f209e8929db62b5a5f874ab2cdcf5ef1d4
Author:     Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
AuthorDate: Mon, 30 Jul 2012 22:39:06 -0700
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 21 Aug 2012 16:14:23 +0200

genirq: Export irq_set_chip_and_handler_name()

Export irq_set_chip_and_handler_name() to modules to allow them to
do things such as

	irq_set_chip_and_handler(....);

This fixes

	ERROR: "irq_set_chip_and_handler_name" \
	          [drivers/gpio/gpio-pcf857x.ko] undefined!

when gpio-pcf857x.c is being built as a module.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Greg KH <gregkh@linuxfoundation.org>
Link: http://lkml.kernel.org/r/873948trpk.wl%25kuninori.morimoto.gx@renesas.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 kernel/irq/chip.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index eebd6d5..57d86d0 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -671,6 +671,7 @@ irq_set_chip_and_handler_name(unsigned int irq, struct irq_chip *chip,
 	irq_set_chip(irq, chip);
 	__irq_set_handler(irq, handle, 0, name);
 }
+EXPORT_SYMBOL_GPL(irq_set_chip_and_handler_name);
 
 void irq_modify_status(unsigned int irq, unsigned long clr, unsigned long set)
 {

[PATCH 2/2][resend] genirq: export dummy_irq_chip

[Kuninori Morimoto]

Export dummy_irq_chip to modules to allow them to do things such as

	irq_set_chip_and_handler(virq,
				 &dummy_irq_chip,
				 handle_level_irq);
This fixes

	ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined!

when gpio-pcf857x.c is being built as a module.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 kernel/irq/dummychip.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/kernel/irq/dummychip.c b/kernel/irq/dummychip.c
index b5fcd96..988dc58 100644
--- a/kernel/irq/dummychip.c
+++ b/kernel/irq/dummychip.c
@@ -6,6 +6,7 @@
  */
 #include <linux/interrupt.h>
 #include <linux/irq.h>
+#include <linux/export.h>
 
 #include "internals.h"
 
@@ -57,3 +58,4 @@ struct irq_chip dummy_irq_chip = {
 	.irq_mask	= noop,
 	.irq_unmask	= noop,
 };
+EXPORT_SYMBOL_GPL(dummy_irq_chip);
-- 
1.7.5.4

[tip:irq/core] genirq: Export dummy_irq_chip

[tip-bot for Kuninori Morimoto]

Commit-ID:  17d83127d4c2b322dd8f217e0ac08c66eb403779
Gitweb:     http://git.kernel.org/tip/17d83127d4c2b322dd8f217e0ac08c66eb403779
Author:     Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
AuthorDate: Mon, 30 Jul 2012 22:39:20 -0700
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 21 Aug 2012 16:14:23 +0200

genirq: Export dummy_irq_chip

Export dummy_irq_chip to modules to allow them to do things such as

	irq_set_chip_and_handler(virq,
				 &dummy_irq_chip,
				 handle_level_irq);
This fixes

	ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined!

when gpio-pcf857x.c is being built as a module.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Greg KH <gregkh@linuxfoundation.org>
Link: http://lkml.kernel.org/r/871ujstrp6.wl%25kuninori.morimoto.gx@renesas.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 kernel/irq/dummychip.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/kernel/irq/dummychip.c b/kernel/irq/dummychip.c
index b5fcd96..988dc58 100644
--- a/kernel/irq/dummychip.c
+++ b/kernel/irq/dummychip.c
@@ -6,6 +6,7 @@
  */
 #include <linux/interrupt.h>
 #include <linux/irq.h>
+#include <linux/export.h>
 
 #include "internals.h"
 
@@ -57,3 +58,4 @@ struct irq_chip dummy_irq_chip = {
 	.irq_mask	= noop,
 	.irq_unmask	= noop,
 };
+EXPORT_SYMBOL_GPL(dummy_irq_chip);

Re: [PATCH 0/2][resend] genirq: export patches

[Kuninori Morimoto]

Hi all

> These are "resend" of genirq export patches.
> 
> Kuninori Morimoto (2):
>       genirq: export irq_set_chip_and_handler_name()
>       genirq: export dummy_irq_chip

get_maintainer.pl showed me that Thomas is the maintainer
of ${LINUX}/kernel/irq/,
but am I wrong ?
I think there is no response for these patches.

Who can care these patches ?
Should I resend again ?

> 
> 
> > 
> > Hi Thomas
> > 
> > Could you please teach me current status of these patches ?
> > 
> > Kuninori Morimoto (2):
> >       genirq: export irq_set_chip_and_handler_name()
> >       genirq: export dummy_irq_chip
> > 
> > At Mon, 9 Jul 2012 22:34:23 +0200,
> > Linus Walleij wrote:
> > > 
> > > On Mon, Jul 9, 2012 at 4:04 AM, Kuninori Morimoto
> > > <kuninori.morimoto.gx@renesas.com> wrote:
> > > 
> > > > Hi Linus Walleij, Stephen, and Thomas
> > > >
> > > >> >> > After merging the gpio-lw tree, today's linux-next build (x86_64
> > > >> >> > allmodconfig) failed like this:
> > > >> >> >
> > > >> >> > ERROR: "irq_set_chip_and_handler_name" [drivers/gpio/gpio-pcf857x.ko] undefined!
> > > >> >> > ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined!
> > > >> >>
> > > >> >> Thanks, I've dropped the offending patch, Kuninori can you look into this and
> > > >> >> provide a new patch? It's the second patch from your patch set.
> > > >> >
> > > >> > OK. I will, but it will be next week.
> > > >> > And could you please show me where is your repository/branch ?
> > > >>
> > > >> http://git.kernel.org/?p=linux/kernel/git/linusw/linux-gpio.git;a=summary
> > > >> branch devel/for-next
> > > >
> > > > In my check, these are export symbol issue.
> > > > I think above 2 function/struct were not exported for module.
> > > >
> > > > Is it poosible to solve this issue by these patches ?
> > > 
> > > Hm Thomas has to answer to that (and merge the patches, if he
> > > likes them).
> > > 
> > > Yours,
> > > Linus Walleij
> > 
> > 
> > Best regards
> > ---
> > Kuninori Morimoto


Best regards
---
Kuninori Morimoto

Re: [PATCH 0/2][resend] genirq: export patches

[Thomas Gleixner]

On Mon, 20 Aug 2012, Kuninori Morimoto wrote:
> 
> Hi all
> 
> > These are "resend" of genirq export patches.
> > 
> > Kuninori Morimoto (2):
> >       genirq: export irq_set_chip_and_handler_name()
> >       genirq: export dummy_irq_chip
> 
> get_maintainer.pl showed me that Thomas is the maintainer
> of ${LINUX}/kernel/irq/,
> but am I wrong ?
> I think there is no response for these patches.
> 
> Who can care these patches ?
> Should I resend again ?

I'll have a look. Was on vacation and travelling. Still fighting with
the mail backlog.

Thanks,

	tglx

Re: linux-next: build failure after merge of the gpio-lw tree

[Kuninori Morimoto]

Hi Linus W

> >> >> > After merging the gpio-lw tree, today's linux-next build (x86_64
> >> >> > allmodconfig) failed like this:
> >> >> >
> >> >> > ERROR: "irq_set_chip_and_handler_name" [drivers/gpio/gpio-pcf857x.ko] undefined!
> >> >> > ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined!
> >> >>
> >> >> Thanks, I've dropped the offending patch, Kuninori can you look into this and
> >> >> provide a new patch? It's the second patch from your patch set.
> >> >
> >> > OK. I will, but it will be next week.
> >> > And could you please show me where is your repository/branch ?
> >>
> >> http://git.kernel.org/?p=linux/kernel/git/linusw/linux-gpio.git;a=summary
> >> branch devel/for-next
> >
> > In my check, these are export symbol issue.
> > I think above 2 function/struct were not exported for module.
> >
> > Is it poosible to solve this issue by these patches ?
> 
> Hm Thomas has to answer to that (and merge the patches, if he
> likes them).

Now, these fixup patches were accepted.
  http://git.kernel.org/tip/17d83127d4c2b322dd8f217e0ac08c66eb403779
  http://git.kernel.org/tip/b3ae66f209e8929db62b5a5f874ab2cdcf5ef1d4

Could you please re-check this dropped patch ?
it was

[PATCH 2/2 v3][resend] gpio: pcf857x: enable gpio_to_irq() support
(https://lkml.org/lkml/2012/6/14/654)

I can resend this patch if you want

Best regards
---
Kuninori Morimoto

Re: linux-next: build failure after merge of the gpio-lw tree

[Linus Walleij]

On Wed, Aug 22, 2012 at 7:03 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:

> Now, these fixup patches were accepted.
>   http://git.kernel.org/tip/17d83127d4c2b322dd8f217e0ac08c66eb403779
>   http://git.kernel.org/tip/b3ae66f209e8929db62b5a5f874ab2cdcf5ef1d4
>
> Could you please re-check this dropped patch ?

Yes! I've applied it. Check that it lands nicely in -next.

Yours,
Linus Walleij

Re: linux-next: build failure after merge of the gpio-lw tree

[Kuninori Morimoto]

Hi Linus W

> > Now, these fixup patches were accepted.
> >   http://git.kernel.org/tip/17d83127d4c2b322dd8f217e0ac08c66eb403779
> >   http://git.kernel.org/tip/b3ae66f209e8929db62b5a5f874ab2cdcf5ef1d4
> >
> > Could you please re-check this dropped patch ?
> 
> Yes! I've applied it. Check that it lands nicely in -next.

Thank you !
It works on my board.

Best regards
---
Kuninori Morimoto

linux-next: build failure after merge of the gpio-lw tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 854 bytes --]

Hi Linus,

After merging the gpio-lw tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/gpio/devres.c:51:5: error: redefinition of 'devm_gpio_request'
include/linux/gpio.h:97:19: note: previous definition of 'devm_gpio_request' was here
drivers/gpio/devres.c:80:5: error: redefinition of 'devm_gpio_request_one'
include/linux/gpio.h:109:19: note: previous definition of 'devm_gpio_request_one' was here
drivers/gpio/devres.c:113:6: error: redefinition of 'devm_gpio_free'
include/linux/gpio.h:128:20: note: previous definition of 'devm_gpio_free' was here

Presumably caused by commit d39cd0301255 ("gpio: devm_gpio_* support
should not depend on GPIOLIB").

I have used the version of the gpio-lw tree from next-20130117 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the gpio-lw tree

[Shawn Guo]

On Fri, Jan 18, 2013 at 02:03:46PM +1100, Stephen Rothwell wrote:
> Hi Linus,
> 
> After merging the gpio-lw tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
My bad, sorry for that.  I just sent a v2 in reply to this message
for fixing the error.  I spent some time trying to install a ppc64
toolchain for testing, but unfortunately with on luck.  So Stephen,
I have to rely on linux-next to give it a test again.  Thanks.

Shawn

> drivers/gpio/devres.c:51:5: error: redefinition of 'devm_gpio_request'
> include/linux/gpio.h:97:19: note: previous definition of 'devm_gpio_request' was here
> drivers/gpio/devres.c:80:5: error: redefinition of 'devm_gpio_request_one'
> include/linux/gpio.h:109:19: note: previous definition of 'devm_gpio_request_one' was here
> drivers/gpio/devres.c:113:6: error: redefinition of 'devm_gpio_free'
> include/linux/gpio.h:128:20: note: previous definition of 'devm_gpio_free' was here
> 
> Presumably caused by commit d39cd0301255 ("gpio: devm_gpio_* support
> should not depend on GPIOLIB").

Re: linux-next: build failure after merge of the gpio-lw tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

Hi Shawn,

On Fri, 18 Jan 2013 16:02:13 +0800 Shawn Guo <shawn.guo@linaro.org> wrote:
>
> My bad, sorry for that.  I just sent a v2 in reply to this message
> for fixing the error.  I spent some time trying to install a ppc64
> toolchain for testing, but unfortunately with on luck.  So Stephen,
> I have to rely on linux-next to give it a test again.  Thanks.

Cross compilers suitable for building kernels are available at
http://www.kernel.org/pub/tools/crosstool/ .  However, in this case, you
probably just need to get the right combination of CONFIG options.  I
will give it a spin early next week.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the gpio-lw tree

[Shawn Guo]

On Sat, Jan 19, 2013 at 10:40:45AM +1100, Stephen Rothwell wrote:
> Hi Shawn,
> 
> On Fri, 18 Jan 2013 16:02:13 +0800 Shawn Guo <shawn.guo@linaro.org> wrote:
> >
> > My bad, sorry for that.  I just sent a v2 in reply to this message
> > for fixing the error.  I spent some time trying to install a ppc64
> > toolchain for testing, but unfortunately with on luck.  So Stephen,
> > I have to rely on linux-next to give it a test again.  Thanks.
> 
> Cross compilers suitable for building kernels are available at
> http://www.kernel.org/pub/tools/crosstool/ .

Thanks for the link, Stephen.  I installed the compiler and verified
that the v2 fixes the error.

Shawn

Re: linux-next: build failure after merge of the gpio-lw tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 864 bytes --]

Hi Shawn,

On Mon, 21 Jan 2013 14:20:13 +0800 Shawn Guo <shawn.guo@linaro.org> wrote:
>
> On Sat, Jan 19, 2013 at 10:40:45AM +1100, Stephen Rothwell wrote:
> > 
> > On Fri, 18 Jan 2013 16:02:13 +0800 Shawn Guo <shawn.guo@linaro.org> wrote:
> > >
> > > My bad, sorry for that.  I just sent a v2 in reply to this message
> > > for fixing the error.  I spent some time trying to install a ppc64
> > > toolchain for testing, but unfortunately with on luck.  So Stephen,
> > > I have to rely on linux-next to give it a test again.  Thanks.
> > 
> > Cross compilers suitable for building kernels are available at
> > http://www.kernel.org/pub/tools/crosstool/ .
> 
> Thanks for the link, Stephen.  I installed the compiler and verified
> that the v2 fixes the error.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]