* linux-next: build failure after merge of the gpio-lw tree @ 2012-07-06 6:14 Stephen Rothwell 2012-07-06 7:01 ` Linus Walleij 0 siblings, 1 reply; 19+ messages in thread From: Stephen Rothwell @ 2012-07-06 6:14 UTC (permalink / raw) To: Linus Walleij; +Cc: linux-next, linux-kernel, Kuninori Morimoto [-- Attachment #1: Type: text/plain, Size: 381 bytes --] Hi Linus, After merging the gpio-lw tree, today's linux-next build (x86_64 allmodconfig) failed like this: ERROR: "irq_set_chip_and_handler_name" [drivers/gpio/gpio-pcf857x.ko] undefined! ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined! I have dropped the gpio-lw tree for today. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au [-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: build failure after merge of the gpio-lw tree 2012-07-06 6:14 linux-next: build failure after merge of the gpio-lw tree Stephen Rothwell @ 2012-07-06 7:01 ` Linus Walleij 2012-07-06 8:55 ` Kuninori Morimoto 0 siblings, 1 reply; 19+ messages in thread From: Linus Walleij @ 2012-07-06 7:01 UTC (permalink / raw) To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Kuninori Morimoto On Fri, Jul 6, 2012 at 8:14 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote: > After merging the gpio-lw tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > ERROR: "irq_set_chip_and_handler_name" [drivers/gpio/gpio-pcf857x.ko] undefined! > ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined! Thanks, I've dropped the offending patch, Kuninori can you look into this and provide a new patch? It's the second patch from your patch set. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: build failure after merge of the gpio-lw tree 2012-07-06 7:01 ` Linus Walleij @ 2012-07-06 8:55 ` Kuninori Morimoto 2012-07-08 19:14 ` Linus Walleij 0 siblings, 1 reply; 19+ messages in thread From: Kuninori Morimoto @ 2012-07-06 8:55 UTC (permalink / raw) To: Linus Walleij; +Cc: Stephen Rothwell, linux-next, linux-kernel Dear Linus > > After merging the gpio-lw tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > ERROR: "irq_set_chip_and_handler_name" [drivers/gpio/gpio-pcf857x.ko] undefined! > > ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined! > > Thanks, I've dropped the offending patch, Kuninori can you look into this and > provide a new patch? It's the second patch from your patch set. OK. I will, but it will be next week. And could you please show me where is your repository/branch ? Best regards -- Kuninori Morimoto ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: build failure after merge of the gpio-lw tree 2012-07-06 8:55 ` Kuninori Morimoto @ 2012-07-08 19:14 ` Linus Walleij 2012-07-09 2:04 ` Kuninori Morimoto 0 siblings, 1 reply; 19+ messages in thread From: Linus Walleij @ 2012-07-08 19:14 UTC (permalink / raw) To: Kuninori Morimoto; +Cc: Stephen Rothwell, linux-next, linux-kernel On Fri, Jul 6, 2012 at 10:55 AM, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > > Dear Linus > >> > After merging the gpio-lw tree, today's linux-next build (x86_64 >> > allmodconfig) failed like this: >> > >> > ERROR: "irq_set_chip_and_handler_name" [drivers/gpio/gpio-pcf857x.ko] undefined! >> > ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined! >> >> Thanks, I've dropped the offending patch, Kuninori can you look into this and >> provide a new patch? It's the second patch from your patch set. > > OK. I will, but it will be next week. > And could you please show me where is your repository/branch ? http://git.kernel.org/?p=linux/kernel/git/linusw/linux-gpio.git;a=summary branch devel/for-next Linus Walleij ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: build failure after merge of the gpio-lw tree 2012-07-08 19:14 ` Linus Walleij @ 2012-07-09 2:04 ` Kuninori Morimoto 2012-07-09 2:05 ` [PATCH 1/2] genirq: export irq_set_chip_and_handler_name() Kuninori Morimoto ` (2 more replies) 0 siblings, 3 replies; 19+ messages in thread From: Kuninori Morimoto @ 2012-07-09 2:04 UTC (permalink / raw) To: Thomas Gleixner, Stephen Rothwell, Linus Walleij Cc: Kuninori Morimoto, linux-kernel, linux-next Hi Linus Walleij, Stephen, and Thomas > >> > After merging the gpio-lw tree, today's linux-next build (x86_64 > >> > allmodconfig) failed like this: > >> > > >> > ERROR: "irq_set_chip_and_handler_name" [drivers/gpio/gpio-pcf857x.ko] undefined! > >> > ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined! > >> > >> Thanks, I've dropped the offending patch, Kuninori can you look into this and > >> provide a new patch? It's the second patch from your patch set. > > > > OK. I will, but it will be next week. > > And could you please show me where is your repository/branch ? > > http://git.kernel.org/?p=linux/kernel/git/linusw/linux-gpio.git;a=summary > branch devel/for-next In my check, these are export symbol issue. I think above 2 function/struct were not exported for module. Is it poosible to solve this issue by these patches ? Kuninori Morimoto (2): genirq: export irq_set_chip_and_handler_name() genirq: export dummy_irq_chip kernel/irq/chip.c | 1 + kernel/irq/dummychip.c | 2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) Best regards --- Kuninori Morimoto ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 1/2] genirq: export irq_set_chip_and_handler_name() 2012-07-09 2:04 ` Kuninori Morimoto @ 2012-07-09 2:05 ` Kuninori Morimoto 2012-07-09 2:06 ` [PATCH 2/2] genirq: export dummy_irq_chip Kuninori Morimoto 2012-07-09 20:34 ` linux-next: build failure after merge of the gpio-lw tree Linus Walleij 2 siblings, 0 replies; 19+ messages in thread From: Kuninori Morimoto @ 2012-07-09 2:05 UTC (permalink / raw) To: Thomas Gleixner, Stephen Rothwell, Linus Walleij Cc: Kuninori Morimoto, linux-kernel, linux-next Export irq_set_chip_and_handler_name() to modules to allow them to do things such as irq_set_chip_and_handler(virq, &dummy_irq_chip, handle_level_irq); This fixes ERROR: "irq_set_chip_and_handler_name" \ [drivers/gpio/gpio-pcf857x.ko] undefined! when gpio-pcf857x.c is being built as a module. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- kernel/irq/chip.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c index eebd6d5..57d86d0 100644 --- a/kernel/irq/chip.c +++ b/kernel/irq/chip.c @@ -671,6 +671,7 @@ irq_set_chip_and_handler_name(unsigned int irq, struct irq_chip *chip, irq_set_chip(irq, chip); __irq_set_handler(irq, handle, 0, name); } +EXPORT_SYMBOL_GPL(irq_set_chip_and_handler_name); void irq_modify_status(unsigned int irq, unsigned long clr, unsigned long set) { -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 2/2] genirq: export dummy_irq_chip 2012-07-09 2:04 ` Kuninori Morimoto 2012-07-09 2:05 ` [PATCH 1/2] genirq: export irq_set_chip_and_handler_name() Kuninori Morimoto @ 2012-07-09 2:06 ` Kuninori Morimoto 2012-07-09 20:34 ` linux-next: build failure after merge of the gpio-lw tree Linus Walleij 2 siblings, 0 replies; 19+ messages in thread From: Kuninori Morimoto @ 2012-07-09 2:06 UTC (permalink / raw) To: Thomas Gleixner, Stephen Rothwell, Linus Walleij Cc: Kuninori Morimoto, linux-kernel, linux-next Export dummy_irq_chip to modules to allow them to do things such as irq_set_chip_and_handler(virq, &dummy_irq_chip, handle_level_irq); This fixes ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined! when gpio-pcf857x.c is being built as a module. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- kernel/irq/dummychip.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/kernel/irq/dummychip.c b/kernel/irq/dummychip.c index b5fcd96..988dc58 100644 --- a/kernel/irq/dummychip.c +++ b/kernel/irq/dummychip.c @@ -6,6 +6,7 @@ */ #include <linux/interrupt.h> #include <linux/irq.h> +#include <linux/export.h> #include "internals.h" @@ -57,3 +58,4 @@ struct irq_chip dummy_irq_chip = { .irq_mask = noop, .irq_unmask = noop, }; +EXPORT_SYMBOL_GPL(dummy_irq_chip); -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: linux-next: build failure after merge of the gpio-lw tree 2012-07-09 2:04 ` Kuninori Morimoto 2012-07-09 2:05 ` [PATCH 1/2] genirq: export irq_set_chip_and_handler_name() Kuninori Morimoto 2012-07-09 2:06 ` [PATCH 2/2] genirq: export dummy_irq_chip Kuninori Morimoto @ 2012-07-09 20:34 ` Linus Walleij 2012-07-24 3:56 ` Kuninori Morimoto 2012-08-22 5:03 ` linux-next: build failure after merge of the gpio-lw tree Kuninori Morimoto 2 siblings, 2 replies; 19+ messages in thread From: Linus Walleij @ 2012-07-09 20:34 UTC (permalink / raw) To: Kuninori Morimoto Cc: Thomas Gleixner, Stephen Rothwell, Kuninori Morimoto, linux-kernel, linux-next On Mon, Jul 9, 2012 at 4:04 AM, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > Hi Linus Walleij, Stephen, and Thomas > >> >> > After merging the gpio-lw tree, today's linux-next build (x86_64 >> >> > allmodconfig) failed like this: >> >> > >> >> > ERROR: "irq_set_chip_and_handler_name" [drivers/gpio/gpio-pcf857x.ko] undefined! >> >> > ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined! >> >> >> >> Thanks, I've dropped the offending patch, Kuninori can you look into this and >> >> provide a new patch? It's the second patch from your patch set. >> > >> > OK. I will, but it will be next week. >> > And could you please show me where is your repository/branch ? >> >> http://git.kernel.org/?p=linux/kernel/git/linusw/linux-gpio.git;a=summary >> branch devel/for-next > > In my check, these are export symbol issue. > I think above 2 function/struct were not exported for module. > > Is it poosible to solve this issue by these patches ? Hm Thomas has to answer to that (and merge the patches, if he likes them). Yours, Linus Walleij ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: build failure after merge of the gpio-lw tree 2012-07-09 20:34 ` linux-next: build failure after merge of the gpio-lw tree Linus Walleij @ 2012-07-24 3:56 ` Kuninori Morimoto 2012-07-31 5:38 ` [PATCH 0/2][resend] genirq: export patches Kuninori Morimoto 2012-08-22 5:03 ` linux-next: build failure after merge of the gpio-lw tree Kuninori Morimoto 1 sibling, 1 reply; 19+ messages in thread From: Kuninori Morimoto @ 2012-07-24 3:56 UTC (permalink / raw) To: Linus Walleij Cc: Thomas Gleixner, Stephen Rothwell, Kuninori Morimoto, linux-kernel, linux-next Hi Thomas Could you please teach me current status of these patches ? Kuninori Morimoto (2): genirq: export irq_set_chip_and_handler_name() genirq: export dummy_irq_chip At Mon, 9 Jul 2012 22:34:23 +0200, Linus Walleij wrote: > > On Mon, Jul 9, 2012 at 4:04 AM, Kuninori Morimoto > <kuninori.morimoto.gx@renesas.com> wrote: > > > Hi Linus Walleij, Stephen, and Thomas > > > >> >> > After merging the gpio-lw tree, today's linux-next build (x86_64 > >> >> > allmodconfig) failed like this: > >> >> > > >> >> > ERROR: "irq_set_chip_and_handler_name" [drivers/gpio/gpio-pcf857x.ko] undefined! > >> >> > ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined! > >> >> > >> >> Thanks, I've dropped the offending patch, Kuninori can you look into this and > >> >> provide a new patch? It's the second patch from your patch set. > >> > > >> > OK. I will, but it will be next week. > >> > And could you please show me where is your repository/branch ? > >> > >> http://git.kernel.org/?p=linux/kernel/git/linusw/linux-gpio.git;a=summary > >> branch devel/for-next > > > > In my check, these are export symbol issue. > > I think above 2 function/struct were not exported for module. > > > > Is it poosible to solve this issue by these patches ? > > Hm Thomas has to answer to that (and merge the patches, if he > likes them). > > Yours, > Linus Walleij Best regards --- Kuninori Morimoto ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 0/2][resend] genirq: export patches 2012-07-24 3:56 ` Kuninori Morimoto @ 2012-07-31 5:38 ` Kuninori Morimoto 2012-07-31 5:39 ` [PATCH 1/2][resend] genirq: export irq_set_chip_and_handler_name() Kuninori Morimoto ` (2 more replies) 0 siblings, 3 replies; 19+ messages in thread From: Kuninori Morimoto @ 2012-07-31 5:38 UTC (permalink / raw) To: Thomas Gleixner, Andrew Morton, Greg KH Cc: Linus Walleij, Stephen Rothwell, Kuninori Morimoto, linux-kernel, linux-next Hi all These are "resend" of genirq export patches. Kuninori Morimoto (2): genirq: export irq_set_chip_and_handler_name() genirq: export dummy_irq_chip > > Hi Thomas > > Could you please teach me current status of these patches ? > > Kuninori Morimoto (2): > genirq: export irq_set_chip_and_handler_name() > genirq: export dummy_irq_chip > > At Mon, 9 Jul 2012 22:34:23 +0200, > Linus Walleij wrote: > > > > On Mon, Jul 9, 2012 at 4:04 AM, Kuninori Morimoto > > <kuninori.morimoto.gx@renesas.com> wrote: > > > > > Hi Linus Walleij, Stephen, and Thomas > > > > > >> >> > After merging the gpio-lw tree, today's linux-next build (x86_64 > > >> >> > allmodconfig) failed like this: > > >> >> > > > >> >> > ERROR: "irq_set_chip_and_handler_name" [drivers/gpio/gpio-pcf857x.ko] undefined! > > >> >> > ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined! > > >> >> > > >> >> Thanks, I've dropped the offending patch, Kuninori can you look into this and > > >> >> provide a new patch? It's the second patch from your patch set. > > >> > > > >> > OK. I will, but it will be next week. > > >> > And could you please show me where is your repository/branch ? > > >> > > >> http://git.kernel.org/?p=linux/kernel/git/linusw/linux-gpio.git;a=summary > > >> branch devel/for-next > > > > > > In my check, these are export symbol issue. > > > I think above 2 function/struct were not exported for module. > > > > > > Is it poosible to solve this issue by these patches ? > > > > Hm Thomas has to answer to that (and merge the patches, if he > > likes them). > > > > Yours, > > Linus Walleij > > > Best regards > --- > Kuninori Morimoto ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 1/2][resend] genirq: export irq_set_chip_and_handler_name() 2012-07-31 5:38 ` [PATCH 0/2][resend] genirq: export patches Kuninori Morimoto @ 2012-07-31 5:39 ` Kuninori Morimoto 2012-08-21 16:38 ` [tip:irq/core] genirq: Export irq_set_chip_and_handler_name() tip-bot for Kuninori Morimoto 2012-07-31 5:39 ` [PATCH 2/2][resend] genirq: export dummy_irq_chip Kuninori Morimoto 2012-08-21 0:52 ` [PATCH 0/2][resend] genirq: export patches Kuninori Morimoto 2 siblings, 1 reply; 19+ messages in thread From: Kuninori Morimoto @ 2012-07-31 5:39 UTC (permalink / raw) To: Thomas Gleixner, Andrew Morton, Greg KH Cc: Linus Walleij, Stephen Rothwell, Kuninori Morimoto, linux-kernel, linux-next Export irq_set_chip_and_handler_name() to modules to allow them to do things such as irq_set_chip_and_handler(....); This fixes ERROR: "irq_set_chip_and_handler_name" \ [drivers/gpio/gpio-pcf857x.ko] undefined! when gpio-pcf857x.c is being built as a module. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- kernel/irq/chip.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c index eebd6d5..57d86d0 100644 --- a/kernel/irq/chip.c +++ b/kernel/irq/chip.c @@ -671,6 +671,7 @@ irq_set_chip_and_handler_name(unsigned int irq, struct irq_chip *chip, irq_set_chip(irq, chip); __irq_set_handler(irq, handle, 0, name); } +EXPORT_SYMBOL_GPL(irq_set_chip_and_handler_name); void irq_modify_status(unsigned int irq, unsigned long clr, unsigned long set) { -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [tip:irq/core] genirq: Export irq_set_chip_and_handler_name() 2012-07-31 5:39 ` [PATCH 1/2][resend] genirq: export irq_set_chip_and_handler_name() Kuninori Morimoto @ 2012-08-21 16:38 ` tip-bot for Kuninori Morimoto 0 siblings, 0 replies; 19+ messages in thread From: tip-bot for Kuninori Morimoto @ 2012-08-21 16:38 UTC (permalink / raw) To: linux-tip-commits Cc: linux-kernel, hpa, mingo, kuninori.morimoto.gx, gregkh, tglx, sfr, linus.walleij Commit-ID: b3ae66f209e8929db62b5a5f874ab2cdcf5ef1d4 Gitweb: http://git.kernel.org/tip/b3ae66f209e8929db62b5a5f874ab2cdcf5ef1d4 Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> AuthorDate: Mon, 30 Jul 2012 22:39:06 -0700 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Tue, 21 Aug 2012 16:14:23 +0200 genirq: Export irq_set_chip_and_handler_name() Export irq_set_chip_and_handler_name() to modules to allow them to do things such as irq_set_chip_and_handler(....); This fixes ERROR: "irq_set_chip_and_handler_name" \ [drivers/gpio/gpio-pcf857x.ko] undefined! when gpio-pcf857x.c is being built as a module. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Greg KH <gregkh@linuxfoundation.org> Link: http://lkml.kernel.org/r/873948trpk.wl%25kuninori.morimoto.gx@renesas.com Signed-off-by: Thomas Gleixner <tglx@linutronix.de> --- kernel/irq/chip.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c index eebd6d5..57d86d0 100644 --- a/kernel/irq/chip.c +++ b/kernel/irq/chip.c @@ -671,6 +671,7 @@ irq_set_chip_and_handler_name(unsigned int irq, struct irq_chip *chip, irq_set_chip(irq, chip); __irq_set_handler(irq, handle, 0, name); } +EXPORT_SYMBOL_GPL(irq_set_chip_and_handler_name); void irq_modify_status(unsigned int irq, unsigned long clr, unsigned long set) { ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 2/2][resend] genirq: export dummy_irq_chip 2012-07-31 5:38 ` [PATCH 0/2][resend] genirq: export patches Kuninori Morimoto 2012-07-31 5:39 ` [PATCH 1/2][resend] genirq: export irq_set_chip_and_handler_name() Kuninori Morimoto @ 2012-07-31 5:39 ` Kuninori Morimoto 2012-08-21 16:39 ` [tip:irq/core] genirq: Export dummy_irq_chip tip-bot for Kuninori Morimoto 2012-08-21 0:52 ` [PATCH 0/2][resend] genirq: export patches Kuninori Morimoto 2 siblings, 1 reply; 19+ messages in thread From: Kuninori Morimoto @ 2012-07-31 5:39 UTC (permalink / raw) To: Thomas Gleixner, Andrew Morton, Greg KH Cc: Linus Walleij, Stephen Rothwell, Kuninori Morimoto, linux-kernel, linux-next Export dummy_irq_chip to modules to allow them to do things such as irq_set_chip_and_handler(virq, &dummy_irq_chip, handle_level_irq); This fixes ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined! when gpio-pcf857x.c is being built as a module. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- kernel/irq/dummychip.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/kernel/irq/dummychip.c b/kernel/irq/dummychip.c index b5fcd96..988dc58 100644 --- a/kernel/irq/dummychip.c +++ b/kernel/irq/dummychip.c @@ -6,6 +6,7 @@ */ #include <linux/interrupt.h> #include <linux/irq.h> +#include <linux/export.h> #include "internals.h" @@ -57,3 +58,4 @@ struct irq_chip dummy_irq_chip = { .irq_mask = noop, .irq_unmask = noop, }; +EXPORT_SYMBOL_GPL(dummy_irq_chip); -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [tip:irq/core] genirq: Export dummy_irq_chip 2012-07-31 5:39 ` [PATCH 2/2][resend] genirq: export dummy_irq_chip Kuninori Morimoto @ 2012-08-21 16:39 ` tip-bot for Kuninori Morimoto 0 siblings, 0 replies; 19+ messages in thread From: tip-bot for Kuninori Morimoto @ 2012-08-21 16:39 UTC (permalink / raw) To: linux-tip-commits Cc: linux-kernel, hpa, mingo, kuninori.morimoto.gx, gregkh, tglx, sfr, linus.walleij Commit-ID: 17d83127d4c2b322dd8f217e0ac08c66eb403779 Gitweb: http://git.kernel.org/tip/17d83127d4c2b322dd8f217e0ac08c66eb403779 Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> AuthorDate: Mon, 30 Jul 2012 22:39:20 -0700 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Tue, 21 Aug 2012 16:14:23 +0200 genirq: Export dummy_irq_chip Export dummy_irq_chip to modules to allow them to do things such as irq_set_chip_and_handler(virq, &dummy_irq_chip, handle_level_irq); This fixes ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined! when gpio-pcf857x.c is being built as a module. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Greg KH <gregkh@linuxfoundation.org> Link: http://lkml.kernel.org/r/871ujstrp6.wl%25kuninori.morimoto.gx@renesas.com Signed-off-by: Thomas Gleixner <tglx@linutronix.de> --- kernel/irq/dummychip.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/kernel/irq/dummychip.c b/kernel/irq/dummychip.c index b5fcd96..988dc58 100644 --- a/kernel/irq/dummychip.c +++ b/kernel/irq/dummychip.c @@ -6,6 +6,7 @@ */ #include <linux/interrupt.h> #include <linux/irq.h> +#include <linux/export.h> #include "internals.h" @@ -57,3 +58,4 @@ struct irq_chip dummy_irq_chip = { .irq_mask = noop, .irq_unmask = noop, }; +EXPORT_SYMBOL_GPL(dummy_irq_chip); ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 0/2][resend] genirq: export patches 2012-07-31 5:38 ` [PATCH 0/2][resend] genirq: export patches Kuninori Morimoto 2012-07-31 5:39 ` [PATCH 1/2][resend] genirq: export irq_set_chip_and_handler_name() Kuninori Morimoto 2012-07-31 5:39 ` [PATCH 2/2][resend] genirq: export dummy_irq_chip Kuninori Morimoto @ 2012-08-21 0:52 ` Kuninori Morimoto 2012-08-21 9:34 ` Thomas Gleixner 2 siblings, 1 reply; 19+ messages in thread From: Kuninori Morimoto @ 2012-08-21 0:52 UTC (permalink / raw) To: Thomas Gleixner Cc: Andrew Morton, Greg KH, Linus Walleij, Stephen Rothwell, Kuninori Morimoto, linux-kernel Hi all > These are "resend" of genirq export patches. > > Kuninori Morimoto (2): > genirq: export irq_set_chip_and_handler_name() > genirq: export dummy_irq_chip get_maintainer.pl showed me that Thomas is the maintainer of ${LINUX}/kernel/irq/, but am I wrong ? I think there is no response for these patches. Who can care these patches ? Should I resend again ? > > > > > > Hi Thomas > > > > Could you please teach me current status of these patches ? > > > > Kuninori Morimoto (2): > > genirq: export irq_set_chip_and_handler_name() > > genirq: export dummy_irq_chip > > > > At Mon, 9 Jul 2012 22:34:23 +0200, > > Linus Walleij wrote: > > > > > > On Mon, Jul 9, 2012 at 4:04 AM, Kuninori Morimoto > > > <kuninori.morimoto.gx@renesas.com> wrote: > > > > > > > Hi Linus Walleij, Stephen, and Thomas > > > > > > > >> >> > After merging the gpio-lw tree, today's linux-next build (x86_64 > > > >> >> > allmodconfig) failed like this: > > > >> >> > > > > >> >> > ERROR: "irq_set_chip_and_handler_name" [drivers/gpio/gpio-pcf857x.ko] undefined! > > > >> >> > ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined! > > > >> >> > > > >> >> Thanks, I've dropped the offending patch, Kuninori can you look into this and > > > >> >> provide a new patch? It's the second patch from your patch set. > > > >> > > > > >> > OK. I will, but it will be next week. > > > >> > And could you please show me where is your repository/branch ? > > > >> > > > >> http://git.kernel.org/?p=linux/kernel/git/linusw/linux-gpio.git;a=summary > > > >> branch devel/for-next > > > > > > > > In my check, these are export symbol issue. > > > > I think above 2 function/struct were not exported for module. > > > > > > > > Is it poosible to solve this issue by these patches ? > > > > > > Hm Thomas has to answer to that (and merge the patches, if he > > > likes them). > > > > > > Yours, > > > Linus Walleij > > > > > > Best regards > > --- > > Kuninori Morimoto Best regards --- Kuninori Morimoto ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 0/2][resend] genirq: export patches 2012-08-21 0:52 ` [PATCH 0/2][resend] genirq: export patches Kuninori Morimoto @ 2012-08-21 9:34 ` Thomas Gleixner 0 siblings, 0 replies; 19+ messages in thread From: Thomas Gleixner @ 2012-08-21 9:34 UTC (permalink / raw) To: Kuninori Morimoto Cc: Andrew Morton, Greg KH, Linus Walleij, Stephen Rothwell, Kuninori Morimoto, linux-kernel On Mon, 20 Aug 2012, Kuninori Morimoto wrote: > > Hi all > > > These are "resend" of genirq export patches. > > > > Kuninori Morimoto (2): > > genirq: export irq_set_chip_and_handler_name() > > genirq: export dummy_irq_chip > > get_maintainer.pl showed me that Thomas is the maintainer > of ${LINUX}/kernel/irq/, > but am I wrong ? > I think there is no response for these patches. > > Who can care these patches ? > Should I resend again ? I'll have a look. Was on vacation and travelling. Still fighting with the mail backlog. Thanks, tglx ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: build failure after merge of the gpio-lw tree 2012-07-09 20:34 ` linux-next: build failure after merge of the gpio-lw tree Linus Walleij 2012-07-24 3:56 ` Kuninori Morimoto @ 2012-08-22 5:03 ` Kuninori Morimoto 2012-08-23 21:43 ` Linus Walleij 1 sibling, 1 reply; 19+ messages in thread From: Kuninori Morimoto @ 2012-08-22 5:03 UTC (permalink / raw) To: Linus Walleij Cc: Thomas Gleixner, Stephen Rothwell, Kuninori Morimoto, linux-kernel, linux-next Hi Linus W > >> >> > After merging the gpio-lw tree, today's linux-next build (x86_64 > >> >> > allmodconfig) failed like this: > >> >> > > >> >> > ERROR: "irq_set_chip_and_handler_name" [drivers/gpio/gpio-pcf857x.ko] undefined! > >> >> > ERROR: "dummy_irq_chip" [drivers/gpio/gpio-pcf857x.ko] undefined! > >> >> > >> >> Thanks, I've dropped the offending patch, Kuninori can you look into this and > >> >> provide a new patch? It's the second patch from your patch set. > >> > > >> > OK. I will, but it will be next week. > >> > And could you please show me where is your repository/branch ? > >> > >> http://git.kernel.org/?p=linux/kernel/git/linusw/linux-gpio.git;a=summary > >> branch devel/for-next > > > > In my check, these are export symbol issue. > > I think above 2 function/struct were not exported for module. > > > > Is it poosible to solve this issue by these patches ? > > Hm Thomas has to answer to that (and merge the patches, if he > likes them). Now, these fixup patches were accepted. http://git.kernel.org/tip/17d83127d4c2b322dd8f217e0ac08c66eb403779 http://git.kernel.org/tip/b3ae66f209e8929db62b5a5f874ab2cdcf5ef1d4 Could you please re-check this dropped patch ? it was [PATCH 2/2 v3][resend] gpio: pcf857x: enable gpio_to_irq() support (https://lkml.org/lkml/2012/6/14/654) I can resend this patch if you want Best regards --- Kuninori Morimoto ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: build failure after merge of the gpio-lw tree 2012-08-22 5:03 ` linux-next: build failure after merge of the gpio-lw tree Kuninori Morimoto @ 2012-08-23 21:43 ` Linus Walleij 2012-08-27 1:16 ` Kuninori Morimoto 0 siblings, 1 reply; 19+ messages in thread From: Linus Walleij @ 2012-08-23 21:43 UTC (permalink / raw) To: Kuninori Morimoto Cc: Thomas Gleixner, Stephen Rothwell, Kuninori Morimoto, linux-kernel, linux-next On Wed, Aug 22, 2012 at 7:03 AM, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > Now, these fixup patches were accepted. > http://git.kernel.org/tip/17d83127d4c2b322dd8f217e0ac08c66eb403779 > http://git.kernel.org/tip/b3ae66f209e8929db62b5a5f874ab2cdcf5ef1d4 > > Could you please re-check this dropped patch ? Yes! I've applied it. Check that it lands nicely in -next. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: build failure after merge of the gpio-lw tree 2012-08-23 21:43 ` Linus Walleij @ 2012-08-27 1:16 ` Kuninori Morimoto 0 siblings, 0 replies; 19+ messages in thread From: Kuninori Morimoto @ 2012-08-27 1:16 UTC (permalink / raw) To: Linus Walleij Cc: Thomas Gleixner, Stephen Rothwell, Kuninori Morimoto, linux-kernel, linux-next Hi Linus W > > Now, these fixup patches were accepted. > > http://git.kernel.org/tip/17d83127d4c2b322dd8f217e0ac08c66eb403779 > > http://git.kernel.org/tip/b3ae66f209e8929db62b5a5f874ab2cdcf5ef1d4 > > > > Could you please re-check this dropped patch ? > > Yes! I've applied it. Check that it lands nicely in -next. Thank you ! It works on my board. Best regards --- Kuninori Morimoto ^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2012-08-27 1:17 UTC | newest] Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2012-07-06 6:14 linux-next: build failure after merge of the gpio-lw tree Stephen Rothwell 2012-07-06 7:01 ` Linus Walleij 2012-07-06 8:55 ` Kuninori Morimoto 2012-07-08 19:14 ` Linus Walleij 2012-07-09 2:04 ` Kuninori Morimoto 2012-07-09 2:05 ` [PATCH 1/2] genirq: export irq_set_chip_and_handler_name() Kuninori Morimoto 2012-07-09 2:06 ` [PATCH 2/2] genirq: export dummy_irq_chip Kuninori Morimoto 2012-07-09 20:34 ` linux-next: build failure after merge of the gpio-lw tree Linus Walleij 2012-07-24 3:56 ` Kuninori Morimoto 2012-07-31 5:38 ` [PATCH 0/2][resend] genirq: export patches Kuninori Morimoto 2012-07-31 5:39 ` [PATCH 1/2][resend] genirq: export irq_set_chip_and_handler_name() Kuninori Morimoto 2012-08-21 16:38 ` [tip:irq/core] genirq: Export irq_set_chip_and_handler_name() tip-bot for Kuninori Morimoto 2012-07-31 5:39 ` [PATCH 2/2][resend] genirq: export dummy_irq_chip Kuninori Morimoto 2012-08-21 16:39 ` [tip:irq/core] genirq: Export dummy_irq_chip tip-bot for Kuninori Morimoto 2012-08-21 0:52 ` [PATCH 0/2][resend] genirq: export patches Kuninori Morimoto 2012-08-21 9:34 ` Thomas Gleixner 2012-08-22 5:03 ` linux-next: build failure after merge of the gpio-lw tree Kuninori Morimoto 2012-08-23 21:43 ` Linus Walleij 2012-08-27 1:16 ` Kuninori Morimoto
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).