From: Linus Walleij <linus.walleij@linaro.org>
To: Lewis.Hanly@microchip.com
Cc: linux-riscv@lists.infradead.org, Conor.Dooley@microchip.com,
brgl@bgdev.pl, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, palmer@dabbelt.com, maz@kernel.org,
Daire.McNamara@microchip.com
Subject: Re: [PATCH v6 1/1] gpio: mpfs: add polarfire soc gpio support
Date: Tue, 6 Sep 2022 15:09:32 +0200 [thread overview]
Message-ID: <CACRpkdYiLqiK9bzYoOX-fz3cCdojDjQj-amsQYQRcF2HVUWzqg@mail.gmail.com> (raw)
In-Reply-To: <23d74882a69b39025005495886faec3e5b129ba7.camel@microchip.com>
On Mon, Sep 5, 2022 at 12:45 PM <Lewis.Hanly@microchip.com> wrote:
> On Wed, 2022-08-31 at 15:19 +0200, Linus Walleij wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > know the content is safe
> >
> > On Tue, Aug 30, 2022 at 6:51 AM <Lewis.Hanly@microchip.com> wrote:
> >
> > > We had looked at the bpgpio_init, our controller is not fully
> > > memory
> > > mapped to support the bgpio_init() and get all routines for free.
> > > While we have in/out and intr (interrupt state) 32-bit registers,
> > > we
> > > would not get as much free as other generic memory mapped
> > > controllers.
> >
> > You're not really saying what the problem is?
> >
> > Is it that some registers are not one-bit-indexed from 0 per GPIO?
> Yes some of the registers are not one-bit-indexed per GPIO and for this
> reason we had not implemented bgpio_init().
OK that's a valid reason not to use that. Thanks!
The regmap may help though, have a look!
Yours,
Linus Walleij
next prev parent reply other threads:[~2022-09-06 13:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 12:08 [PATCH v6 0/1] Add Polarfire SoC GPIO support lewis.hanly
2022-08-15 12:08 ` [PATCH v6 1/1] gpio: mpfs: add polarfire soc gpio support lewis.hanly
2022-08-15 16:18 ` Conor.Dooley
2022-08-22 11:28 ` Linus Walleij
2022-08-30 4:50 ` Lewis.Hanly
2022-08-31 13:19 ` Linus Walleij
2022-09-05 10:45 ` Lewis.Hanly
2022-09-06 13:09 ` Linus Walleij [this message]
2022-08-31 21:04 ` Andy Shevchenko
2022-09-05 10:46 ` Lewis.Hanly
2022-08-15 12:16 ` [PATCH v6 0/1] Add Polarfire SoC GPIO support Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYiLqiK9bzYoOX-fz3cCdojDjQj-amsQYQRcF2HVUWzqg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=Conor.Dooley@microchip.com \
--cc=Daire.McNamara@microchip.com \
--cc=Lewis.Hanly@microchip.com \
--cc=brgl@bgdev.pl \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=maz@kernel.org \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).