From: Linus Walleij <linus.walleij@linaro.org>
To: lewis.hanly@microchip.com
Cc: linux-gpio@vger.kernel.org, linux-riscv@lists.infradead.org,
brgl@bgdev.pl, linux-kernel@vger.kernel.org, palmer@dabbelt.com,
maz@kernel.org, conor.dooley@microchip.com,
daire.mcnamara@microchip.com
Subject: Re: [PATCH v6 1/1] gpio: mpfs: add polarfire soc gpio support
Date: Mon, 22 Aug 2022 13:28:28 +0200 [thread overview]
Message-ID: <CACRpkdbk_ZqYnDzXgmbnAxhs+mEe9f2X-y++9HDS-O=UO_tUmg@mail.gmail.com> (raw)
In-Reply-To: <20220815120834.1562544-2-lewis.hanly@microchip.com>
On Mon, Aug 15, 2022 at 2:08 PM <lewis.hanly@microchip.com> wrote:
> From: Lewis Hanly <lewis.hanly@microchip.com>
>
> Add a driver to support the Polarfire SoC gpio controller
>
> Signed-off-by: Lewis Hanly <lewis.hanly@microchip.com>
This looks like textbook example of a driver that can use
CONFIG_GPIO_GENERIC
> +config GPIO_POLARFIRE_SOC
> + bool "Microchip FPGA GPIO support"
> + depends on OF_GPIO
> + select GPIOLIB_IRQCHIP
select GPIO_GENERIC
See e.g. drivers/gpio/gpio-ftgpio010.c for an example
of how to use bgpio_init() to set up the helper library to handle
the GPIO side of things and combine it with an irqchip.
You get get/set_multiple() for free with this approach.
Also see documentation for bgpio_init() in
drivers/gpio/gpio-mmio.c.
Yours,
Linus Walleij
next prev parent reply other threads:[~2022-08-22 11:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 12:08 [PATCH v6 0/1] Add Polarfire SoC GPIO support lewis.hanly
2022-08-15 12:08 ` [PATCH v6 1/1] gpio: mpfs: add polarfire soc gpio support lewis.hanly
2022-08-15 16:18 ` Conor.Dooley
2022-08-22 11:28 ` Linus Walleij [this message]
2022-08-30 4:50 ` Lewis.Hanly
2022-08-31 13:19 ` Linus Walleij
2022-09-05 10:45 ` Lewis.Hanly
2022-09-06 13:09 ` Linus Walleij
2022-08-31 21:04 ` Andy Shevchenko
2022-09-05 10:46 ` Lewis.Hanly
2022-08-15 12:16 ` [PATCH v6 0/1] Add Polarfire SoC GPIO support Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbk_ZqYnDzXgmbnAxhs+mEe9f2X-y++9HDS-O=UO_tUmg@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=brgl@bgdev.pl \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=lewis.hanly@microchip.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=maz@kernel.org \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).