* [PATCH 1/2] pinctrl: uniphier: prohibit drive control for pin 61-66 of PH1-LD11
2016-06-15 8:18 [PATCH 0/2] pinctrl: uniphier: two more fixes for UniPhier pin data Masahiro Yamada
@ 2016-06-15 8:18 ` Masahiro Yamada
2016-06-18 8:02 ` Linus Walleij
2016-06-15 8:18 ` [PATCH 2/2] pinctrl: uniphier: fix meaningless drive control offsets Masahiro Yamada
1 sibling, 1 reply; 5+ messages in thread
From: Masahiro Yamada @ 2016-06-15 8:18 UTC (permalink / raw)
To: linux-gpio; +Cc: Masahiro Yamada, Linus Walleij, linux-arm-kernel, linux-kernel
According to the hardware document, setting the drive control is
prohibited for these pins (N-channel Open Drain pins). Set their
drive control attribute to "fixed".
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/pinctrl/uniphier/pinctrl-uniphier-ld11.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/pinctrl/uniphier/pinctrl-uniphier-ld11.c b/drivers/pinctrl/uniphier/pinctrl-uniphier-ld11.c
index 150942f..608cd73 100644
--- a/drivers/pinctrl/uniphier/pinctrl-uniphier-ld11.c
+++ b/drivers/pinctrl/uniphier/pinctrl-uniphier-ld11.c
@@ -151,22 +151,22 @@ static const struct pinctrl_pin_desc uniphier_ld11_pins[] = {
60, UNIPHIER_PIN_DRV_1BIT,
60, UNIPHIER_PIN_PULL_DOWN),
UNIPHIER_PINCTRL_PIN(61, "DMDSDA0", 61,
- 61, UNIPHIER_PIN_DRV_1BIT,
+ -1, UNIPHIER_PIN_DRV_FIXED4,
-1, UNIPHIER_PIN_PULL_NONE),
UNIPHIER_PINCTRL_PIN(62, "DMDSCL0", 62,
- 62, UNIPHIER_PIN_DRV_1BIT,
+ -1, UNIPHIER_PIN_DRV_FIXED4,
-1, UNIPHIER_PIN_PULL_NONE),
UNIPHIER_PINCTRL_PIN(63, "SDA0", 63,
- 63, UNIPHIER_PIN_DRV_1BIT,
+ -1, UNIPHIER_PIN_DRV_FIXED4,
-1, UNIPHIER_PIN_PULL_NONE),
UNIPHIER_PINCTRL_PIN(64, "SCL0", 64,
- 64, UNIPHIER_PIN_DRV_1BIT,
+ -1, UNIPHIER_PIN_DRV_FIXED4,
-1, UNIPHIER_PIN_PULL_NONE),
UNIPHIER_PINCTRL_PIN(65, "SDA1", 65,
- 65, UNIPHIER_PIN_DRV_1BIT,
+ -1, UNIPHIER_PIN_DRV_FIXED4,
-1, UNIPHIER_PIN_PULL_NONE),
UNIPHIER_PINCTRL_PIN(66, "SCL1", 66,
- 66, UNIPHIER_PIN_DRV_1BIT,
+ -1, UNIPHIER_PIN_DRV_FIXED4,
-1, UNIPHIER_PIN_PULL_NONE),
UNIPHIER_PINCTRL_PIN(67, "HIN", 67,
-1, UNIPHIER_PIN_DRV_FIXED5,
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] pinctrl: uniphier: fix meaningless drive control offsets
2016-06-15 8:18 [PATCH 0/2] pinctrl: uniphier: two more fixes for UniPhier pin data Masahiro Yamada
2016-06-15 8:18 ` [PATCH 1/2] pinctrl: uniphier: prohibit drive control for pin 61-66 of PH1-LD11 Masahiro Yamada
@ 2016-06-15 8:18 ` Masahiro Yamada
2016-06-18 8:03 ` Linus Walleij
1 sibling, 1 reply; 5+ messages in thread
From: Masahiro Yamada @ 2016-06-15 8:18 UTC (permalink / raw)
To: linux-gpio; +Cc: Masahiro Yamada, Linus Walleij, linux-arm-kernel, linux-kernel
These are input-only pins. They do not support drive controlling
in the first place.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c b/drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c
index 8c61493..002bd6e 100644
--- a/drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c
+++ b/drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c
@@ -138,7 +138,7 @@ static const struct pinctrl_pin_desc uniphier_pro4_pins[] = {
38, UNIPHIER_PIN_DRV_1BIT,
38, UNIPHIER_PIN_PULL_DOWN),
UNIPHIER_PINCTRL_PIN(39, "BOOTSWAP", UNIPHIER_PIN_IECTRL_NONE,
- 39, UNIPHIER_PIN_DRV_NONE,
+ -1, UNIPHIER_PIN_DRV_NONE,
39, UNIPHIER_PIN_PULL_UP),
UNIPHIER_PINCTRL_PIN(40, "NFD0", UNIPHIER_PIN_IECTRL_NONE,
2, UNIPHIER_PIN_DRV_2BIT,
@@ -639,7 +639,7 @@ static const struct pinctrl_pin_desc uniphier_pro4_pins[] = {
191, UNIPHIER_PIN_DRV_1BIT,
191, UNIPHIER_PIN_PULL_DOWN),
UNIPHIER_PINCTRL_PIN(206, "CLK54I", UNIPHIER_PIN_IECTRL_NONE,
- 192, UNIPHIER_PIN_DRV_NONE,
+ -1, UNIPHIER_PIN_DRV_NONE,
192, UNIPHIER_PIN_PULL_DOWN),
UNIPHIER_PINCTRL_PIN(207, "YIN0", UNIPHIER_PIN_IECTRL_NONE,
193, UNIPHIER_PIN_DRV_1BIT,
@@ -1005,7 +1005,7 @@ static const struct pinctrl_pin_desc uniphier_pro4_pins[] = {
311, UNIPHIER_PIN_DRV_1BIT,
311, UNIPHIER_PIN_PULL_UP),
UNIPHIER_PINCTRL_PIN(328, "DMDISO", UNIPHIER_PIN_IECTRL_NONE,
- 312, UNIPHIER_PIN_DRV_NONE,
+ -1, UNIPHIER_PIN_DRV_NONE,
312, UNIPHIER_PIN_PULL_DOWN),
};
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread