* [PATCH -next] pinctrl: fsl: Make pinctrl_ipc_handle static
@ 2019-03-20 14:14 Yue Haibing
2019-03-20 19:58 ` Mukesh Ojha
2019-04-04 5:17 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Yue Haibing @ 2019-03-20 14:14 UTC (permalink / raw)
To: aisheng.dong, festevam, shawnguo, stefan, kernel, linus.walleij
Cc: linux-kernel, linux-gpio, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warning:
drivers/pinctrl/freescale/pinctrl-scu.c:38:19: warning:
symbol 'pinctrl_ipc_handle' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/pinctrl/freescale/pinctrl-scu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/freescale/pinctrl-scu.c b/drivers/pinctrl/freescale/pinctrl-scu.c
index 83e69c0..73bf1d9 100644
--- a/drivers/pinctrl/freescale/pinctrl-scu.c
+++ b/drivers/pinctrl/freescale/pinctrl-scu.c
@@ -35,7 +35,7 @@ struct imx_sc_msg_resp_pad_get {
u32 val;
} __packed;
-struct imx_sc_ipc *pinctrl_ipc_handle;
+static struct imx_sc_ipc *pinctrl_ipc_handle;
int imx_pinctrl_sc_ipc_init(struct platform_device *pdev)
{
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] pinctrl: fsl: Make pinctrl_ipc_handle static
2019-03-20 14:14 [PATCH -next] pinctrl: fsl: Make pinctrl_ipc_handle static Yue Haibing
@ 2019-03-20 19:58 ` Mukesh Ojha
2019-04-04 5:17 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Mukesh Ojha @ 2019-03-20 19:58 UTC (permalink / raw)
To: Yue Haibing, aisheng.dong, festevam, shawnguo, stefan, kernel,
linus.walleij
Cc: linux-kernel, linux-gpio
On 3/20/2019 7:44 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/pinctrl/freescale/pinctrl-scu.c:38:19: warning:
> symbol 'pinctrl_ipc_handle' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/pinctrl/freescale/pinctrl-scu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/freescale/pinctrl-scu.c b/drivers/pinctrl/freescale/pinctrl-scu.c
> index 83e69c0..73bf1d9 100644
> --- a/drivers/pinctrl/freescale/pinctrl-scu.c
> +++ b/drivers/pinctrl/freescale/pinctrl-scu.c
> @@ -35,7 +35,7 @@ struct imx_sc_msg_resp_pad_get {
> u32 val;
> } __packed;
>
> -struct imx_sc_ipc *pinctrl_ipc_handle;
> +static struct imx_sc_ipc *pinctrl_ipc_handle;
>
> int imx_pinctrl_sc_ipc_init(struct platform_device *pdev)
> {
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] pinctrl: fsl: Make pinctrl_ipc_handle static
2019-03-20 14:14 [PATCH -next] pinctrl: fsl: Make pinctrl_ipc_handle static Yue Haibing
2019-03-20 19:58 ` Mukesh Ojha
@ 2019-04-04 5:17 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2019-04-04 5:17 UTC (permalink / raw)
To: Yue Haibing
Cc: Dong Aisheng, Fabio Estevam, Shawn Guo, Stefan Agner,
Sascha Hauer, linux-kernel, open list:GPIO SUBSYSTEM
On Wed, Mar 20, 2019 at 9:15 PM Yue Haibing <yuehaibing@huawei.com> wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/pinctrl/freescale/pinctrl-scu.c:38:19: warning:
> symbol 'pinctrl_ipc_handle' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-04 5:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-20 14:14 [PATCH -next] pinctrl: fsl: Make pinctrl_ipc_handle static Yue Haibing
2019-03-20 19:58 ` Mukesh Ojha
2019-04-04 5:17 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).