* [PATCH] gpio: fix gpio-adp5588 build errors
@ 2019-05-23 22:00 Randy Dunlap
2019-05-24 7:03 ` Bartosz Golaszewski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Randy Dunlap @ 2019-05-23 22:00 UTC (permalink / raw)
To: LKML, linux-gpio
Cc: kbuild test robot, Michael Hennerich, Linus Walleij, Bartosz Golaszewski
From: Randy Dunlap <rdunlap@infradead.org>
The gpio-adp5588 driver uses interfaces that are provided by
GPIOLIB_IRQCHIP, so select that symbol in its Kconfig entry.
Fixes these build errors:
../drivers/gpio/gpio-adp5588.c: In function ‘adp5588_irq_handler’:
../drivers/gpio/gpio-adp5588.c:266:26: error: ‘struct gpio_chip’ has no member named ‘irq’
dev->gpio_chip.irq.domain, gpio));
^
../drivers/gpio/gpio-adp5588.c: In function ‘adp5588_irq_setup’:
../drivers/gpio/gpio-adp5588.c:298:2: error: implicit declaration of function ‘gpiochip_irqchip_add_nested’ [-Werror=implicit-function-declaration]
ret = gpiochip_irqchip_add_nested(&dev->gpio_chip,
^
../drivers/gpio/gpio-adp5588.c:307:2: error: implicit declaration of function ‘gpiochip_set_nested_irqchip’ [-Werror=implicit-function-declaration]
gpiochip_set_nested_irqchip(&dev->gpio_chip,
^
Fixes: 459773ae8dbb ("gpio: adp5588-gpio: support interrupt controller")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Michael Hennerich <michael.hennerich@analog.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: linux-gpio@vger.kernel.org
---
drivers/gpio/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- lnx-52-rc1.orig/drivers/gpio/Kconfig
+++ lnx-52-rc1/drivers/gpio/Kconfig
@@ -822,6 +822,7 @@ config GPIO_ADP5588
config GPIO_ADP5588_IRQ
bool "Interrupt controller support for ADP5588"
depends on GPIO_ADP5588=y
+ select GPIOLIB_IRQCHIP
help
Say yes here to enable the adp5588 to be used as an interrupt
controller. It requires the driver to be built in the kernel.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio: fix gpio-adp5588 build errors
2019-05-23 22:00 [PATCH] gpio: fix gpio-adp5588 build errors Randy Dunlap
@ 2019-05-24 7:03 ` Bartosz Golaszewski
2019-05-24 7:10 ` Hennerich, Michael
2019-05-24 9:17 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2019-05-24 7:03 UTC (permalink / raw)
To: Randy Dunlap
Cc: LKML, linux-gpio, kbuild test robot, Michael Hennerich, Linus Walleij
pt., 24 maj 2019 o 00:00 Randy Dunlap <rdunlap@infradead.org> napisał(a):
>
> From: Randy Dunlap <rdunlap@infradead.org>
>
> The gpio-adp5588 driver uses interfaces that are provided by
> GPIOLIB_IRQCHIP, so select that symbol in its Kconfig entry.
>
> Fixes these build errors:
>
> ../drivers/gpio/gpio-adp5588.c: In function ‘adp5588_irq_handler’:
> ../drivers/gpio/gpio-adp5588.c:266:26: error: ‘struct gpio_chip’ has no member named ‘irq’
> dev->gpio_chip.irq.domain, gpio));
> ^
> ../drivers/gpio/gpio-adp5588.c: In function ‘adp5588_irq_setup’:
> ../drivers/gpio/gpio-adp5588.c:298:2: error: implicit declaration of function ‘gpiochip_irqchip_add_nested’ [-Werror=implicit-function-declaration]
> ret = gpiochip_irqchip_add_nested(&dev->gpio_chip,
> ^
> ../drivers/gpio/gpio-adp5588.c:307:2: error: implicit declaration of function ‘gpiochip_set_nested_irqchip’ [-Werror=implicit-function-declaration]
> gpiochip_set_nested_irqchip(&dev->gpio_chip,
> ^
>
> Fixes: 459773ae8dbb ("gpio: adp5588-gpio: support interrupt controller")
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Michael Hennerich <michael.hennerich@analog.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: linux-gpio@vger.kernel.org
> ---
> drivers/gpio/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- lnx-52-rc1.orig/drivers/gpio/Kconfig
> +++ lnx-52-rc1/drivers/gpio/Kconfig
> @@ -822,6 +822,7 @@ config GPIO_ADP5588
> config GPIO_ADP5588_IRQ
> bool "Interrupt controller support for ADP5588"
> depends on GPIO_ADP5588=y
> + select GPIOLIB_IRQCHIP
> help
> Say yes here to enable the adp5588 to be used as an interrupt
> controller. It requires the driver to be built in the kernel.
>
>
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] gpio: fix gpio-adp5588 build errors
2019-05-23 22:00 [PATCH] gpio: fix gpio-adp5588 build errors Randy Dunlap
2019-05-24 7:03 ` Bartosz Golaszewski
@ 2019-05-24 7:10 ` Hennerich, Michael
2019-05-24 9:17 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Hennerich, Michael @ 2019-05-24 7:10 UTC (permalink / raw)
To: Randy Dunlap, LKML, linux-gpio
Cc: kbuild test robot, Linus Walleij, Bartosz Golaszewski
> -----Original Message-----
> From: Randy Dunlap [mailto:rdunlap@infradead.org]
> Sent: Freitag, 24. Mai 2019 00:01
> To: LKML <linux-kernel@vger.kernel.org>; linux-gpio@vger.kernel.org
> Cc: kbuild test robot <lkp@intel.com>; Hennerich, Michael <Michael.Hennerich@analog.com>; Linus Walleij
> <linus.walleij@linaro.org>; Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Subject: [PATCH] gpio: fix gpio-adp5588 build errors
>
> From: Randy Dunlap <rdunlap@infradead.org>
>
> The gpio-adp5588 driver uses interfaces that are provided by
> GPIOLIB_IRQCHIP, so select that symbol in its Kconfig entry.
>
> Fixes these build errors:
>
> ../drivers/gpio/gpio-adp5588.c: In function ‘adp5588_irq_handler’:
> ../drivers/gpio/gpio-adp5588.c:266:26: error: ‘struct gpio_chip’ has no member named ‘irq’
> dev->gpio_chip.irq.domain, gpio));
> ^
> ../drivers/gpio/gpio-adp5588.c: In function ‘adp5588_irq_setup’:
> ../drivers/gpio/gpio-adp5588.c:298:2: error: implicit declaration of function ‘gpiochip_irqchip_add_nested’ [-Werror=implicit-
> function-declaration]
> ret = gpiochip_irqchip_add_nested(&dev->gpio_chip,
> ^
> ../drivers/gpio/gpio-adp5588.c:307:2: error: implicit declaration of function ‘gpiochip_set_nested_irqchip’ [-Werror=implicit-
> function-declaration]
> gpiochip_set_nested_irqchip(&dev->gpio_chip,
> ^
>
> Fixes: 459773ae8dbb ("gpio: adp5588-gpio: support interrupt controller")
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
> Cc: Michael Hennerich <michael.hennerich@analog.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: linux-gpio@vger.kernel.org
> ---
> drivers/gpio/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- lnx-52-rc1.orig/drivers/gpio/Kconfig
> +++ lnx-52-rc1/drivers/gpio/Kconfig
> @@ -822,6 +822,7 @@ config GPIO_ADP5588
> config GPIO_ADP5588_IRQ
> bool "Interrupt controller support for ADP5588"
> depends on GPIO_ADP5588=y
> + select GPIOLIB_IRQCHIP
> help
> Say yes here to enable the adp5588 to be used as an interrupt
> controller. It requires the driver to be built in the kernel.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio: fix gpio-adp5588 build errors
2019-05-23 22:00 [PATCH] gpio: fix gpio-adp5588 build errors Randy Dunlap
2019-05-24 7:03 ` Bartosz Golaszewski
2019-05-24 7:10 ` Hennerich, Michael
@ 2019-05-24 9:17 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2019-05-24 9:17 UTC (permalink / raw)
To: Randy Dunlap
Cc: LKML, linux-gpio, kbuild test robot, Michael Hennerich,
Bartosz Golaszewski
On Fri, May 24, 2019 at 12:00 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> The gpio-adp5588 driver uses interfaces that are provided by
> GPIOLIB_IRQCHIP, so select that symbol in its Kconfig entry.
>
> Fixes these build errors:
>
> ../drivers/gpio/gpio-adp5588.c: In function ‘adp5588_irq_handler’:
> ../drivers/gpio/gpio-adp5588.c:266:26: error: ‘struct gpio_chip’ has no member named ‘irq’
> dev->gpio_chip.irq.domain, gpio));
> ^
> ../drivers/gpio/gpio-adp5588.c: In function ‘adp5588_irq_setup’:
> ../drivers/gpio/gpio-adp5588.c:298:2: error: implicit declaration of function ‘gpiochip_irqchip_add_nested’ [-Werror=implicit-function-declaration]
> ret = gpiochip_irqchip_add_nested(&dev->gpio_chip,
> ^
> ../drivers/gpio/gpio-adp5588.c:307:2: error: implicit declaration of function ‘gpiochip_set_nested_irqchip’ [-Werror=implicit-function-declaration]
> gpiochip_set_nested_irqchip(&dev->gpio_chip,
> ^
>
> Fixes: 459773ae8dbb ("gpio: adp5588-gpio: support interrupt controller")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Michael Hennerich <michael.hennerich@analog.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: linux-gpio@vger.kernel.org
Patch applied for fixes.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-24 9:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-23 22:00 [PATCH] gpio: fix gpio-adp5588 build errors Randy Dunlap
2019-05-24 7:03 ` Bartosz Golaszewski
2019-05-24 7:10 ` Hennerich, Michael
2019-05-24 9:17 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).